Title: [124546] trunk/Source/WTF
Revision
124546
Author
[email protected]
Date
2012-08-02 18:43:05 -0700 (Thu, 02 Aug 2012)

Log Message

[WINCE] Return 0 at calculateDSTOffset(double, double)
https://bugs.webkit.org/show_bug.cgi?id=92953

Reviewed by Ryosuke Niwa.

localtime() is implemented as a call to gmtime() in ce_time.c.
Since this will never return correct values, returning 0 instead
does not remove any existing functionality, but decreases the
dependency on the (external) ce_time implementation.

* wtf/DateMath.cpp:
(WTF::calculateDSTOffsetSimple):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (124545 => 124546)


--- trunk/Source/WTF/ChangeLog	2012-08-03 01:32:28 UTC (rev 124545)
+++ trunk/Source/WTF/ChangeLog	2012-08-03 01:43:05 UTC (rev 124546)
@@ -1,3 +1,18 @@
+2012-08-02  Patrick Gansterer  <[email protected]>
+
+        [WINCE] Return 0 at calculateDSTOffset(double, double)
+        https://bugs.webkit.org/show_bug.cgi?id=92953
+
+        Reviewed by Ryosuke Niwa.
+
+        localtime() is implemented as a call to gmtime() in ce_time.c.
+        Since this will never return correct values, returning 0 instead
+        does not remove any existing functionality, but decreases the
+        dependency on the (external) ce_time implementation.
+
+        * wtf/DateMath.cpp:
+        (WTF::calculateDSTOffsetSimple):
+
 2012-08-02  Arnaud Renevier  <[email protected]>
 
         TypedArray set method is slow when called with another typed array

Modified: trunk/Source/WTF/wtf/DateMath.cpp (124545 => 124546)


--- trunk/Source/WTF/wtf/DateMath.cpp	2012-08-03 01:32:28 UTC (rev 124545)
+++ trunk/Source/WTF/wtf/DateMath.cpp	2012-08-03 01:43:05 UTC (rev 124546)
@@ -402,6 +402,11 @@
  */
 static double calculateDSTOffsetSimple(double localTimeSeconds, double utcOffset)
 {
+#if OS(WINCE)
+    UNUSED_PARAM(localTimeSeconds);
+    UNUSED_PARAM(utcOffset);
+    return 0;
+#else
     if (localTimeSeconds > maxUnixTime)
         localTimeSeconds = maxUnixTime;
     else if (localTimeSeconds < 0) // Go ahead a day to make localtime work (does not work with 0)
@@ -426,6 +431,7 @@
         diff += secondsPerDay;
 
     return (diff * msPerSecond);
+#endif
 }
 
 // Get the DST offset, given a time in UTC
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to