Title: [124244] trunk/Tools
Revision
124244
Author
commit-qu...@webkit.org
Date
2012-07-31 13:30:30 -0700 (Tue, 31 Jul 2012)

Log Message

[EFL] Dump a backtrace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92489

Patch by Thiago Marcos P. Santos <thiago.san...@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.

Dump a stack trace in case of a unexpected signal. This should
provide a better report at the build bots when WTR crashes.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(main):
* TestWebKitAPI/efl/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WTR::InjectedBundle::platformInitialize):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (124243 => 124244)


--- trunk/Tools/ChangeLog	2012-07-31 20:24:46 UTC (rev 124243)
+++ trunk/Tools/ChangeLog	2012-07-31 20:30:30 UTC (rev 124244)
@@ -1,3 +1,20 @@
+2012-07-31  Thiago Marcos P. Santos  <thiago.san...@intel.com>
+
+        [EFL] Dump a backtrace in case of a crash
+        https://bugs.webkit.org/show_bug.cgi?id=92489
+
+        Reviewed by Csaba Osztrogonác.
+
+        Dump a stack trace in case of a unexpected signal. This should
+        provide a better report at the build bots when WTR crashes.
+
+        * DumpRenderTree/efl/DumpRenderTree.cpp:
+        (main):
+        * TestWebKitAPI/efl/InjectedBundleController.cpp:
+        (TestWebKitAPI::InjectedBundleController::platformInitialize):
+        * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
+        (WTR::InjectedBundle::platformInitialize):
+
 2012-07-31  Joshua Netterfield  <jnetterfi...@rim.com>
 
         [BlackBerry] Enable CSS Filter Effects

Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp (124243 => 124244)


--- trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp	2012-07-31 20:24:46 UTC (rev 124243)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp	2012-07-31 20:30:30 UTC (rev 124244)
@@ -48,6 +48,7 @@
 #include <getopt.h>
 #include <stdlib.h>
 #include <unistd.h>
+#include <wtf/Assertions.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/text/CString.h>
 #include <wtf/text/StringBuilder.h>
@@ -450,6 +451,8 @@
     if (!initEfl())
         return EXIT_FAILURE;
 
+    WTFInstallReportBacktraceOnCrashHook();
+
     OwnPtr<Ecore_Evas> ecoreEvas = adoptPtr(initEcoreEvas());
     browser = DumpRenderTreeChrome::create(ecore_evas_get(ecoreEvas.get()));
     addFontsToEnvironment();

Modified: trunk/Tools/TestWebKitAPI/efl/InjectedBundleController.cpp (124243 => 124244)


--- trunk/Tools/TestWebKitAPI/efl/InjectedBundleController.cpp	2012-07-31 20:24:46 UTC (rev 124243)
+++ trunk/Tools/TestWebKitAPI/efl/InjectedBundleController.cpp	2012-07-31 20:30:30 UTC (rev 124244)
@@ -26,10 +26,13 @@
 #include "config.h"
 #include "InjectedBundleController.h"
 
+#include <wtf/Assertions.h>
+
 namespace TestWebKitAPI {
 
 void InjectedBundleController::platformInitialize()
 {
+    WTFInstallReportBacktraceOnCrashHook();
 }
 
 } // namespace TestWebKitAPI

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp (124243 => 124244)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp	2012-07-31 20:24:46 UTC (rev 124243)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp	2012-07-31 20:30:30 UTC (rev 124244)
@@ -20,13 +20,13 @@
 #include "config.h"
 #include "InjectedBundle.h"
 
-#include <WebCore/NotImplemented.h>
+#include <wtf/Assertions.h>
 
 namespace WTR {
 
 void InjectedBundle::platformInitialize(WKTypeRef)
 {
-    notImplemented();
+    WTFInstallReportBacktraceOnCrashHook();
 }
 
 } // namespace WTR
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to