Title: [123279] trunk/Tools
- Revision
- 123279
- Author
- [email protected]
- Date
- 2012-07-20 17:28:58 -0700 (Fri, 20 Jul 2012)
Log Message
[Chromium-Android] Store test pipes in /data/local/tmp
https://bugs.webkit.org/show_bug.cgi?id=91909
In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
However after tests we found some devices don't allow the app to create pipes there.
So /data/local/tmp is a better place for the pipes.
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (123278 => 123279)
--- trunk/Tools/ChangeLog 2012-07-21 00:24:58 UTC (rev 123278)
+++ trunk/Tools/ChangeLog 2012-07-21 00:28:58 UTC (rev 123279)
@@ -1,5 +1,18 @@
2012-07-20 Xianzhu Wang <[email protected]>
+ [Chromium-Android] Store test pipes in /data/local/tmp
+ https://bugs.webkit.org/show_bug.cgi?id=91909
+
+ In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
+ However after tests we found some devices don't allow the app to create pipes there.
+ So /data/local/tmp is a better place for the pipes.
+
+ Reviewed by Adam Barth.
+
+ * Scripts/webkitpy/layout_tests/port/chromium_android.py:
+
+2012-07-20 Xianzhu Wang <[email protected]>
+
[Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
https://bugs.webkit.org/show_bug.cgi?id=91873
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (123278 => 123279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-07-21 00:24:58 UTC (rev 123278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-07-21 00:28:58 UTC (rev 123279)
@@ -58,7 +58,7 @@
DRT_APP_PACKAGE = 'org.chromium.native_test'
DRT_ACTIVITY_FULL_NAME = DRT_APP_PACKAGE + '/.ChromeNativeTestActivity'
DRT_APP_DIR = '/data/user/0/' + DRT_APP_PACKAGE + '/'
-DRT_APP_FILES_DIR = '/sdcard/native_tests/'
+DRT_APP_FILES_DIR = DEVICE_SOURCE_ROOT_DIR
DRT_APP_CACHE_DIR = DRT_APP_DIR + 'cache/'
# This only works for single core devices so far.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes