Title: [123272] trunk
Revision
123272
Author
[email protected]
Date
2012-07-20 16:06:14 -0700 (Fri, 20 Jul 2012)

Log Message

[chromium] Don't display fullscreen button for video elements not containing video
https://bugs.webkit.org/show_bug.cgi?id=91811

Reviewed by Eric Carlson.

Covered by media/media-document-audio-repaint.html

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::reset):

Modified Paths

Diff

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123271 => 123272)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 23:03:35 UTC (rev 123271)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 23:06:14 UTC (rev 123272)
@@ -3639,3 +3639,6 @@
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist-rtl.html = IMAGE
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html = IMAGE
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist.html = IMAGE
+
+// Needs rebaseline.
+BUGWK91811 : media/media-document-audio-repaint.html = IMAGE+TEXT

Modified: trunk/Source/WebCore/ChangeLog (123271 => 123272)


--- trunk/Source/WebCore/ChangeLog	2012-07-20 23:03:35 UTC (rev 123271)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 23:06:14 UTC (rev 123272)
@@ -1,3 +1,15 @@
+2012-07-20  Andrew Scherkus  <[email protected]>
+
+        [chromium] Don't display fullscreen button for video elements not containing video
+        https://bugs.webkit.org/show_bug.cgi?id=91811
+
+        Reviewed by Eric Carlson.
+
+        Covered by media/media-document-audio-repaint.html
+
+        * html/shadow/MediaControlRootElementChromium.cpp:
+        (WebCore::MediaControlRootElementChromium::reset):
+
 2012-07-20  Dmitry Titov  <[email protected]>
 
         [Chromium] Out of Memory is observed when a large object is passed to a Web Worker.

Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp (123271 => 123272)


--- trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2012-07-20 23:03:35 UTC (rev 123271)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2012-07-20 23:06:14 UTC (rev 123272)
@@ -244,7 +244,7 @@
         }
     }
 
-    if (m_mediaController->supportsFullscreen())
+    if (m_mediaController->supportsFullscreen() && m_mediaController->hasVideo())
         m_fullscreenButton->show();
     else
         m_fullscreenButton->hide();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to