Title: [123143] trunk/Tools
- Revision
- 123143
- Author
- dpra...@chromium.org
- Date
- 2012-07-19 13:19:43 -0700 (Thu, 19 Jul 2012)
Log Message
test-webkitpy: fix executive_unittest nits, including a missing 'errno' import
https://bugs.webkit.org/show_bug.cgi?id=91770
Reviewed by Adam Barth.
The missing errno import is causing a flaky failure when run in
parallel on the bots.
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.assert_interpreter_for_content):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (123142 => 123143)
--- trunk/Tools/ChangeLog 2012-07-19 20:08:17 UTC (rev 123142)
+++ trunk/Tools/ChangeLog 2012-07-19 20:19:43 UTC (rev 123143)
@@ -1,3 +1,16 @@
+2012-07-19 Dirk Pranke <dpra...@chromium.org>
+
+ test-webkitpy: fix executive_unittest nits, including a missing 'errno' import
+ https://bugs.webkit.org/show_bug.cgi?id=91770
+
+ Reviewed by Adam Barth.
+
+ The missing errno import is causing a flaky failure when run in
+ parallel on the bots.
+
+ * Scripts/webkitpy/common/system/executive_unittest.py:
+ (ExecutiveTest.assert_interpreter_for_content):
+
2012-07-19 Oliver Hunt <oli...@apple.com>
Make style bot handle underscores in names more reasonably
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py (123142 => 123143)
--- trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-07-19 20:08:17 UTC (rev 123142)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-07-19 20:19:43 UTC (rev 123143)
@@ -28,6 +28,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import os
+import errno
import signal
import subprocess
import sys
@@ -77,8 +78,6 @@
class ExecutiveTest(unittest.TestCase):
def assert_interpreter_for_content(self, intepreter, content):
fs = MockFileSystem()
- file_path = None
- file_interpreter = None
tempfile, temp_name = fs.open_binary_tempfile('')
tempfile.write(content)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
