Title: [122740] trunk/Source/WebCore
- Revision
- 122740
- Author
- [email protected]
- Date
- 2012-07-16 11:14:02 -0700 (Mon, 16 Jul 2012)
Log Message
[Android] remove RenderThemeChromiumAndroid::paintMediaFullscreenButton()
https://bugs.webkit.org/show_bug.cgi?id=91291
Patch by Min Qin <[email protected]> on 2012-07-16
Reviewed by Adam Barth.
The recent media control refactoring added paintMediaFullscreenButton() in RenderThemeChromiumSkia.
Since RenderThemeChromiumAndroid inherits from that class, we don't need to redefine this function.
No test needed as this change just removes an unnecessary override.
* rendering/RenderThemeChromiumAndroid.cpp:
* rendering/RenderThemeChromiumAndroid.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122739 => 122740)
--- trunk/Source/WebCore/ChangeLog 2012-07-16 18:10:58 UTC (rev 122739)
+++ trunk/Source/WebCore/ChangeLog 2012-07-16 18:14:02 UTC (rev 122740)
@@ -1,3 +1,17 @@
+2012-07-16 Min Qin <[email protected]>
+
+ [Android] remove RenderThemeChromiumAndroid::paintMediaFullscreenButton()
+ https://bugs.webkit.org/show_bug.cgi?id=91291
+
+ Reviewed by Adam Barth.
+
+ The recent media control refactoring added paintMediaFullscreenButton() in RenderThemeChromiumSkia.
+ Since RenderThemeChromiumAndroid inherits from that class, we don't need to redefine this function.
+ No test needed as this change just removes an unnecessary override.
+
+ * rendering/RenderThemeChromiumAndroid.cpp:
+ * rendering/RenderThemeChromiumAndroid.h:
+
2012-07-16 Peter Rybin <[email protected]>
Web Inspector: CodeGeneratorInspector.py: fix output write logic to support incremental build
Modified: trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp (122739 => 122740)
--- trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp 2012-07-16 18:10:58 UTC (rev 122739)
+++ trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp 2012-07-16 18:14:02 UTC (rev 122740)
@@ -87,18 +87,6 @@
}
}
-bool RenderThemeChromiumAndroid::paintMediaFullscreenButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
-{
-#if ENABLE(VIDEO)
- return RenderMediaControlsChromium::paintMediaControlsPart(MediaEnterFullscreenButton, object, paintInfo, rect);
-#else
- UNUSED_PARAM(object);
- UNUSED_PARAM(paintInfo);
- UNUSED_PARAM(rect);
- return false;
-#endif
-}
-
int RenderThemeChromiumAndroid::menuListArrowPadding() const
{
// We cannot use the scrollbar thickness here, as it's width is 0 on Android.
Modified: trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h (122739 => 122740)
--- trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h 2012-07-16 18:10:58 UTC (rev 122739)
+++ trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h 2012-07-16 18:14:02 UTC (rev 122740)
@@ -41,8 +41,6 @@
virtual bool delegatesMenuListRendering() const OVERRIDE { return true; }
- virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;
-
#if ENABLE(VIDEO)
virtual String extraMediaControlsStyleSheet() OVERRIDE;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
