Title: [122614] trunk/Source/WebCore
- Revision
- 122614
- Author
- hara...@chromium.org
- Date
- 2012-07-13 12:05:21 -0700 (Fri, 13 Jul 2012)
Log Message
[V8] String wrappers should be marked Independent
https://bugs.webkit.org/show_bug.cgi?id=91251
Reviewed by Adam Barth.
Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.
I tried to find some cases where this change reduces memory usage,
but couldn't due to sensitive behavior of GC.
No tests. No change in behavior.
* bindings/v8/V8Binding.cpp:
(WebCore::StringCache::v8ExternalStringSlow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122613 => 122614)
--- trunk/Source/WebCore/ChangeLog 2012-07-13 19:00:01 UTC (rev 122613)
+++ trunk/Source/WebCore/ChangeLog 2012-07-13 19:05:21 UTC (rev 122614)
@@ -1,3 +1,21 @@
+2012-07-13 Kentaro Hara <hara...@chromium.org>
+
+ [V8] String wrappers should be marked Independent
+ https://bugs.webkit.org/show_bug.cgi?id=91251
+
+ Reviewed by Adam Barth.
+
+ Currently V8 String wrappers are not marked Independent.
+ By marking them Independent, they can be reclaimed by the scavenger GC.
+
+ I tried to find some cases where this change reduces memory usage,
+ but couldn't due to sensitive behavior of GC.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8Binding.cpp:
+ (WebCore::StringCache::v8ExternalStringSlow):
+
2012-07-13 Peter Beverloo <pe...@chromium.org>
[Chromium] Make the v8 i18n API dependency conditional for Android, disable strict aliasing
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (122613 => 122614)
--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-07-13 19:00:01 UTC (rev 122613)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-07-13 19:05:21 UTC (rev 122614)
@@ -493,6 +493,7 @@
return newString;
stringImpl->ref();
+ wrapper.MarkIndependent();
wrapper.MakeWeak(stringImpl, cachedStringCallback);
m_stringCache.set(stringImpl, *wrapper);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
