Title: [122535] trunk/Source/WebCore
- Revision
- 122535
- Author
- a...@chromium.org
- Date
- 2012-07-12 18:53:17 -0700 (Thu, 12 Jul 2012)
Log Message
[V8] Simplify CodeGeneratorV8 since V8OnProto is only true for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=91165
Reviewed by Nate Chapin.
The old code was dead code since V8OnProto only ever gets set to 1 for DOMWindow.
No new tests. No change in functionality.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122534 => 122535)
--- trunk/Source/WebCore/ChangeLog 2012-07-13 01:26:53 UTC (rev 122534)
+++ trunk/Source/WebCore/ChangeLog 2012-07-13 01:53:17 UTC (rev 122535)
@@ -1,3 +1,17 @@
+2012-07-12 Erik Arvidsson <a...@chromium.org>
+
+ [V8] Simplify CodeGeneratorV8 since V8OnProto is only true for DOMWindow
+ https://bugs.webkit.org/show_bug.cgi?id=91165
+
+ Reviewed by Nate Chapin.
+
+ The old code was dead code since V8OnProto only ever gets set to 1 for DOMWindow.
+
+ No new tests. No change in functionality.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateNormalAttrSetter):
+
2012-07-12 Ryosuke Niwa <rn...@webkit.org>
Build fix. Initialize unused const member variables to make compilers happy.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (122534 => 122535)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-07-13 01:26:53 UTC (rev 122534)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-07-13 01:53:17 UTC (rev 122535)
@@ -1134,21 +1134,9 @@
push(@implContentDecls, " $svgWrappedNativeType* imp = &impInstance;\n");
}
} elsif ($attrExt->{"V8OnProto"}) {
- if ($interfaceName eq "DOMWindow") {
push(@implContentDecls, <<END);
- v8::Handle<v8::Object> holder = info.Holder();
+ ${implClassName}* imp = V8${implClassName}::toNative(info.Holder());
END
- } else {
- # perform lookup first
- push(@implContentDecls, <<END);
- v8::Handle<v8::Object> holder = V8DOMWrapper::lookupDOMWrapper(V8${interfaceName}::GetTemplate(), info.This());
- if (holder.IsEmpty())
- return;
-END
- }
- push(@implContentDecls, <<END);
- ${implClassName}* imp = V8${implClassName}::toNative(holder);
-END
} else {
my $attrType = GetTypeFromSignature($attribute->signature);
my $reflect = $attribute->signature->extendedAttributes->{"Reflect"};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
