Title: [122356] trunk/Source
Revision
122356
Author
[email protected]
Date
2012-07-11 12:41:03 -0700 (Wed, 11 Jul 2012)

Log Message

Add -Wtautological-compare and -Wsign-compare warning flags
https://bugs.webkit.org/show_bug.cgi?id=90994

Reviewed by Mark Rowe.

Source/_javascript_Core:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (122355 => 122356)


--- trunk/Source/_javascript_Core/ChangeLog	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-07-11 19:41:03 UTC (rev 122356)
@@ -1,3 +1,12 @@
+2012-07-11  Anders Carlsson  <[email protected]>
+
+        Add -Wtautological-compare and -Wsign-compare warning flags
+        https://bugs.webkit.org/show_bug.cgi?id=90994
+
+        Reviewed by Mark Rowe.
+
+        * Configurations/Base.xcconfig:
+
 2012-07-11  Benjamin Poulain  <[email protected]>
 
         Simplify the copying of JSC ARMv7's LinkRecord

Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (122355 => 122356)


--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2012-07-11 19:41:03 UTC (rev 122356)
@@ -24,7 +24,7 @@
 #include "CompilerVersion.xcconfig"
 
 COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
-COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
+COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
 
 CLANG_WARN_CXX0X_EXTENSIONS = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
@@ -54,6 +54,7 @@
 GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
 GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+GCC_WARN_SIGN_COMPARE = YES;
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
 PREBINDING = NO;
 VALID_ARCHS = $(VALID_ARCHS_$(REAL_PLATFORM_NAME));

Modified: trunk/Source/WTF/ChangeLog (122355 => 122356)


--- trunk/Source/WTF/ChangeLog	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WTF/ChangeLog	2012-07-11 19:41:03 UTC (rev 122356)
@@ -1,3 +1,12 @@
+2012-07-11  Anders Carlsson  <[email protected]>
+
+        Add -Wtautological-compare and -Wsign-compare warning flags
+        https://bugs.webkit.org/show_bug.cgi?id=90994
+
+        Reviewed by Mark Rowe.
+
+        * Configurations/Base.xcconfig:
+
 2012-07-10  Jocelyn Turcotte  <[email protected]>
 
         Re-enable __declspec(dl{import,export}) for MinGW when using EXPORT_MACROS

Modified: trunk/Source/WTF/Configurations/Base.xcconfig (122355 => 122356)


--- trunk/Source/WTF/Configurations/Base.xcconfig	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WTF/Configurations/Base.xcconfig	2012-07-11 19:41:03 UTC (rev 122356)
@@ -24,7 +24,7 @@
 #include "CompilerVersion.xcconfig"
 
 COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
-COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
+COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
 
 CLANG_WARN_CXX0X_EXTENSIONS = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
@@ -54,6 +54,7 @@
 GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
 GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+GCC_WARN_SIGN_COMPARE = YES;
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
 PREBINDING = NO;
 VALID_ARCHS = $(VALID_ARCHS_$(REAL_PLATFORM_NAME));

Modified: trunk/Source/WebCore/ChangeLog (122355 => 122356)


--- trunk/Source/WebCore/ChangeLog	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WebCore/ChangeLog	2012-07-11 19:41:03 UTC (rev 122356)
@@ -1,3 +1,12 @@
+2012-07-11  Anders Carlsson  <[email protected]>
+
+        Add -Wtautological-compare and -Wsign-compare warning flags
+        https://bugs.webkit.org/show_bug.cgi?id=90994
+
+        Reviewed by Mark Rowe.
+
+        * Configurations/Base.xcconfig:
+
 2012-07-11  Dean Jackson  <[email protected]>
 
         TileCache layers have wrong border debug color

Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (122355 => 122356)


--- trunk/Source/WebCore/Configurations/Base.xcconfig	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig	2012-07-11 19:41:03 UTC (rev 122356)
@@ -24,7 +24,7 @@
 #include "CompilerVersion.xcconfig"
 
 COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
-COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
+COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
 
 CLANG_WARN_CXX0X_EXTENSIONS = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
@@ -51,6 +51,7 @@
 GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
 GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+GCC_WARN_SIGN_COMPARE = YES;
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
 PREBINDING = NO;
 VALID_ARCHS = $(VALID_ARCHS_$(REAL_PLATFORM_NAME));

Modified: trunk/Source/WebKit/mac/ChangeLog (122355 => 122356)


--- trunk/Source/WebKit/mac/ChangeLog	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-07-11 19:41:03 UTC (rev 122356)
@@ -1,3 +1,12 @@
+2012-07-11  Anders Carlsson  <[email protected]>
+
+        Add -Wtautological-compare and -Wsign-compare warning flags
+        https://bugs.webkit.org/show_bug.cgi?id=90994
+
+        Reviewed by Mark Rowe.
+
+        * Configurations/Base.xcconfig:
+
 2012-07-11  Mark Rowe  <[email protected]>
 
         Add a Mountain Lion version of libWebKitSystemInterface.a.

Modified: trunk/Source/WebKit/mac/Configurations/Base.xcconfig (122355 => 122356)


--- trunk/Source/WebKit/mac/Configurations/Base.xcconfig	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WebKit/mac/Configurations/Base.xcconfig	2012-07-11 19:41:03 UTC (rev 122356)
@@ -24,7 +24,7 @@
 #include "CompilerVersion.xcconfig"
 
 COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
-COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
+COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
 
 CLANG_WARN_CXX0X_EXTENSIONS = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
@@ -51,6 +51,7 @@
 GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
 GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+GCC_WARN_SIGN_COMPARE = YES;
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
 OTHER_MIGFLAGS = -F$(BUILT_PRODUCTS_DIR);
 PREBINDING = NO;

Modified: trunk/Source/WebKit2/ChangeLog (122355 => 122356)


--- trunk/Source/WebKit2/ChangeLog	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-11 19:41:03 UTC (rev 122356)
@@ -1,3 +1,12 @@
+2012-07-11  Anders Carlsson  <[email protected]>
+
+        Add -Wtautological-compare and -Wsign-compare warning flags
+        https://bugs.webkit.org/show_bug.cgi?id=90994
+
+        Reviewed by Mark Rowe.
+
+        * Configurations/Base.xcconfig:
+
 2012-07-11  No'am Rosenthal  <[email protected]>
 
         [Qt][WK2] Test actual rendering results in API tests

Modified: trunk/Source/WebKit2/Configurations/Base.xcconfig (122355 => 122356)


--- trunk/Source/WebKit2/Configurations/Base.xcconfig	2012-07-11 19:29:43 UTC (rev 122355)
+++ trunk/Source/WebKit2/Configurations/Base.xcconfig	2012-07-11 19:41:03 UTC (rev 122356)
@@ -24,7 +24,7 @@
 #include "CompilerVersion.xcconfig"
 
 COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
-COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
+COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
 
 CLANG_WARN_CXX0X_EXTENSIONS = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
@@ -49,6 +49,7 @@
 GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
 GCC_WARN_ABOUT_RETURN_TYPE = YES;
 GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+GCC_WARN_SIGN_COMPARE = YES;
 GCC_WARN_UNUSED_VARIABLE = YES;
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
 OTHER_MIGFLAGS = -F$(BUILT_PRODUCTS_DIR);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to