Title: [122342] trunk/Source/WebCore
- Revision
- 122342
- Author
- [email protected]
- Date
- 2012-07-11 10:50:47 -0700 (Wed, 11 Jul 2012)
Log Message
REGRESSION (r116203): overflow sections don't have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=90052
Reviewed by Simon Fraser.
This issue stems from RenderLayers with overlay scrollbars not being considered
self-painting.
After r120395 (follow-up of r116203), we ignore subtrees that have no self-painting layer for
painting. Normal scrollbars are painted by their renderer so they were properly painted. However
overlay scrollbars need to be painted by their RenderLayer as a separate phase (see bug 57057) so
they were not painted anymore. The fix is simple: make RenderLayer with overlay scrollbars
self-painting as they should have been in the first place.
Unfortunately no tests as I don't think we have a good way of testing overlay
scrollbars. Tested manually though on the super simple test case from the bug.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Overlay scrollbars make the layer self-painting.
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Added a call to updateSelfPaintingLayer.
(WebCore::RenderLayer::styleChanged):
Moved the call to updateSelfPaintingLayer after recomputing the scrollbars to ensure proper behavior.
Added a comment underlining the reason.
(WebCore::RenderLayer::updateSelfPaintingLayer):
Renamed as it is now called during layout too.
* rendering/RenderLayer.h:
(RenderLayer): Updated after updateSelfPaintingLayer rename.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122341 => 122342)
--- trunk/Source/WebCore/ChangeLog 2012-07-11 17:50:15 UTC (rev 122341)
+++ trunk/Source/WebCore/ChangeLog 2012-07-11 17:50:47 UTC (rev 122342)
@@ -1,3 +1,39 @@
+2012-07-11 Julien Chaffraix <[email protected]>
+
+ REGRESSION (r116203): overflow sections don't have scrollbars
+ https://bugs.webkit.org/show_bug.cgi?id=90052
+
+ Reviewed by Simon Fraser.
+
+ This issue stems from RenderLayers with overlay scrollbars not being considered
+ self-painting.
+
+ After r120395 (follow-up of r116203), we ignore subtrees that have no self-painting layer for
+ painting. Normal scrollbars are painted by their renderer so they were properly painted. However
+ overlay scrollbars need to be painted by their RenderLayer as a separate phase (see bug 57057) so
+ they were not painted anymore. The fix is simple: make RenderLayer with overlay scrollbars
+ self-painting as they should have been in the first place.
+
+ Unfortunately no tests as I don't think we have a good way of testing overlay
+ scrollbars. Tested manually though on the super simple test case from the bug.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::shouldBeSelfPaintingLayer):
+ Overlay scrollbars make the layer self-painting.
+
+ (WebCore::RenderLayer::updateScrollbarsAfterLayout):
+ Added a call to updateSelfPaintingLayer.
+
+ (WebCore::RenderLayer::styleChanged):
+ Moved the call to updateSelfPaintingLayer after recomputing the scrollbars to ensure proper behavior.
+ Added a comment underlining the reason.
+
+ (WebCore::RenderLayer::updateSelfPaintingLayer):
+ Renamed as it is now called during layout too.
+
+ * rendering/RenderLayer.h:
+ (RenderLayer): Updated after updateSelfPaintingLayer rename.
+
2012-07-11 Allan Sandfeld Jensen <[email protected]>
NodesFromRect doesn't work on SVG root elements.
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (122341 => 122342)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-07-11 17:50:15 UTC (rev 122341)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-07-11 17:50:47 UTC (rev 122342)
@@ -2534,6 +2534,8 @@
if (box->hasAutoVerticalScrollbar())
setHasVerticalScrollbar(hasVerticalOverflow);
+ updateSelfPaintingLayer();
+
#if ENABLE(DASHBOARD_SUPPORT)
// Force an update since we know the scrollbars have changed things.
if (renderer()->document()->hasDashboardRegions())
@@ -4740,6 +4742,7 @@
bool RenderLayer::shouldBeSelfPaintingLayer() const
{
return !isNormalFlowOnly()
+ || hasOverlayScrollbars()
|| renderer()->hasReflection()
|| renderer()->hasMask()
|| renderer()->isTableRow()
@@ -4750,7 +4753,7 @@
|| renderer()->isRenderIFrame();
}
-void RenderLayer::updateSelfPaintingLayerAfterStyleChange(const RenderStyle*)
+void RenderLayer::updateSelfPaintingLayer()
{
bool isSelfPaintingLayer = shouldBeSelfPaintingLayer();
if (m_isSelfPaintingLayer == isSelfPaintingLayer)
@@ -4845,9 +4848,11 @@
m_marquee = 0;
}
- updateSelfPaintingLayerAfterStyleChange(oldStyle);
updateStackingContextsAfterStyleChange(oldStyle);
updateScrollbarsAfterStyleChange(oldStyle);
+ // Overlay scrollbars can make this layer self-painting so we need
+ // to recompute the bit once scrollbars have been updated.
+ updateSelfPaintingLayer();
if (!hasReflection() && m_reflection)
removeReflection();
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (122341 => 122342)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2012-07-11 17:50:15 UTC (rev 122341)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2012-07-11 17:50:47 UTC (rev 122342)
@@ -679,7 +679,7 @@
bool shouldRepaintAfterLayout() const;
- void updateSelfPaintingLayerAfterStyleChange(const RenderStyle* oldStyle);
+ void updateSelfPaintingLayer();
void updateStackingContextsAfterStyleChange(const RenderStyle* oldStyle);
void updateScrollbarsAfterStyleChange(const RenderStyle* oldStyle);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes