Title: [122037] trunk/Source/WebCore
Revision
122037
Author
[email protected]
Date
2012-07-06 15:44:57 -0700 (Fri, 06 Jul 2012)

Log Message

[Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
https://bugs.webkit.org/show_bug.cgi?id=90705

Patch by Lauro Neto <[email protected]> on 2012-07-06
Reviewed by Noam Rosenthal.

Use QImage.constBits() as argument to packPixels instead of bits() to avoid
deep copying it.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (122036 => 122037)


--- trunk/Source/WebCore/ChangeLog	2012-07-06 22:13:31 UTC (rev 122036)
+++ trunk/Source/WebCore/ChangeLog	2012-07-06 22:44:57 UTC (rev 122037)
@@ -1,3 +1,16 @@
+2012-07-06  Lauro Neto  <[email protected]>
+
+        [Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
+        https://bugs.webkit.org/show_bug.cgi?id=90705
+
+        Reviewed by Noam Rosenthal.
+
+        Use QImage.constBits() as argument to packPixels instead of bits() to avoid
+        deep copying it.
+
+        * platform/graphics/qt/GraphicsContext3DQt.cpp:
+        (WebCore::GraphicsContext3D::getImageData):
+
 2012-07-06  Andy Estes  <[email protected]>
 
         Fix errors reported by generate-bindings.pl after r121882.

Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (122036 => 122037)


--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-07-06 22:13:31 UTC (rev 122036)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-07-06 22:44:57 UTC (rev 122037)
@@ -529,7 +529,7 @@
 
     outputVector.resize(packedSize);
 
-    return packPixels(qtImage.bits(), SourceFormatBGRA8, image->width(), image->height(), 0, format, type, alphaOp, outputVector.data());
+    return packPixels(qtImage.constBits(), SourceFormatBGRA8, image->width(), image->height(), 0, format, type, alphaOp, outputVector.data());
 }
 
 void GraphicsContext3D::setContextLostCallback(PassOwnPtr<ContextLostCallback>)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to