Title: [122012] releases/WebKitGTK/webkit-1.8
Revision
122012
Author
[email protected]
Date
2012-07-06 13:04:30 -0700 (Fri, 06 Jul 2012)

Log Message

Merge 117572 - https://bugs.webkit.org/show_bug.cgi?id=85515
Stale frame in WebCore::SpellChecker::didCheckSucceeded

Source/WebCore:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

Added EditorClient::frameWillDetachPage() notification to give a
change to invalidate pending spellcheck requests on the client.

Test: editing/spelling/spellcheck-async-remove-frame.html

* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/Editor.h:
(Editor):
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::frameWillDetachPage):
* page/EditorClient.h:
(EditorClient):

Source/WebKit/blackberry:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebCoreSupport/EditorClientBlackBerry.h:
(WebCore::EditorClientBlackBerry::frameWillDetachPage):

Source/WebKit/chromium:

Added WebTextCheckingCompletionImpl::invalidate() to mark
pending spellcheck request as invalid, and added frameWillDetachPage()
to fire it.

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit):
(WebKit::EditorClientImpl::requestCheckingOfString):
(WebKit::EditorClientImpl::didCheckString):
* src/EditorClientImpl.h:
(WebKit):
(EditorClientImpl):
* src/WebTextCheckingCompletionImpl.cpp:
(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
(WebKit::WebTextCheckingCompletionImpl::invalidate):
(WebKit):
* src/WebTextCheckingCompletionImpl.h:
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):
(WebKit::WebTextCheckingCompletionImpl::spellChecker):

Source/WebKit/efl:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::frameWillDetachPage):

Source/WebKit/gtk:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebCoreSupport/EditorClientGtk.h:
(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebCoreSupport/WebEditorClient.h:

Source/WebKit/qt:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebCoreSupport/EditorClientQt.h:
(WebCore::EditorClientQt::frameWillDetachPage):

Source/WebKit/win:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebCoreSupport/EditorClientWinCE.h:
(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* WebKitSupport/EditorClientWx.h:
(WebCore::EditorClientWx::frameWillDetachPage):

LayoutTests:

Patch by MORITA Hajime <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.

* editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
* editing/spelling/spellcheck-async-remove-frame.html: Added.

Modified Paths

Added Paths

Diff

Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
+        * editing/spelling/spellcheck-async-remove-frame.html: Added.
+
 2012-05-02  Philippe Normand  <[email protected]>
 
         [GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails

Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame-expected.txt (0 => 122012)


--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame-expected.txt	                        (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame-expected.txt	2012-07-06 20:04:30 UTC (rev 122012)
@@ -0,0 +1,2 @@
+PASS unless crash.
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame-expected.txt
___________________________________________________________________

Added: svn:eol-style

Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame.html (0 => 122012)


--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame.html	                        (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame.html	2012-07-06 20:04:30 UTC (rev 122012)
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script>
+if (window.layoutTestController) {
+    layoutTestController.waitUntilDone();
+    layoutTestController.dumpAsText();
+    layoutTestController.setAsynchronousSpellCheckingEnabled(true);
+    internals.settings.setUnifiedTextCheckingEnabled(true);
+}
+
+function runTest() {
+    var textToSelect = "This text should be selected, but this frame shouldn't be focused.";
+    var frame = document.getElementById("frame");
+    var s = frame.contentDocument.getSelection();
+    s.setPosition(frame.contentDocument.body, 0);
+    frame.contentDocument.execCommand("InsertText", false, textToSelect);
+    frame.parentNode.removeChild(frame);
+    window.setTimeout(function() {
+        if (window.layoutTestController)
+            layoutTestController.notifyDone();
+    }, 50);
+}
+</script>
+</head>
+<body>
+<div>PASS unless crash.</div>
+<iframe id="frame" src="" _onload_="runTest();"></iframe>
+</body>
+</html>
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/spelling/spellcheck-async-remove-frame.html
___________________________________________________________________

Added: svn:eol-style

Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,24 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        Added EditorClient::frameWillDetachPage() notification to give a
+        change to invalidate pending spellcheck requests on the client.
+
+        Test: editing/spelling/spellcheck-async-remove-frame.html
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::Editor):
+        * editing/Editor.h:
+        (Editor):
+        * loader/EmptyClients.h:
+        (WebCore::EmptyEditorClient::frameWillDetachPage):
+        * page/EditorClient.h:
+        (EditorClient):
+
 2012-05-02  Philippe Normand  <[email protected]>
 
         [GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails

Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/Editor.cpp (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/Editor.cpp	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/Editor.cpp	2012-07-06 20:04:30 UTC (rev 122012)
@@ -836,7 +836,7 @@
 }
 
 Editor::Editor(Frame* frame)
-    : m_frame(frame)
+    : FrameDestructionObserver(frame)
     , m_deleteButtonController(adoptPtr(new DeleteButtonController(frame)))
     , m_ignoreCompositionSelectionChange(false)
     , m_shouldStartNewKillRingSequence(false)
@@ -3018,4 +3018,10 @@
     return WebCore::unifiedTextCheckerEnabled(m_frame);
 }
 
+void Editor::willDetachPage() OVERRIDE
+{
+    if (EditorClient* editorClient = client())
+        editorClient->frameWillDetachPage(frame());
+}
+
 } // namespace WebCore

Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/Editor.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/Editor.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/Editor.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -34,6 +34,7 @@
 #include "EditingStyle.h"
 #include "EditorInsertAction.h"
 #include "FindOptions.h"
+#include "FrameDestructionObserver.h"
 #include "FrameSelection.h"
 #include "TextChecking.h"
 #include "VisibleSelection.h"
@@ -81,7 +82,7 @@
 
 enum EditorCommandSource { CommandFromMenuOrKeyBinding, CommandFromDOM, CommandFromDOMWithUserInterface };
 
-class Editor {
+class Editor : public FrameDestructionObserver {
 public:
     Editor(Frame*);
     ~Editor();
@@ -384,7 +385,8 @@
     void deviceScaleFactorChanged();
 
 private:
-    Frame* m_frame;
+    virtual void willDetachPage() OVERRIDE;
+
     OwnPtr<DeleteButtonController> m_deleteButtonController;
     RefPtr<CompositeEditCommand> m_lastEditCommand;
     RefPtr<Node> m_removedAnchor;

Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/loader/EmptyClients.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebCore/loader/EmptyClients.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/loader/EmptyClients.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -439,6 +439,7 @@
     EmptyEditorClient() { }
     virtual ~EmptyEditorClient() { }
     virtual void pageDestroyed() { }
+    virtual void frameWillDetachPage(Frame*) { }
 
     virtual bool shouldDeleteRange(Range*) { return false; }
     virtual bool shouldShowDeleteInterface(HTMLElement*) { return false; }

Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EditorClient.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EditorClient.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EditorClient.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -65,7 +65,8 @@
 public:
     virtual ~EditorClient() {  }
     virtual void pageDestroyed() = 0;
-    
+    virtual void frameWillDetachPage(Frame*) = 0;
+
     virtual bool shouldDeleteRange(Range*) = 0;
     virtual bool shouldShowDeleteInterface(HTMLElement*) = 0;
     virtual bool smartInsertDeleteEnabled() = 0; 

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/blackberry/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/blackberry/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/blackberry/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebCoreSupport/EditorClientBlackBerry.h:
+        (WebCore::EditorClientBlackBerry::frameWillDetachPage):
+
 2012-03-23  Adam Barth  <[email protected]>
 
         Remove support for "magic" iframe

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -37,6 +37,7 @@
 public:
     EditorClientBlackBerry(BlackBerry::WebKit::WebPagePrivate*);
     virtual void pageDestroyed();
+    virtual void frameWillDetachPage(Frame*) { }
     virtual bool shouldDeleteRange(Range*);
     virtual bool shouldShowDeleteInterface(HTMLElement*);
     virtual bool smartInsertDeleteEnabled();

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,33 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Added WebTextCheckingCompletionImpl::invalidate() to mark
+        pending spellcheck request as invalid, and added frameWillDetachPage()
+        to fire it.
+
+        Reviewed by Ryosuke Niwa.
+
+        * src/EditorClientImpl.cpp:
+        (WebKit::EditorClientImpl::frameWillDetachPage):
+        (WebKit):
+        (WebKit::EditorClientImpl::requestCheckingOfString):
+        (WebKit::EditorClientImpl::didCheckString):
+        * src/EditorClientImpl.h:
+        (WebKit):
+        (EditorClientImpl):
+        * src/WebTextCheckingCompletionImpl.cpp:
+        (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
+        (WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
+        (WebKit::WebTextCheckingCompletionImpl::invalidate):
+        (WebKit):
+        * src/WebTextCheckingCompletionImpl.h:
+        (WebKit):
+        (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
+        (WebTextCheckingCompletionImpl):
+        (WebKit::WebTextCheckingCompletionImpl::spellChecker):
+
 2012-03-23  Adam Barth  <[email protected]>
 
         Remove support for "magic" iframe

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/EditorClientImpl.cpp (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/EditorClientImpl.cpp	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/EditorClientImpl.cpp	2012-07-06 20:04:30 UTC (rev 122012)
@@ -87,6 +87,21 @@
     // Our lifetime is bound to the WebViewImpl.
 }
 
+void EditorClientImpl::frameWillDetachPage(WebCore::Frame* frame)
+{
+    HashSet<WebTextCheckingCompletionImpl*> validRequests;
+
+    for (HashSet<WebTextCheckingCompletionImpl*>::iterator i = m_pendingTextChecks.begin();
+         i != m_pendingTextChecks.end(); ++i) {
+        if (frame->editor()->spellChecker() == (*i)->spellChecker())
+            (*i)->invalidate();
+        else
+            validRequests.add(*i);
+    }
+
+    m_pendingTextChecks.swap(validRequests);
+}
+
 bool EditorClientImpl::shouldShowDeleteInterface(HTMLElement* elem)
 {
     // Normally, we don't care to show WebCore's deletion UI, so we only enable
@@ -733,8 +748,12 @@
 
 void EditorClientImpl::requestCheckingOfString(SpellChecker* sender, int identifier, TextCheckingTypeMask, const String& text)
 {
-    if (m_webView->spellCheckClient())
-        m_webView->spellCheckClient()->requestCheckingOfText(text, new WebTextCheckingCompletionImpl(identifier, sender));
+    if (!m_webView->spellCheckClient())
+        return;
+
+    WebTextCheckingCompletionImpl* completion = new WebTextCheckingCompletionImpl(identifier, sender);
+    m_pendingTextChecks.add(completion);
+    m_webView->spellCheckClient()->requestCheckingOfText(text, completion);
 }
 
 String EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord(const String& misspelledWord)

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/EditorClientImpl.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/EditorClientImpl.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/EditorClientImpl.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -35,6 +35,7 @@
 #include "TextCheckerClient.h"
 #include "Timer.h"
 #include <wtf/Deque.h>
+#include <wtf/HashSet.h>
 
 namespace WebCore {
 class Frame;
@@ -44,6 +45,7 @@
 
 namespace WebKit {
 class WebViewImpl;
+class WebTextCheckingCompletionImpl;
 
 class EditorClientImpl : public WebCore::EditorClient, public WebCore::TextCheckerClient {
 public:
@@ -51,6 +53,7 @@
 
     virtual ~EditorClientImpl();
     virtual void pageDestroyed();
+    virtual void frameWillDetachPage(WebCore::Frame*) OVERRIDE;
 
     virtual bool shouldShowDeleteInterface(WebCore::HTMLElement*);
     virtual bool smartInsertDeleteEnabled();
@@ -113,6 +116,8 @@
 
     virtual WebCore::TextCheckerClient* textChecker() { return this; }
 
+    void didCheckString(WebTextCheckingCompletionImpl*);
+
 private:
     void modifySelection(WebCore::Frame*, WebCore::KeyboardEvent*);
 
@@ -140,6 +145,8 @@
         SpellCheckForcedOff
     };
     int m_spellCheckThisFieldStatus;
+
+    WTF::HashSet<WebTextCheckingCompletionImpl*> m_pendingTextChecks;
 };
 
 } // namespace WebKit

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp	2012-07-06 20:04:30 UTC (rev 122012)
@@ -31,6 +31,7 @@
 #include "config.h"
 #include "WebTextCheckingCompletionImpl.h"
 
+#include "EditorClientImpl.h"
 #include "SpellChecker.h"
 #include "TextCheckerClient.h"
 #include "WebTextCheckingResult.h"
@@ -51,8 +52,18 @@
 
 void WebTextCheckingCompletionImpl::didFinishCheckingText(const WebVector<WebTextCheckingResult>& results)
 {
-    m_spellChecker->didCheck(m_identifier, toCoreResults(results));
+    if (m_spellChecker) {
+        m_spellChecker->didCheck(m_identifier, toCoreResults(results));
+        m_editorClient->didCheckString(this);
+    }
+
     delete this;
 }
 
+void WebTextCheckingCompletionImpl::invalidate()
+{
+    m_spellChecker = 0;
+    m_editorClient = 0;
+}
+
 } // namespace WebKit

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -39,20 +39,28 @@
 
 namespace WebKit {
 
+class EditorClientImpl;
+
 class WebTextCheckingCompletionImpl : public WebTextCheckingCompletion {
 public:
-    WebTextCheckingCompletionImpl(int identifier, WebCore::SpellChecker* spellchecker)
-        : m_identifier(identifier), m_spellChecker(spellchecker)
+    WebTextCheckingCompletionImpl(int identifier, WebCore::SpellChecker* spellchecker, EditorClientImpl* editorClient)
+        : m_identifier(identifier)
+        , m_spellChecker(spellchecker)
+        , m_editorClient(editorClient)
     {
     }
 
     virtual void didFinishCheckingText(const WebVector<WebTextCheckingResult>&);
 
+    void invalidate();
+    WebCore::SpellChecker* spellChecker() const { return m_spellChecker; }
+
 private:
     virtual ~WebTextCheckingCompletionImpl() { }
 
     int m_identifier;
     WebCore::SpellChecker* m_spellChecker;
+    EditorClientImpl* m_editorClient;
 };
 
 } // namespace WebKit

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/efl/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/efl/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/efl/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebCoreSupport/EditorClientEfl.h:
+        (WebCore::EditorClientEfl::frameWillDetachPage):
+
 2012-03-23  Adam Barth  <[email protected]>
 
         Remove support for "magic" iframe

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -56,6 +56,7 @@
 
     // from EditorClient
     virtual void pageDestroyed();
+    virtual void frameWillDetachPage(Frame*) { }
 
     virtual bool shouldDeleteRange(Range*);
     virtual bool shouldShowDeleteInterface(HTMLElement*);

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebCoreSupport/EditorClientGtk.h:
+        (WebKit::EditorClient::frameWillDetachPage):
+
 2012-05-14  Thiago Marcos P. Santos  <[email protected]>
 
         [GTK] Wrong documentation for Web Database

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -76,6 +76,7 @@
 
         // from EditorClient
         virtual void pageDestroyed();
+        virtual void frameWillDetachPage(Frame*) { }
 
         virtual bool shouldDeleteRange(WebCore::Range*);
         virtual bool shouldShowDeleteInterface(WebCore::HTMLElement*);

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/mac/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/mac/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/mac/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,12 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebCoreSupport/WebEditorClient.h:
+
 2012-03-26  Adam Barth  <[email protected]>
 
         FrameLoader::shouldAllowNavigation uses Frame for context rather than Document

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -42,6 +42,7 @@
     WebEditorClient(WebView *);
     virtual ~WebEditorClient();
     virtual void pageDestroyed() OVERRIDE;
+    virtual void frameWillDetachPage(Frame*) OVERRIDE { }
 
     virtual bool isGrammarCheckingEnabled() OVERRIDE;
     virtual void toggleGrammarChecking() OVERRIDE;

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/qt/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/qt/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/qt/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebCoreSupport/EditorClientQt.h:
+        (WebCore::EditorClientQt::frameWillDetachPage):
+
 2012-03-23  Adam Barth  <[email protected]>
 
         Remove support for "magic" iframe

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -44,6 +44,7 @@
     EditorClientQt(QWebPage* page);
     
     virtual void pageDestroyed();
+    virtual void frameWillDetachPage(Frame*) { }
     
     virtual bool shouldDeleteRange(Range*);
     virtual bool shouldShowDeleteInterface(HTMLElement*);

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/win/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/win/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/win/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebCoreSupport/WebEditorClient.h:
+        (WebEditorClient::frameWillDetachPage):
+
 2012-03-26  Adam Barth  <[email protected]>
 
         FrameLoader::shouldAllowNavigation uses Frame for context rather than Document

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/win/WebCoreSupport/WebEditorClient.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/win/WebCoreSupport/WebEditorClient.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/win/WebCoreSupport/WebEditorClient.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -41,6 +41,7 @@
     ~WebEditorClient();
 
     virtual void pageDestroyed();
+    virtual void frameWillDetachPage(Frame*) { }
 
     virtual bool isContinuousSpellCheckingEnabled();
     virtual void toggleGrammarChecking();

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/wince/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/wince/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/wince/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebCoreSupport/EditorClientWinCE.h:
+        (WebKit::EditorClientWinCE::frameWillDetachPage):
+
 2012-03-23  Adam Barth  <[email protected]>
 
         Remove support for "magic" iframe

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -38,6 +38,7 @@
     ~EditorClientWinCE();
 
     virtual void pageDestroyed();
+    virtual void frameWillDetachPage(Frame*) { }
 
     virtual bool shouldDeleteRange(WebCore::Range*);
     virtual bool shouldShowDeleteInterface(WebCore::HTMLElement*);

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/wx/ChangeLog (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/wx/ChangeLog	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/wx/ChangeLog	2012-07-06 20:04:30 UTC (rev 122012)
@@ -1,3 +1,13 @@
+2012-05-18  MORITA Hajime  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=85515
+        Stale frame in WebCore::SpellChecker::didCheckSucceeded
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebKitSupport/EditorClientWx.h:
+        (WebCore::EditorClientWx::frameWillDetachPage):
+
 2012-03-23  Adam Barth  <[email protected]>
 
         Remove support for "magic" iframe

Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/wx/WebKitSupport/EditorClientWx.h (122011 => 122012)


--- releases/WebKitGTK/webkit-1.8/Source/WebKit/wx/WebKitSupport/EditorClientWx.h	2012-07-06 20:04:09 UTC (rev 122011)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/wx/WebKitSupport/EditorClientWx.h	2012-07-06 20:04:30 UTC (rev 122012)
@@ -45,6 +45,7 @@
     virtual ~EditorClientWx();
     void setPage(Page*);
     virtual void pageDestroyed();
+    virtual void frameWillDetachPage(Frame*) { }
 
     virtual bool shouldDeleteRange(Range*);
     virtual bool shouldShowDeleteInterface(HTMLElement*);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to