Title: [121256] trunk/Source/WebCore
- Revision
- 121256
- Author
- [email protected]
- Date
- 2012-06-26 05:32:38 -0700 (Tue, 26 Jun 2012)
Log Message
Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955
Reviewed by Vsevolod Vlasov.
Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121255 => 121256)
--- trunk/Source/WebCore/ChangeLog 2012-06-26 12:17:41 UTC (rev 121255)
+++ trunk/Source/WebCore/ChangeLog 2012-06-26 12:32:38 UTC (rev 121256)
@@ -1,3 +1,22 @@
+2012-06-26 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
+ https://bugs.webkit.org/show_bug.cgi?id=89955
+
+ Reviewed by Vsevolod Vlasov.
+
+ Show object popover for all heap snapshot nodes event for those whose
+ canBeQueried flag is false. We didn't show popover for such objects before
+ as it could lead to the backend crash. In the meantime the backend shouldn't
+ fail on such DOM wrappers and report an error if it cannot resolve
+ inspected object.
+
+ * inspector/front-end/HeapSnapshotGridNodes.js:
+ (WebInspector.HeapSnapshotGenericObjectNode):
+ (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
+ * inspector/front-end/HeapSnapshotView.js:
+ (WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
+
2012-06-26 Christophe Dumez <[email protected]>
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js (121255 => 121256)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js 2012-06-26 12:17:41 UTC (rev 121255)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js 2012-06-26 12:32:38 UTC (rev 121256)
@@ -91,7 +91,7 @@
node.dispose();
},
- hasHoverMessage: false,
+ _reachableFromWindow: false,
queryObjectContent: function(callback)
{
@@ -356,12 +356,12 @@
this.snapshotNodeId = node.id;
this.snapshotNodeIndex = node.nodeIndex;
if (this._type === "string")
- this.hasHoverMessage = true;
+ this._reachableFromWindow = true;
else if (this._type === "object" && this.isWindow(this._name)) {
this._name = this.shortenWindowURL(this._name, false);
- this.hasHoverMessage = true;
+ this._reachableFromWindow = true;
} else if (node.flags & tree.snapshot.nodeFlags.canBeQueried)
- this.hasHoverMessage = true;
+ this._reachableFromWindow = true;
if (node.flags & tree.snapshot.nodeFlags.detachedDOMTreeNode)
this.detachedDOMTreeNode = true;
};
@@ -435,7 +435,7 @@
value += "[]";
break;
};
- if (this.hasHoverMessage)
+ if (this._reachableFromWindow)
valueStyle += " highlight";
if (value === "Object")
value = "";
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js (121255 => 121256)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2012-06-26 12:17:41 UTC (rev 121255)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2012-06-26 12:32:38 UTC (rev 121256)
@@ -562,10 +562,7 @@
var row = target.enclosingNodeOrSelfWithNodeName("tr");
if (!row)
return;
- var gridNode = row._dataGridNode;
- if (!gridNode.hasHoverMessage)
- return;
- span.node = gridNode;
+ span.node = row._dataGridNode;
return span;
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
