Title: [121154] trunk/Source/WebCore
- Revision
- 121154
- Author
- [email protected]
- Date
- 2012-06-25 07:26:48 -0700 (Mon, 25 Jun 2012)
Log Message
Web Inspector: "Emulate Touch Events" breaks selecting elements with "touchstart" event listeners for inspection.
https://bugs.webkit.org/show_bug.cgi?id=89861
Reviewed by Vsevolod Vlasov.
Upon a mousepress, Inspector should be queried for the "Inspect element" mode up-front,
before dispatching a synthetic "touchstart" event.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121153 => 121154)
--- trunk/Source/WebCore/ChangeLog 2012-06-25 13:42:55 UTC (rev 121153)
+++ trunk/Source/WebCore/ChangeLog 2012-06-25 14:26:48 UTC (rev 121154)
@@ -1,5 +1,18 @@
2012-06-25 Alexander Pavlov <[email protected]>
+ Web Inspector: "Emulate Touch Events" breaks selecting elements with "touchstart" event listeners for inspection.
+ https://bugs.webkit.org/show_bug.cgi?id=89861
+
+ Reviewed by Vsevolod Vlasov.
+
+ Upon a mousepress, Inspector should be queried for the "Inspect element" mode up-front,
+ before dispatching a synthetic "touchstart" event.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEvent):
+
+2012-06-25 Alexander Pavlov <[email protected]>
+
Web Inspector: [Styles] Cannot visually set caret before the first CSS property name character
https://bugs.webkit.org/show_bug.cgi?id=89869
Modified: trunk/Source/WebCore/page/EventHandler.cpp (121153 => 121154)
--- trunk/Source/WebCore/page/EventHandler.cpp 2012-06-25 13:42:55 UTC (rev 121153)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2012-06-25 14:26:48 UTC (rev 121154)
@@ -1484,6 +1484,11 @@
{
RefPtr<FrameView> protector(m_frame->view());
+ if (InspectorInstrumentation::handleMousePress(m_frame->page())) {
+ invalidateClick();
+ return true;
+ }
+
#if ENABLE(TOUCH_EVENTS)
bool defaultPrevented = dispatchSyntheticTouchEventIfEnabled(mouseEvent);
if (defaultPrevented)
@@ -1527,11 +1532,6 @@
m_mousePressNode = targetNode(mev);
- if (InspectorInstrumentation::handleMousePress(m_frame->page())) {
- invalidateClick();
- return true;
- }
-
Frame* subframe = subframeForHitTestResult(mev);
if (subframe && passMousePressEventToSubframe(mev, subframe)) {
// Start capturing future events for this frame. We only do this if we didn't clear
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
