Title: [121108] trunk/Source/WebKit/chromium
- Revision
- 121108
- Author
- [email protected]
- Date
- 2012-06-23 22:29:31 -0700 (Sat, 23 Jun 2012)
Log Message
[chromium] Return has value, in function returning void
https://bugs.webkit.org/show_bug.cgi?id=89822
Reviewed by Adam Barth.
A followup for r121091.
* src/WebHistoryItem.cpp:
(WebKit::WebHistoryItem::setPageScaleFactor):
* src/WebImageLayer.cpp:
(WebKit::WebImageLayer::setBitmap):
* src/WebLayer.cpp:
(WebKit::WebLayer::setMaskLayer):
* src/WebOptionElement.cpp:
(WebKit::WebOptionElement::setValue):
(WebKit::WebOptionElement::setDefaultSelected):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (121107 => 121108)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-24 03:47:10 UTC (rev 121107)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-24 05:29:31 UTC (rev 121108)
@@ -1,6 +1,25 @@
2012-06-23 Kwang Yul Seo <[email protected]>
[chromium] Return has value, in function returning void
+ https://bugs.webkit.org/show_bug.cgi?id=89822
+
+ Reviewed by Adam Barth.
+
+ A followup for r121091.
+
+ * src/WebHistoryItem.cpp:
+ (WebKit::WebHistoryItem::setPageScaleFactor):
+ * src/WebImageLayer.cpp:
+ (WebKit::WebImageLayer::setBitmap):
+ * src/WebLayer.cpp:
+ (WebKit::WebLayer::setMaskLayer):
+ * src/WebOptionElement.cpp:
+ (WebKit::WebOptionElement::setValue):
+ (WebKit::WebOptionElement::setDefaultSelected):
+
+2012-06-23 Kwang Yul Seo <[email protected]>
+
+ [chromium] Return has value, in function returning void
https://bugs.webkit.org/show_bug.cgi?id=89805
Reviewed by Adam Barth.
Modified: trunk/Source/WebKit/chromium/src/WebHistoryItem.cpp (121107 => 121108)
--- trunk/Source/WebKit/chromium/src/WebHistoryItem.cpp 2012-06-24 03:47:10 UTC (rev 121107)
+++ trunk/Source/WebKit/chromium/src/WebHistoryItem.cpp 2012-06-24 05:29:31 UTC (rev 121108)
@@ -173,7 +173,7 @@
void WebHistoryItem::setPageScaleFactor(float scale)
{
ensureMutable();
- return m_private->setPageScaleFactor(scale);
+ m_private->setPageScaleFactor(scale);
}
bool WebHistoryItem::isTargetItem() const
Modified: trunk/Source/WebKit/chromium/src/WebImageLayer.cpp (121107 => 121108)
--- trunk/Source/WebKit/chromium/src/WebImageLayer.cpp 2012-06-24 03:47:10 UTC (rev 121107)
+++ trunk/Source/WebKit/chromium/src/WebImageLayer.cpp 2012-06-24 05:29:31 UTC (rev 121108)
@@ -42,7 +42,7 @@
void WebImageLayer::setBitmap(SkBitmap bitmap)
{
- return unwrap<WebCore::ImageLayerChromium>()->setBitmap(bitmap);
+ unwrap<WebCore::ImageLayerChromium>()->setBitmap(bitmap);
}
} // namespace WebKit
Modified: trunk/Source/WebKit/chromium/src/WebLayer.cpp (121107 => 121108)
--- trunk/Source/WebKit/chromium/src/WebLayer.cpp 2012-06-24 03:47:10 UTC (rev 121107)
+++ trunk/Source/WebKit/chromium/src/WebLayer.cpp 2012-06-24 05:29:31 UTC (rev 121108)
@@ -187,7 +187,7 @@
void WebLayer::setMaskLayer(const WebLayer& maskLayer)
{
WebLayer ref = maskLayer;
- return m_private->setMaskLayer(ref.unwrap<LayerChromium>());
+ m_private->setMaskLayer(ref.unwrap<LayerChromium>());
}
WebLayer WebLayer::maskLayer() const
Modified: trunk/Source/WebKit/chromium/src/WebOptionElement.cpp (121107 => 121108)
--- trunk/Source/WebKit/chromium/src/WebOptionElement.cpp 2012-06-24 03:47:10 UTC (rev 121107)
+++ trunk/Source/WebKit/chromium/src/WebOptionElement.cpp 2012-06-24 05:29:31 UTC (rev 121108)
@@ -44,7 +44,7 @@
void WebOptionElement::setValue(const WebString& newValue)
{
- return unwrap<HTMLOptionElement>()->setValue(newValue);
+ unwrap<HTMLOptionElement>()->setValue(newValue);
}
WebString WebOptionElement::value() const
@@ -69,7 +69,7 @@
void WebOptionElement::setDefaultSelected(bool newSelected)
{
- return unwrap<HTMLOptionElement>()->setAttribute(selectedAttr, newSelected ? "" : 0);
+ unwrap<HTMLOptionElement>()->setAttribute(selectedAttr, newSelected ? "" : 0);
}
WebString WebOptionElement::label() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes