Title: [120657] trunk/Tools
- Revision
- 120657
- Author
- simon.fra...@apple.com
- Date
- 2012-06-18 19:06:09 -0700 (Mon, 18 Jun 2012)
Log Message
Provide bug links for suspicious commits
https://bugs.webkit.org/show_bug.cgi?id=89408
Reviewed by Adam Barth.
Add links to bugs for the suspicious commits if we have bug data.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
(ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
(ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js (120656 => 120657)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js 2012-06-19 01:54:35 UTC (rev 120656)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js 2012-06-19 02:06:09 UTC (rev 120657)
@@ -70,6 +70,11 @@
});
});
+bugzilla.bugURL = function(bugNumber)
+{
+ return config.kBugzillaURL + '/show_bug.cgi?id=' + bugNumber;
+};
+
bugzilla.quickSearch = function(query, callback)
{
g_searchCache.get(query, callback);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (120656 => 120657)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2012-06-19 01:54:35 UTC (rev 120656)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2012-06-19 02:06:09 UTC (rev 120657)
@@ -117,12 +117,13 @@
this._addDetail('summary', commitData);
this._addDetail('author', commitData);
this._addDetail('reviewer', commitData);
+ this._addDetail('bugID', commitData, bugzilla.bugURL);
},
hasRevision: function(revision)
{
return this._revision == revision;
},
- _addDetail: function(part, commitData)
+ _addDetail: function(part, commitData, linkFunction)
{
var content = commitData[part];
if (!content)
@@ -130,7 +131,12 @@
var span = this._details.appendChild(document.createElement('span'));
span.className = part;
- span.textContent = content;
+
+ if (linkFunction) {
+ var link = base.createLinkNode(linkFunction(content), content, '_blank');
+ span.appendChild(link);
+ } else
+ span.textContent = content;
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (120656 => 120657)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2012-06-19 01:54:35 UTC (rev 120656)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2012-06-19 02:06:09 UTC (rev 120657)
@@ -146,6 +146,16 @@
color: Gray;
}
+ ol.notifications>li ul.causes>li>div.description>span>span.bugID::before {
+ content: 'bug ';
+ padding-left: 8px;
+ }
+
+ ol.notifications>li ul.causes>li>div.description>span>span.bugID>a {
+ cursor: hand;
+ pointer-events: auto;
+ }
+
ol.notifications>li ul.causes>li>div.description>span>span.reviewer::before {
content: ' (';
}
Modified: trunk/Tools/ChangeLog (120656 => 120657)
--- trunk/Tools/ChangeLog 2012-06-19 01:54:35 UTC (rev 120656)
+++ trunk/Tools/ChangeLog 2012-06-19 02:06:09 UTC (rev 120657)
@@ -1,3 +1,18 @@
+2012-06-18 Simon Fraser <simon.fra...@apple.com>
+
+ Provide bug links for suspicious commits
+ https://bugs.webkit.org/show_bug.cgi?id=89408
+
+ Reviewed by Adam Barth.
+
+ Add links to bugs for the suspicious commits if we have bug data.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
+ (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
+ (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
+
2012-06-18 Amy Ousterhout <aoust...@chromium.org>
[Chromium] DeviceOrientation Cleanup
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
