Title: [119753] trunk/Source/WebCore
- Revision
- 119753
- Author
- shawnsi...@chromium.org
- Date
- 2012-06-07 14:32:13 -0700 (Thu, 07 Jun 2012)
Log Message
[chromium] Remove obsolete FIXME comment about a layer sorting bug.
https://bugs.webkit.org/show_bug.cgi?id=88546
Reviewed by James Robinson.
No tests needed, only comment changed. The comment referred to a
potential bug that actually will not occur. The W3C spec on CSS 3d
transforms indicates that layers that do not share the same "3d
rendering context" do not sort together, and our existing code
sorts this way already.
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (119752 => 119753)
--- trunk/Source/WebCore/ChangeLog 2012-06-07 21:21:31 UTC (rev 119752)
+++ trunk/Source/WebCore/ChangeLog 2012-06-07 21:32:13 UTC (rev 119753)
@@ -1,3 +1,19 @@
+2012-06-07 Shawn Singh <shawnsi...@chromium.org>
+
+ [chromium] Remove obsolete FIXME comment about a layer sorting bug.
+ https://bugs.webkit.org/show_bug.cgi?id=88546
+
+ Reviewed by James Robinson.
+
+ No tests needed, only comment changed. The comment referred to a
+ potential bug that actually will not occur. The W3C spec on CSS 3d
+ transforms indicates that layers that do not share the same "3d
+ rendering context" do not sort together, and our existing code
+ sorts this way already.
+
+ * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+ (WebCore::subtreeShouldRenderToSeparateSurface):
+
2012-06-07 Adam Barth <aba...@webkit.org>
Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp (119752 => 119753)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-07 21:21:31 UTC (rev 119752)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-07 21:32:13 UTC (rev 119753)
@@ -269,11 +269,6 @@
template<typename LayerType>
static bool subtreeShouldRenderToSeparateSurface(LayerType* layer, bool axisAlignedWithRespectToParent)
{
- // FIXME: If we decide to create a render surface here while this layer does
- // preserve-3d, then we may be sorting incorrectly because we will not be
- // sorting the individual layers of this subtree with other layers outside of
- // this subtree.
-
// Cache this value, because otherwise it walks the entire subtree several times.
bool descendantDrawsContent = layer->descendantDrawsContent();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
