Title: [119261] trunk/Source/WebKit2
- Revision
- 119261
- Author
- [email protected]
- Date
- 2012-06-01 12:32:21 -0700 (Fri, 01 Jun 2012)
Log Message
<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call
Followup to r119260
Rubber-stamped by Anders Carlsson.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow): Set the m_hasCalledSetWindow here...
(WebKit::NetscapePlugin::geometryDidChange): ...instead of here.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (119260 => 119261)
--- trunk/Source/WebKit2/ChangeLog 2012-06-01 19:24:37 UTC (rev 119260)
+++ trunk/Source/WebKit2/ChangeLog 2012-06-01 19:32:21 UTC (rev 119261)
@@ -2,7 +2,20 @@
<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call
+
+ Followup to r119260
+ Rubber-stamped by Anders Carlsson.
+
+ * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+ (WebKit::NetscapePlugin::callSetWindow): Set the m_hasCalledSetWindow here...
+ (WebKit::NetscapePlugin::geometryDidChange): ...instead of here.
+
+2012-06-01 Brady Eidson <[email protected]>
+
+ <rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
+ REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call
+
Reviewed by Oliver Hunt.
Add a flag to NetscapePlugin to track whether or not NPP_SetWindow has ever been called.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (119260 => 119261)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2012-06-01 19:24:37 UTC (rev 119260)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2012-06-01 19:32:21 UTC (rev 119261)
@@ -507,6 +507,7 @@
m_npWindow.clipRect.bottom = m_npWindow.clipRect.top + m_clipRect.height();
NPP_SetWindow(&m_npWindow);
+ m_hasCalledSetWindow = true;
}
bool NetscapePlugin::shouldLoadSrcURL()
@@ -712,7 +713,6 @@
return;
callSetWindow();
- m_hasCalledSetWindow = true;
}
void NetscapePlugin::visibilityDidChange()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
