Title: [119041] branches/safari-536-branch
- Revision
- 119041
- Author
- [email protected]
- Date
- 2012-05-30 20:41:07 -0700 (Wed, 30 May 2012)
Log Message
Fix Changelogs after rolling out 115573.
Modified Paths
Diff
Modified: branches/safari-536-branch/LayoutTests/ChangeLog (119040 => 119041)
--- branches/safari-536-branch/LayoutTests/ChangeLog 2012-05-31 03:27:48 UTC (rev 119040)
+++ branches/safari-536-branch/LayoutTests/ChangeLog 2012-05-31 03:41:07 UTC (rev 119041)
@@ -6,18 +6,49 @@
Rollout 115573
- 2012-04-28 Zan Dobersek <[email protected]>
+ 2012-04-26 Emil A Eklund <[email protected]>
+
+ Move Length and CSS length computation to float
+ https://bugs.webkit.org/show_bug.cgi?id=84801
+
+ Reviewed by Eric Seidel.
+
+ Change Length and CSS length computation to floating point. This gets us
+ closer to the goal of supporting subpixel layout and improves precision
+ for SVG which already uses floating point for its layout.
+
+ This change makes computedStyle return fractional values for pixel values
+ if a fraction is specified. It also changes the result of computations
+ where two or more values with fractional precision. Prior to this change
+ the result of Length(2.9) + Length(2.9) would be 4 as each value would be
+ floored. with this change the result is 5 as the addition is done with
+ floating point precision and then the result will be floored. Once we
+ enable subpixel layout the resulting value in this example would be 5.8.
+
+ * fast/dom/length-attribute-mapping-expected.txt:
+ * fast/dom/length-attribute-mapping.html:
+ * platform/mac-snowleopard/fast/forms/001-expected.png:
+ * platform/mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
+ * platform/mac/fast/forms/001-expected.txt:
+ * platform/mac/fast/html/details-position-expected.png:
+ * platform/mac/fast/html/details-position-expected.txt:
+ * platform/mac/fast/replaced/width100percent-checkbox-expected.png:
+ * platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
+ * platform/mac/fast/replaced/width100percent-radio-expected.png:
+ * platform/mac/fast/replaced/width100percent-radio-expected.txt:
+ * platform/mac/mathml/presentation/fractions-expected.png:
+ * platform/mac/mathml/presentation/fractions-expected.txt:
+ * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
+ * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
+ * platform/mac/mathml/presentation/mo-stretch-expected.png:
+ * platform/mac/mathml/presentation/mo-stretch-expected.txt:
+ * platform/mac/mathml/presentation/subsup-expected.png:
+ * platform/mac/mathml/presentation/subsup-expected.txt:
+ * platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
+ * platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
+ * platform/mac/tables/mozilla/bugs/bug1318-expected.png:
+ * platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- [WK2] http/tests/navigation/anchor-frames-gbk.html fails
- https://bugs.webkit.org/show_bug.cgi?id=76896
-
- Reviewed by Darin Adler.
-
- Unskip the now-passing test for Mac and Qt WK2 ports.
-
- * platform/mac-wk2/Skipped:
- * platform/qt-5.0-wk2/Skipped:
-
2012-05-29 Jessie Berlin <[email protected]>
Merge r118078, which skips the test added in r118039, onto the 536 branch.
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119040 => 119041)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:27:48 UTC (rev 119040)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:41:07 UTC (rev 119041)
@@ -133,22 +133,55 @@
Rollout 115573
- 2012-04-28 Alexander Pavlov <[email protected]>
-
- Web Inspector: Enable touch events feature fails touch feature detection
- https://bugs.webkit.org/show_bug.cgi?id=84397
-
- Whenever the touch emulation is enabled, Inspector adds a script to evaluate on load,
- that adds ontouch(start|end|move|cancel) properties to window.__proto__ and document.__proto__.
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/DOMAgent.js:
- (WebInspector.DOMAgent.prototype._emulateTouchEventsChanged.get if):
- (WebInspector.DOMAgent.prototype._emulateTouchEventsChanged.scriptAddedCallback):
- (WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):
- * inspector/front-end/inspector.js:
-
+ 2012-04-26 Emil A Eklund <[email protected]> and Levi Weintraub <[email protected]>
+
+ Move Length and CSS length computation to float
+ https://bugs.webkit.org/show_bug.cgi?id=84801
+
+ Reviewed by Eric Seidel.
+
+ Change Length and CSS length computation to floating point. This gets us
+ closer to the goal of supporting subpixel layout and improves precision
+ for SVG which already uses floating point for its layout.
+
+ This change makes computedStyle return fractional values for pixel values
+ if a fraction is specified. It also changes the result of computations
+ where two or more values with fractional precision. Prior to this change
+ the result of Length(2.9) + Length(2.9) would be 4 as each value would be
+ floored. With this change the result is 5 as the addition is done with
+ floating point precision and then the result will be floored. Once we
+ enable subpixel layout the resulting value in this example would be 5.8.
+
+ Updated existing layout tests.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::zoomAdjustedPixelValue):
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::computeLength):
+ * css/CSSPrimitiveValue.h:
+ (WebCore):
+ (WebCore::roundForImpreciseConversion):
+ Add specialized float version of roundForImpreciseConversion that matches
+ the int versions rounding logic.
+
+ If a value is sufficiently close to the next integer round it up to
+ ensure that a style rule such as "width: 4.999px" evaluates to 5px
+ instead of 4px. This is needed as, although Lengths are using floating
+ point, the layout system still uses integer precision and floors the
+ Length values.
+ This will change once we move to FractionalLayoutUnits but for now this
+ is needed to ensure compatibility with the existing system and tests.
+
+ Without this specialized rounding logic we fail a handful of tests
+ including acid3.
+
+ * platform/Length.h:
+ (WebCore::Length::value):
+ (Length):
+ (WebCore::Length::intValue):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::styleOrColLogicalWidth):
+
2012-05-28 Lucas Forschler <[email protected]>
Merge 118399
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
