Diff
Modified: trunk/Source/WebCore/ChangeLog (118274 => 118275)
--- trunk/Source/WebCore/ChangeLog 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/ChangeLog 2012-05-24 00:13:07 UTC (rev 118275)
@@ -1,5 +1,39 @@
2012-05-23 Kentaro Hara <[email protected]>
+ Unreviewed, rolling out r118120.
+ http://trac.webkit.org/changeset/118120
+ https://bugs.webkit.org/show_bug.cgi?id=87193
+
+ some LayoutTests crash since the patch passes a NULL to
+ Null(isolate)
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventConstructor.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventTarget.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestException.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestInterface.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNamedConstructor.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNode.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestObj.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+ (WebCore::toV8):
+
+2012-05-23 Kentaro Hara <[email protected]>
+
Unreviewed, rolling out r118129.
http://trac.webkit.org/changeset/118129
https://bugs.webkit.org/show_bug.cgi?id=87202
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-24 00:13:07 UTC (rev 118275)
@@ -455,7 +455,7 @@
inline v8::Handle<v8::Value> toV8(${nativeType}* impl, v8::Isolate* isolate = 0${forceNewObjectParameter})
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return ${className}::wrap(impl, isolate${forceNewObjectCall});
}
END
@@ -472,7 +472,7 @@
inline v8::Handle<v8::Value> toV8(Node* impl, v8::Isolate* isolate = 0, bool forceNewObject = false)
{
if (UNLIKELY(!impl))
- return v8::Null(isolate);
+ return v8::Null();
if (UNLIKELY(forceNewObject))
return toV8Slow(impl, isolate, forceNewObject);
v8::Handle<v8::Value> wrapper = V8DOMWrapper::getCachedWrapper(impl);
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -61,7 +61,7 @@
inline v8::Handle<v8::Value> toV8(TestActiveDOMObject* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestActiveDOMObject::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestActiveDOMObject > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -60,7 +60,7 @@
inline v8::Handle<v8::Value> toV8(TestCustomNamedGetter* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestCustomNamedGetter::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestCustomNamedGetter > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -61,7 +61,7 @@
inline v8::Handle<v8::Value> toV8(TestEventConstructor* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestEventConstructor::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventConstructor > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -62,7 +62,7 @@
inline v8::Handle<v8::Value> toV8(TestEventTarget* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestEventTarget::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventTarget > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -59,7 +59,7 @@
inline v8::Handle<v8::Value> toV8(TestException* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestException::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestException > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -64,7 +64,7 @@
inline v8::Handle<v8::Value> toV8(TestInterface* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestInterface::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestInterface > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -59,7 +59,7 @@
inline v8::Handle<v8::Value> toV8(TestMediaQueryListListener* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestMediaQueryListListener::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestMediaQueryListListener > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -66,7 +66,7 @@
inline v8::Handle<v8::Value> toV8(TestNamedConstructor* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestNamedConstructor::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNamedConstructor > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -60,7 +60,7 @@
inline v8::Handle<v8::Value> toV8(TestNode* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestNode::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNode > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -66,7 +66,7 @@
inline v8::Handle<v8::Value> toV8(TestObj* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestObj::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestObj > impl, v8::Isolate* isolate = 0)
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h (118274 => 118275)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h 2012-05-24 00:12:16 UTC (rev 118274)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h 2012-05-24 00:13:07 UTC (rev 118275)
@@ -62,7 +62,7 @@
inline v8::Handle<v8::Value> toV8(TestSerializedScriptValueInterface* impl, v8::Isolate* isolate = 0)
{
if (!impl)
- return v8::Null(isolate);
+ return v8::Null();
return V8TestSerializedScriptValueInterface::wrap(impl, isolate);
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestSerializedScriptValueInterface > impl, v8::Isolate* isolate = 0)
