Title: [118109] trunk/Source/WebKit/blackberry
Revision
118109
Author
[email protected]
Date
2012-05-22 20:23:01 -0700 (Tue, 22 May 2012)

Log Message

[Blackberry]Pages contain video or audio tags should be in pageCache
https://bugs.webkit.org/show_bug.cgi?id=87116

Patch by Chris Guan <[email protected]> on 2012-05-22
Reviewed by George Staikos.

There is not any reason to disable pageCache for video/audio
tags probably. By my testing, Back and Forward are working for
those pages contain video and audio tags.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::canCachePage):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (118108 => 118109)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-05-23 03:19:38 UTC (rev 118108)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-05-23 03:23:01 UTC (rev 118109)
@@ -1,3 +1,17 @@
+2012-05-22  Chris Guan  <[email protected]>
+
+        [Blackberry]Pages contain video or audio tags should be in pageCache
+        https://bugs.webkit.org/show_bug.cgi?id=87116
+
+        Reviewed by George Staikos.
+        
+        There is not any reason to disable pageCache for video/audio 
+        tags probably. By my testing, Back and Forward are working for 
+        those pages contain video and audio tags.
+
+        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+        (WebCore::FrameLoaderClientBlackBerry::canCachePage):
+
 2012-05-22  Konrad Piascik  <[email protected]>
 
         [BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry

Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (118108 => 118109)


--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2012-05-23 03:19:38 UTC (rev 118108)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2012-05-23 03:23:01 UTC (rev 118109)
@@ -1170,15 +1170,7 @@
 
 bool FrameLoaderClientBlackBerry::canCachePage() const
 {
-    // We won't cache pages containing video, audio or multipart with "multipart/x-mixed-replace".
-    ASSERT(m_frame->document());
-    RefPtr<NodeList> nodeList = m_frame->document()->getElementsByTagName(HTMLNames::videoTag.localName());
-    if (nodeList.get()->length() > 0)
-        return false;
-    nodeList = m_frame->document()->getElementsByTagName(HTMLNames::audioTag.localName());
-    if (nodeList.get()->length() > 0)
-        return false;
-
+    // We won't cache pages containing multipart with "multipart/x-mixed-replace".
     ASSERT(m_frame->loader()->documentLoader());
     const ResponseVector& responses = m_frame->loader()->documentLoader()->responses();
     size_t count = responses.size();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to