Title: [118091] trunk
Revision
118091
Author
jber...@webkit.org
Date
2012-05-22 18:12:57 -0700 (Tue, 22 May 2012)

Log Message

WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=64313

Reviewed by Jon Honeycutt.

Tools:

Add it.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Make sure to generate the binding.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setDefersLoading):
Call WKBundlePageSetDefersLoading.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

* platform/wk2/Skipped:
Remove a test that uses setDefersLoading from the WK2 Skipped list.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (118090 => 118091)


--- trunk/LayoutTests/ChangeLog	2012-05-23 01:02:16 UTC (rev 118090)
+++ trunk/LayoutTests/ChangeLog	2012-05-23 01:12:57 UTC (rev 118091)
@@ -1,5 +1,15 @@
 2012-05-22  Jessie Berlin  <jber...@apple.com>
 
+        WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
+        https://bugs.webkit.org/show_bug.cgi?id=64313
+
+        Reviewed by Jon Honeycutt.
+
+        * platform/wk2/Skipped:
+        Remove a test that uses setDefersLoading from the WK2 Skipped list.
+
+2012-05-22  Jessie Berlin  <jber...@apple.com>
+
         [Mac WK2] platform/mac-wk2/plugins/mouse-events-scaled.html failing
         https://bugs.webkit.org/show_bug.cgi?id=87182
 

Modified: trunk/LayoutTests/platform/wk2/Skipped (118090 => 118091)


--- trunk/LayoutTests/platform/wk2/Skipped	2012-05-23 01:02:16 UTC (rev 118090)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-05-23 01:12:57 UTC (rev 118091)
@@ -790,10 +790,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=63806
 http/tests/cache/history-only-cached-subresource-loads-max-age-https.html
 
-# WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
-# https://bugs.webkit.org/show_bug.cgi?id=64313
-loader/load-defer-resume-crash.html
-
 # [WK2] New tests introduced in 100895 fail
 # https://bugs.webkit.org/show_bug.cgi?id=73913
 http/tests/security/referrer-policy-https-always.html

Modified: trunk/Tools/ChangeLog (118090 => 118091)


--- trunk/Tools/ChangeLog	2012-05-23 01:02:16 UTC (rev 118090)
+++ trunk/Tools/ChangeLog	2012-05-23 01:12:57 UTC (rev 118091)
@@ -1,3 +1,20 @@
+2012-05-22  Jessie Berlin  <jber...@apple.com>
+
+        WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
+        https://bugs.webkit.org/show_bug.cgi?id=64313
+
+        Reviewed by Jon Honeycutt.
+
+        Add it.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
+        Make sure to generate the binding.
+
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+        (WTR::LayoutTestController::setDefersLoading):
+        Call WKBundlePageSetDefersLoading.
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
+
 2012-05-22  Xianzhu Wang  <wangxian...@chromium.org>
 
         [Chromium-Android] Run DumpRenderTree as an apk (python part)

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl (118090 => 118091)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl	2012-05-23 01:02:16 UTC (rev 118090)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl	2012-05-23 01:12:57 UTC (rev 118091)
@@ -127,6 +127,8 @@
         void setWillSendRequestReturnsNull(in boolean flag);
         
         void setShouldStayOnPageAfterHandlingBeforeUnload(in boolean flag);
+
+        void setDefersLoading(in boolean flag);
         
         // Focus testing.
         void addChromeInputField(in object callback);

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (118090 => 118091)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp	2012-05-23 01:02:16 UTC (rev 118090)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp	2012-05-23 01:12:57 UTC (rev 118091)
@@ -543,6 +543,11 @@
     InjectedBundle::shared().postNewBeforeUnloadReturnValue(!shouldStayOnPage);
 }
 
+void LayoutTestController::setDefersLoading(bool shouldDeferLoading)
+{
+    WKBundlePageSetDefersLoading(InjectedBundle::shared().page()->page(), shouldDeferLoading);
+}
+
 void LayoutTestController::setPageVisibility(JSStringRef state)
 {
     WebCore::PageVisibilityState visibilityState = WebCore::PageVisibilityStateVisible;

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h (118090 => 118091)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h	2012-05-23 01:02:16 UTC (rev 118090)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h	2012-05-23 01:12:57 UTC (rev 118091)
@@ -184,6 +184,8 @@
     void setTextDirection(JSStringRef);
 
     void setShouldStayOnPageAfterHandlingBeforeUnload(bool);
+
+    void setDefersLoading(bool);
     
     bool globalFlag() const { return m_globalFlag; }
     void setGlobalFlag(bool value) { m_globalFlag = value; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to