Title: [118075] trunk/Source/WebCore
- Revision
- 118075
- Author
- [email protected]
- Date
- 2012-05-22 15:58:53 -0700 (Tue, 22 May 2012)
Log Message
[V8] Replace 'throwTypeError(); return Undefined();' with 'return throwTypeError();'
https://bugs.webkit.org/show_bug.cgi?id=87106
Reviewed by Adam Barth.
This patch replaces
throwTypeError();
return v8::Undefined();
with
return throwTypeError();
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedFunctionCallback):
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118074 => 118075)
--- trunk/Source/WebCore/ChangeLog 2012-05-22 22:52:34 UTC (rev 118074)
+++ trunk/Source/WebCore/ChangeLog 2012-05-22 22:58:53 UTC (rev 118075)
@@ -1,3 +1,28 @@
+2012-05-22 Kentaro Hara <[email protected]>
+
+ [V8] Replace 'throwTypeError(); return Undefined();' with 'return throwTypeError();'
+ https://bugs.webkit.org/show_bug.cgi?id=87106
+
+ Reviewed by Adam Barth.
+
+ This patch replaces
+
+ throwTypeError();
+ return v8::Undefined();
+
+ with
+
+ return throwTypeError();
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateOverloadedFunctionCallback):
+ (GenerateParametersCheck):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjV8Internal::overloadedMethodCallback):
+ (WebCore::TestObjV8Internal::overloadedMethod1Callback):
+
2012-05-22 Dan Bernstein <[email protected]>
REGRESSION (r105513): CSS max-width is not applied to SVG element
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (118074 => 118075)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-22 22:52:34 UTC (rev 118074)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-22 22:58:53 UTC (rev 118075)
@@ -1344,8 +1344,7 @@
push(@implContentDecls, " return ${name}$overload->{overloadIndex}Callback(args);\n");
}
push(@implContentDecls, <<END);
- V8Proxy::throwTypeError(0, args.GetIsolate());
- return v8::Handle<v8::Value>();
+ return V8Proxy::throwTypeError(0, args.GetIsolate());
END
push(@implContentDecls, "}\n\n");
push(@implContentDecls, "#endif // ${conditionalString}\n\n") if $conditionalString;
@@ -1652,10 +1651,8 @@
my $argValue = "args[$paramIndex]";
my $argType = GetTypeFromSignature($parameter);
if (IsWrapperType($argType)) {
- $parameterCheckString .= " if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !V8${argType}::HasInstance($argValue)) {\n";
- $parameterCheckString .= " V8Proxy::throwTypeError(0, args.GetIsolate());\n";
- $parameterCheckString .= " return v8::Handle<v8::Value>();\n";
- $parameterCheckString .= " }\n";
+ $parameterCheckString .= " if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !V8${argType}::HasInstance($argValue))\n";
+ $parameterCheckString .= " return V8Proxy::throwTypeError(0, args.GetIsolate());\n";
}
}
$parameterCheckString .= " EXCEPTION_BLOCK($nativeType, $parameterName, " .
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (118074 => 118075)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-05-22 22:52:34 UTC (rev 118074)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-05-22 22:58:53 UTC (rev 118075)
@@ -1813,8 +1813,7 @@
return overloadedMethod6Callback(args);
if ((args.Length() == 1 && (args[0]->IsNull() || args[0]->IsArray())))
return overloadedMethod7Callback(args);
- V8Proxy::throwTypeError(0, args.GetIsolate());
- return v8::Handle<v8::Value>();
+ return V8Proxy::throwTypeError(0, args.GetIsolate());
}
static v8::Handle<v8::Value> classMethodCallback(const v8::Arguments& args)
@@ -1871,8 +1870,7 @@
return overloadedMethod11Callback(args);
if ((args.Length() == 1 && (args[0]->IsNull() || args[0]->IsUndefined() || args[0]->IsString() || args[0]->IsObject())))
return overloadedMethod12Callback(args);
- V8Proxy::throwTypeError(0, args.GetIsolate());
- return v8::Handle<v8::Value>();
+ return V8Proxy::throwTypeError(0, args.GetIsolate());
}
#endif // ENABLE(Condition1)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
