- Revision
- 116802
- Author
- [email protected]
- Date
- 2012-05-11 14:16:19 -0700 (Fri, 11 May 2012)
Log Message
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101
Patch by Terry Anderson <[email protected]> on 2012-05-11
Reviewed by Adam Barth.
Source/WebCore:
Will be using the tests in the touchadjustment/ directory.
* WebCore.gypi:
Include TouchAdjustment.* files.
Source/WebKit/chromium:
* features.gypi:
Enable the touch adjustment code by default.
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.
LayoutTests:
* platform/chromium/test_expectations.txt:
Skipping two layout tests in the touchadjustment/ directory that
fail using DRT but pass when I run through the test cases manually.
Allan Jensen experiences a similar problem with these two tests
on the qt port (see comment 36 in the bug description) and will be
investigating why these tests have unexpected behavior.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (116801 => 116802)
--- trunk/LayoutTests/ChangeLog 2012-05-11 21:12:02 UTC (rev 116801)
+++ trunk/LayoutTests/ChangeLog 2012-05-11 21:16:19 UTC (rev 116802)
@@ -1,3 +1,17 @@
+2012-05-11 Terry Anderson <[email protected]>
+
+ [chromium] Compute the best target node on a GestureTap event
+ https://bugs.webkit.org/show_bug.cgi?id=85101
+
+ Reviewed by Adam Barth.
+
+ * platform/chromium/test_expectations.txt:
+ Skipping two layout tests in the touchadjustment/ directory that
+ fail using DRT but pass when I run through the test cases manually.
+ Allan Jensen experiences a similar problem with these two tests
+ on the qt port (see comment 36 in the bug description) and will be
+ investigating why these tests have unexpected behavior.
+
2012-05-11 Sheriff Bot <[email protected]>
Unreviewed, rolling out r116498.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (116801 => 116802)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-11 21:12:02 UTC (rev 116801)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-11 21:16:19 UTC (rev 116802)
@@ -143,8 +143,9 @@
// Battery Status API is not supported yet in the chromium port.
BUGWK62698 SKIP : batterystatus = PASS FAIL
-// Touch Adjustment is not supported yet in the chromium port.
-BUGWK78801 SKIP : touchadjustment/ = FAIL
+// Unskip after investigation of failure by Allan Sandfeld Jensen
+BUGWK85101 SKIP : touchadjustment/event-triggered-widgets.html = FAIL
+BUGWK85101 SKIP : touchadjustment/touch-inlines.html = FAIL
// Network Information API is not supported yet in the chromium port.
BUGWK73528 SKIP : networkinformation = PASS FAIL
Modified: trunk/Source/WebCore/ChangeLog (116801 => 116802)
--- trunk/Source/WebCore/ChangeLog 2012-05-11 21:12:02 UTC (rev 116801)
+++ trunk/Source/WebCore/ChangeLog 2012-05-11 21:16:19 UTC (rev 116802)
@@ -1,3 +1,15 @@
+2012-05-11 Terry Anderson <[email protected]>
+
+ [chromium] Compute the best target node on a GestureTap event
+ https://bugs.webkit.org/show_bug.cgi?id=85101
+
+ Reviewed by Adam Barth.
+
+ Will be using the tests in the touchadjustment/ directory.
+
+ * WebCore.gypi:
+ Include TouchAdjustment.* files.
+
2012-05-11 Sheriff Bot <[email protected]>
Unreviewed, rolling out r116498.
Modified: trunk/Source/WebCore/WebCore.gypi (116801 => 116802)
--- trunk/Source/WebCore/WebCore.gypi 2012-05-11 21:12:02 UTC (rev 116801)
+++ trunk/Source/WebCore/WebCore.gypi 2012-05-11 21:16:19 UTC (rev 116802)
@@ -3055,6 +3055,8 @@
'page/SpeechInputResultList.h',
'page/SuspendableTimer.cpp',
'page/SuspendableTimer.h',
+ 'page/TouchAdjustment.cpp',
+ 'page/TouchAdjustment.h',
'page/UserContentURLPattern.cpp',
'page/WebKitAnimation.cpp',
'page/WebKitAnimation.h',
Modified: trunk/Source/WebKit/chromium/ChangeLog (116801 => 116802)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-05-11 21:12:02 UTC (rev 116801)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-05-11 21:16:19 UTC (rev 116802)
@@ -1,3 +1,17 @@
+2012-05-11 Terry Anderson <[email protected]>
+
+ [chromium] Compute the best target node on a GestureTap event
+ https://bugs.webkit.org/show_bug.cgi?id=85101
+
+ Reviewed by Adam Barth.
+
+ * features.gypi:
+ Enable the touch adjustment code by default.
+ * src/WebInputEventConversion.cpp:
+ (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
+ In the case of a GestureTap, deltaX represents the horizontal padding of the touch
+ area and deltaY represents the vertical padding of the touch area.
+
2012-05-11 Ian Vollick <[email protected]>
[chromium] Ensure that animations continue to run when transform-style is changed
Modified: trunk/Source/WebKit/chromium/features.gypi (116801 => 116802)
--- trunk/Source/WebKit/chromium/features.gypi 2012-05-11 21:12:02 UTC (rev 116801)
+++ trunk/Source/WebKit/chromium/features.gypi 2012-05-11 21:16:19 UTC (rev 116802)
@@ -97,6 +97,7 @@
'ENABLE_STYLE_SCOPED=1',
'ENABLE_SVG=<(enable_svg)',
'ENABLE_SVG_FONTS=<(enable_svg)',
+ 'ENABLE_TOUCH_ADJUSTMENT=1',
'ENABLE_TOUCH_EVENTS=<(enable_touch_events)',
'ENABLE_TOUCH_ICON_LOADING=<(enable_touch_icon_loading)',
'ENABLE_V8_SCRIPT_DEBUG_SERVER=1',
Modified: trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp (116801 => 116802)
--- trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp 2012-05-11 21:12:02 UTC (rev 116801)
+++ trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp 2012-05-11 21:16:19 UTC (rev 116802)
@@ -148,6 +148,7 @@
break;
case WebInputEvent::GestureTap:
m_type = PlatformEvent::GestureTap;
+ m_area = IntSize(e.deltaX * 2, e.deltaY * 2);
break;
case WebInputEvent::GestureTapDown:
m_type = PlatformEvent::GestureTapDown;
