Title: [116569] trunk/Source/WebCore
- Revision
- 116569
- Author
- [email protected]
- Date
- 2012-05-09 15:53:02 -0700 (Wed, 09 May 2012)
Log Message
Cleanup SVGElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=86004
Reviewed by Eric Seidel.
Remove unneeded includes. We do not need to check attr in SVGElement::attributeChanged,
lower layers assume it is non-null and we do not call attributeChanged in SVG.
* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::isAnimatableAttribute):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (116568 => 116569)
--- trunk/Source/WebCore/ChangeLog 2012-05-09 22:52:18 UTC (rev 116568)
+++ trunk/Source/WebCore/ChangeLog 2012-05-09 22:53:02 UTC (rev 116569)
@@ -1,3 +1,17 @@
+2012-05-09 Rob Buis <[email protected]>
+
+ Cleanup SVGElement.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=86004
+
+ Reviewed by Eric Seidel.
+
+ Remove unneeded includes. We do not need to check attr in SVGElement::attributeChanged,
+ lower layers assume it is non-null and we do not call attributeChanged in SVG.
+
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::attributeChanged):
+ (WebCore::SVGElement::isAnimatableAttribute):
+
2012-05-09 Jochen Eisinger <[email protected]>
When creating a new page during a navigation, prime the initial document with the correct referrer policy
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (116568 => 116569)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2012-05-09 22:52:18 UTC (rev 116568)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2012-05-09 22:53:02 UTC (rev 116569)
@@ -26,19 +26,13 @@
#if ENABLE(SVG)
#include "SVGElement.h"
-#include "Attribute.h"
#include "CSSCursorImageValue.h"
#include "DOMImplementation.h"
#include "Document.h"
#include "Event.h"
-#include "EventListener.h"
-#include "EventNames.h"
-#include "FrameView.h"
#include "HTMLNames.h"
#include "NodeRenderingContext.h"
-#include "RegisteredEventListener.h"
#include "RenderObject.h"
-#include "ShadowRoot.h"
#include "SVGCursorElement.h"
#include "SVGDocumentExtensions.h"
#include "SVGElementInstance.h"
@@ -47,10 +41,7 @@
#include "SVGSVGElement.h"
#include "SVGStyledLocatableElement.h"
#include "SVGTextElement.h"
-#include "SVGURIReference.h"
-#include "SVGUseElement.h"
#include "ScriptEventListener.h"
-#include "StyleResolver.h"
#include "XMLNames.h"
namespace WebCore {
@@ -423,9 +414,6 @@
void SVGElement::attributeChanged(Attribute* attr)
{
ASSERT(attr);
- if (!attr)
- return;
-
StyledElement::attributeChanged(attr);
// When an animated SVG property changes through SVG DOM, svgAttributeChanged() is called, not attributeChanged().
@@ -542,7 +530,7 @@
DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, animatableAttributes, ());
if (animatableAttributes.isEmpty()) {
- animatableAttributes.add(HTMLNames::classAttr);
+ animatableAttributes.add(classAttr);
animatableAttributes.add(XLinkNames::hrefAttr);
animatableAttributes.add(SVGNames::amplitudeAttr);
animatableAttributes.add(SVGNames::azimuthAttr);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
