[webkit-changes] [116560] trunk/LayoutTests

Wed, 09 May 2012 15:00:20 -0700

Title: [116560] trunk/LayoutTests
Revision
116560
Author
[email protected]
Date
2012-05-09 15:01:09 -0700 (Wed, 09 May 2012)

Log Message

Update compositing/RTL tests to fail if the root layer is shifted incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85820

Reviewed by James Robinson.

For the Chromium port, if the root layer was shifted incorrectly, the
non-composited red indicator layers would get drawn outside the root
layers bounds, making it impossible to see if the test was failing.

Also turn off overflow:hidden because compositing/ tests have mock
scrollbars. This makes it much easier to debug these tests locally.

* compositing/rtl/rtl-absolute-expected.png:
* compositing/rtl/rtl-absolute-overflow-expected.png:
* compositing/rtl/rtl-absolute-overflow-expected.txt:
* compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
* compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-absolute-overflow-scrolled.html:
* compositing/rtl/rtl-absolute-overflow.html:
* compositing/rtl/rtl-absolute.html:
* compositing/rtl/rtl-fixed-expected.png:
* compositing/rtl/rtl-fixed-overflow-expected.png:
* compositing/rtl/rtl-fixed-overflow-expected.txt:
* compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
* compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-fixed-overflow-scrolled.html:
* compositing/rtl/rtl-fixed-overflow.html:
* compositing/rtl/rtl-fixed.html:
* compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
* compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
* compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
* compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
* compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (116559 => 116560)


--- trunk/LayoutTests/ChangeLog	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/ChangeLog	2012-05-09 22:01:09 UTC (rev 116560)
@@ -1,3 +1,42 @@
+2012-05-09  Adrienne Walker  <[email protected]>
+
+        Update compositing/RTL tests to fail if the root layer is shifted incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=85820
+
+        Reviewed by James Robinson.
+
+        For the Chromium port, if the root layer was shifted incorrectly, the
+        non-composited red indicator layers would get drawn outside the root
+        layers bounds, making it impossible to see if the test was failing.
+
+        Also turn off overflow:hidden because compositing/ tests have mock
+        scrollbars. This makes it much easier to debug these tests locally.
+
+        * compositing/rtl/rtl-absolute-expected.png:
+        * compositing/rtl/rtl-absolute-overflow-expected.png:
+        * compositing/rtl/rtl-absolute-overflow-expected.txt:
+        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
+        * compositing/rtl/rtl-absolute-overflow-scrolled.html:
+        * compositing/rtl/rtl-absolute-overflow.html:
+        * compositing/rtl/rtl-absolute.html:
+        * compositing/rtl/rtl-fixed-expected.png:
+        * compositing/rtl/rtl-fixed-overflow-expected.png:
+        * compositing/rtl/rtl-fixed-overflow-expected.txt:
+        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
+        * compositing/rtl/rtl-fixed-overflow-scrolled.html:
+        * compositing/rtl/rtl-fixed-overflow.html:
+        * compositing/rtl/rtl-fixed.html:
+        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
+        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
+        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
+        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
+        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
+        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
+
 2012-05-09  Zan Dobersek  <[email protected]>
 
         [Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -1,12 +1,12 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer
-          (position 258.00 50.00)
+          (position 265.00 50.00)
           (bounds 100.00 100.00)
           (drawsContent 1)
         )

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -1,9 +1,9 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer
           (position 51.00 50.00)

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled.html (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled.html	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled.html	2012-05-09 22:01:09 UTC (rev 116560)
@@ -3,7 +3,8 @@
 <style>
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
     .positioned {
@@ -26,6 +27,7 @@
     #root {
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 
     #layertree {

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow.html (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow.html	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow.html	2012-05-09 22:01:09 UTC (rev 116560)
@@ -3,7 +3,8 @@
 <style>
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
     .positioned {
@@ -26,6 +27,7 @@
     #root {
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 
     #layertree {

Modified: trunk/LayoutTests/compositing/rtl/rtl-absolute.html (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-absolute.html	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-absolute.html	2012-05-09 22:01:09 UTC (rev 116560)
@@ -3,7 +3,8 @@
 <style>
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
     .positioned {
@@ -23,6 +24,13 @@
         background-color: green;
     }
 
+    #root {
+        width: 100%;
+        height: 100%;
+        /* root element should exactly cover red background */
+        background-color: white;
+    }
+
     #layertree {
         position: absolute;
         top: 10000px;
@@ -40,6 +48,7 @@
     window.addEventListener('load', doTest, false);
 </script>
 <body>
+    <div id="root"></div>
     <div class="positioned indicator"></div>
     <div class="positioned layer"></div>

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -1,12 +1,12 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer
-          (position 258.00 50.00)
+          (position 265.00 50.00)
           (bounds 100.00 100.00)
           (drawsContent 1)
         )

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -1,9 +1,9 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer
           (position 51.00 50.00)

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled.html (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled.html	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled.html	2012-05-09 22:01:09 UTC (rev 116560)
@@ -3,7 +3,8 @@
 <style>
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
     .positioned {
@@ -26,6 +27,7 @@
     #root {
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 
     #layertree {

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow.html (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow.html	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow.html	2012-05-09 22:01:09 UTC (rev 116560)
@@ -3,7 +3,8 @@
 <style>
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
     .positioned {
@@ -26,6 +27,7 @@
     #root {
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 
     #layertree {

Modified: trunk/LayoutTests/compositing/rtl/rtl-fixed.html (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-fixed.html	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-fixed.html	2012-05-09 22:01:09 UTC (rev 116560)
@@ -3,7 +3,8 @@
 <style>
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
     .positioned {
@@ -23,6 +24,12 @@
         background-color: green;
     }
 
+    #root {
+        width: 100%;
+        height: 100%;
+        background-color: white;
+    }
+
     #layertree {
         position: absolute;
         top: 10000px;
@@ -40,6 +47,7 @@
     window.addEventListener('load', doTest, false);
 </script>
 <body>
+    <div id="root"></div>
     <div class="positioned indicator"></div>
     <div class="positioned layer"></div>

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -9,22 +9,22 @@
           (drawsContent 1)
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 658.00 50.00)
+                                  (position 665.00 50.00)
                                   (bounds 100.00 100.00)
                                   (drawsContent 1)
                                 )
@@ -36,6 +36,21 @@
                     )
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )
           )

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -9,18 +9,18 @@
           (drawsContent 1)
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
@@ -36,6 +36,21 @@
                     )
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )
           )

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -9,22 +9,22 @@
           (drawsContent 1)
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 658.00 50.00)
+                                  (position 665.00 50.00)
                                   (bounds 100.00 100.00)
                                   (drawsContent 1)
                                 )
@@ -36,6 +36,21 @@
                     )
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )
           )

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt (116559 => 116560)


--- trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt	2012-05-09 21:56:11 UTC (rev 116559)
+++ trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt	2012-05-09 22:01:09 UTC (rev 116560)
@@ -9,22 +9,22 @@
           (drawsContent 1)
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 658.00 50.00)
+                                  (position 665.00 50.00)
                                   (bounds 100.00 100.00)
                                   (drawsContent 1)
                                 )
@@ -36,6 +36,21 @@
                     )
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )
           )

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to