Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8ba7526ea5065960c297216829e42de6fb6de67e
https://github.com/WebKit/WebKit/commit/8ba7526ea5065960c297216829e42de6fb6de67e
Author: Devin Rousso <[email protected]>
Date: 2026-10-13 (Tue, 13 Oct 2026)
Changed paths:
M Tools/Scripts/webkitpy/style/checker.py
A Tools/Scripts/webkitpy/style/checkers/eslint.py
A Tools/Scripts/webkitpy/style/checkers/eslint_unittest.py
Log Message:
-----------
Web Inspector: run ESLint as part of `check-webkit-style`
https://bugs.webkit.org/show_bug.cgi?id=321762
Reviewed by Timothy Hatcher.
Engineers who already have ESLint installed should not have to remember to run
it manually before uploading changes.
* Tools/Scripts/webkitpy/style/checker.py:
(_all_categories):
(StyleProcessor.do_association_check):
Register the `js/eslint` category and invoke `ESLintChecker` after processing
modified files.
* Tools/Scripts/webkitpy/style/checkers/eslint.py: Added.
(ESLintChecker.check):
Only consider modified JavaScript under `Source/WebInspectorUI` and batch it
into a single `eslint` invocation from that directory.
Use the JSON formatter to report errors through `DefaultStyleErrorHandler`.
Only report errors on modified lines so existing errors elsewhere do not block
uploads.
Run all maintained JavaScript when `eslint.config.mjs` changes as it can affect
every file.
* Tools/Scripts/webkitpy/style/checkers/eslint_unittest.py: Added.
Canonical link: https://commits.webkit.org/323634@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
