Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a0fb2ab7c3d6a36d179ce2ff4f4dfdb966d5c719
https://github.com/WebKit/WebKit/commit/a0fb2ab7c3d6a36d179ce2ff4f4dfdb966d5c719
Author: Devin Rousso <[email protected]>
Date: 2026-10-13 (Tue, 13 Oct 2026)
Changed paths:
M
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
Log Message:
-----------
REGRESSION: console.group and console.groupCollapsed don't always encapsulate
grouped messages
https://bugs.webkit.org/show_bug.cgi?id=284881
<rdar://problem/142028751>
Reviewed by Timothy Hatcher.
`WI.ConsoleMessage` render in `requestAnimationFrame` batches of up to 100,
each saving the open `WI.ConsoleGroup` before rendering and restoring it
afterwards.
`WI.ConsoleGroup` that contain more than 100 or had `WI.ConsoleMessage` added
asynchronously after opening were not associated.
As such, the remaining `WI.ConsoleMessage` were instead appended to the
`WI.ConsoleSession`.
Add a dedicated `_currentSession` to track that independently of the
`WI.ConsoleGroup` so that we can drop the save/restore.
*
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
(WI.JavaScriptLogViewController):
(WI.JavaScriptLogViewController.prototype.startNewSession):
(WI.JavaScriptLogViewController.prototype._addToPendingMessages):
(WI.JavaScriptLogViewController.prototype.renderPendingMessages):
(WI.JavaScriptLogViewController.prototype._sessionForSessionOrGroup): Added.
(WI.JavaScriptLogViewController.prototype._handleShowConsoleMessageTimestampsSettingChanged):
Canonical link: https://commits.webkit.org/323613@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
