Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 35f34f3e26c5a9df274ecf039cf0f6b02e99568a
https://github.com/WebKit/WebKit/commit/35f34f3e26c5a9df274ecf039cf0f6b02e99568a
Author: Zak Ridouh <[email protected]>
Date: 2026-10-13 (Tue, 13 Oct 2026)
Changed paths:
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] The Writing Tools proofreading details popover is displaced
in cross-site iframes
https://bugs.webkit.org/show_bug.cgi?id=325634
rdar://188683262
Reviewed by Tim Nguyen.
The proofreading details popover was placed with contentsToRootView(), which
stops at the frame's local
root. Under site isolation, a frame nested in a cross-site iframe is its own
local root, so the popover was
offset by the iframe's position. The UI process expects main frame view
coordinates, so use
contentsToMainFrameView() instead.
Tests: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::proofreadingSessionDidUpdateStateForSuggestion):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(-[SiteIsolationProofreadingDetailsObserver
proofreadingSessionWithUUID:updateState:forSuggestionWithUUID:]):
(-[SiteIsolationProofreadingDetailsObserver
proofreadingSessionWithUUID:showDetailsForSuggestionWithUUID:relativeToRect:inView:]):
(-[SiteIsolationProofreadingDetailsObserver
textSystemWillBeginEditingDuringSessionWithUUID:]):
(-[SiteIsolationProofreadingDetailsObserver detailsRect]):
(TestWebKitAPI::checkProofreadingDetailsPopoverInFrameNestedInCrossOriginIframe):
(TestWebKitAPI::TEST(SiteIsolation,
ProofreadingDetailsPopoverInFrameNestedInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
ProofreadingDetailsPopoverInFrameNestedInCrossOriginIframeWithScrolledMainFrame)):
(TestWebKitAPI::TEST(SiteIsolation,
ProofreadingDetailsPopoverInFrameNestedInScrolledCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
ProofreadingDetailsPopoverInFrameNestedInScrolledCrossOriginIframeWithScrolledMainFrame)):
Canonical link: https://commits.webkit.org/323546@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
