Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ff9e538b9535f4a9a0a2e2187b36a4095ec1ab10
https://github.com/WebKit/WebKit/commit/ff9e538b9535f4a9a0a2e2187b36a4095ec1ab10
Author: Ryosuke Niwa <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
M
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm
M
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.mm
M
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.mm
M
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm
M Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm
M Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm
M Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm
M Source/WebCore/accessibility/cocoa/WebAccessibilityObjectWrapperBase.mm
M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
M Source/WebCore/bridge/objc/WebScriptObject.mm
M Source/WebCore/bridge/objc/objc_class.mm
M Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapCocoa.mm
M Source/WebCore/editing/cocoa/AttributedString.mm
M Source/WebCore/editing/cocoa/DataDetection.mm
M Source/WebCore/editing/cocoa/DictionaryLookup.mm
M Source/WebCore/editing/cocoa/NodeHTMLConverter.mm
M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
M Source/WebCore/fileapi/FileCocoa.mm
M Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm
M Source/WebCore/page/mac/EventHandlerMac.mm
M Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm
M Source/WebCore/platform/audio/cocoa/AudioEncoderCocoa.cpp
M Source/WebCore/platform/audio/cocoa/AudioSampleBufferConverter.mm
M Source/WebCore/platform/audio/cocoa/PlatformRawAudioDataCocoa.cpp
M Source/WebCore/platform/cocoa/CoreLocationGeolocationProvider.mm
M Source/WebCore/platform/cocoa/MIMETypeRegistryCocoa.mm
M Source/WebCore/platform/cocoa/MediaUtilities.cpp
M Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm
M Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm
M Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm
M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm
M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm
M Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm
M Source/WebCore/platform/gamepad/mac/HIDGamepadElement.cpp
M
Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp
M Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h
M Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm
M
Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm
M Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm
M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
M Source/WebCore/platform/graphics/ca/cocoa/WebVideoContainerLayer.mm
M Source/WebCore/platform/graphics/cg/ColorCG.cpp
M Source/WebCore/platform/graphics/cocoa/CMUtilities.mm
M Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm
M Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm
M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp
M Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm
M Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm
M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm
M Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm
M Source/WebCore/platform/ios/WebAVPlayerController.mm
M Source/WebCore/platform/mac/PasteboardMac.mm
M Source/WebCore/platform/mac/PlatformPasteboardMac.mm
M Source/WebCore/platform/mac/PlatformScreenMac.mm
M Source/WebCore/platform/mac/ScrollbarThemeMac.mm
M Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm
M Source/WebCore/platform/mediastream/cocoa/AVCaptureDeviceManager.mm
M Source/WebCore/platform/mediastream/cocoa/AVVideoCaptureSource.mm
M Source/WebCore/platform/mediastream/cocoa/CoreAudioCaptureDevice.cpp
M Source/WebCore/platform/mediastream/cocoa/MockAudioCaptureUnit.mm
M Source/WebCore/platform/mediastream/cocoa/ScreenCaptureKitCaptureSource.mm
M Source/WebCore/platform/network/cocoa/CookieStorageSessionCocoa.mm
M Source/WebCore/platform/network/cocoa/ResourceErrorCocoa.mm
M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm
M Source/WebCore/platform/network/cocoa/UTIUtilities.mm
M Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm
Log Message:
-----------
Fix unretained local variable warning in Source/WebCore after 2026-10-06
rollout
https://bugs.webkit.org/show_bug.cgi?id=327232
Reviewed by Chris Dumez.
Fix safer C++ static analyzer warnings for UnretainedLocalVarsChecker in
Source/WebCore.
Many changes are due to rdar://189710680 which is actively being fixed in clang.
No new tests since there should be no behavior changes.
*
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm:
(WebCore::ShapeDetection::BarcodeDetectorImpl::getSupportedFormats):
(WebCore::ShapeDetection::BarcodeDetectorImpl::detect):
*
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.mm:
(WebCore::ShapeDetection::FaceDetectorImpl::detect):
*
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.mm:
(WebCore::ShapeDetection::TextDetectorImpl::detect):
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm:
(WebCore::ShapeDetection::configureRequestToUseCPUOrGPU):
* Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm:
(WebCore::makeVectorElement):
* Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm:
(-[WebSpeechRecognizerTaskImpl callbackWithTranscriptions:isFinal:]):
* Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm:
(WebCore::AccessibilityObject::attributedStringForRange const):
* Source/WebCore/accessibility/cocoa/WebAccessibilityObjectWrapperBase.mm:
(makeNSArray):
(-[WebAccessibilityObjectWrapperBase lineRectsAndText]):
(dictionaryRemovingNonSupportedTypes):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* Source/WebCore/bridge/objc/WebScriptObject.mm:
(getListFromNSArray):
(-[WebScriptObject valueForKey:]):
* Source/WebCore/bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::fieldNamed const):
* Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapCocoa.mm:
(WebCore::createAndStoreMasterKey):
(WebCore::findMasterKey):
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::extractArray):
(WebCore::extractParagraphStyle):
* Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::detectRanges):
* Source/WebCore/editing/cocoa/DictionaryLookup.mm:
(-[WebRevealHighlight revealContext:drawRectsForItem:]):
* Source/WebCore/editing/cocoa/NodeHTMLConverter.mm:
(_fontForNameAndSize):
(HTMLConverter::_processMetaElementWithName):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_addMarkersToList):
(HTMLConverter::_exitElement):
* Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::createFragmentInternal):
* Source/WebCore/fileapi/FileCocoa.mm:
(WebCore::File::shouldReplaceFile):
* Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm:
(-[WebTextIndicatorLayer present]):
(-[WebTextIndicatorLayer setAnimationProgress:]):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::findViewInSubviews):
* Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::exposedUnfilledArea const):
* Source/WebCore/platform/audio/cocoa/AudioEncoderCocoa.cpp:
(WebCore::InternalAudioEncoderCocoa::processEncodedOutputs):
* Source/WebCore/platform/audio/cocoa/AudioSampleBufferConverter.mm:
(WebCore::AudioSampleBufferConverter::initialize):
(WebCore::AudioSampleBufferConverter::sampleBuffer):
* Source/WebCore/platform/audio/cocoa/PlatformRawAudioDataCocoa.cpp:
(WebCore::createSampleBuffer):
* Source/WebCore/platform/cocoa/CoreLocationGeolocationProvider.mm:
(-[WebCLLocationManager locationManager:didUpdateLocations:]):
* Source/WebCore/platform/cocoa/MIMETypeRegistryCocoa.mm:
(WebCore::extensionsForMIMETypeMap):
* Source/WebCore/platform/cocoa/MediaUtilities.cpp:
(WebCore::createVideoSampleBuffer):
* Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm:
(WebCore::PlatformSpeechSynthesizer::appendVoices):
* Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:
(WebCore::typeCheckedRecentSearchesRemovingRecentSearchesAddedAfterDate):
(WebCore::loadRecentSearchesFromFile):
* Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm:
(WebCore::SerializedPlatformDataCueValue::SerializedPlatformDataCueValue):
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:
(WebCore::GameControllerGamepad::teardownElements):
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
(WebCore::GameControllerGamepadProvider::startMonitoringGamepads):
* Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm:
(WebCore::GameControllerHapticEffect::create):
(WebCore::GameControllerHapticEffect::start):
(WebCore::GameControllerHapticEffect::stop):
* Source/WebCore/platform/gamepad/mac/HIDGamepadElement.cpp:
(WebCore::HIDGamepadElement::refreshCurrentValue):
* Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processVTTSample):
(WebCore::InbandTextTrackPrivateAVF::readVTTSampleBuffer):
* Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
* Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm:
(WebCore::MediaPlaybackTargetCocoa::deviceName const):
(WebCore::MediaPlaybackTargetCocoa::hasActiveRoute const):
(WebCore::MediaPlaybackTargetCocoa::supportsRemoteVideoPlayback const):
* Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionOptionAVFObjC::assetTrack const):
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
* Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::AVAssetMIMETypeCache::initializeCache):
*
Source/WebCore/platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:
(WebCore::AVRoutePickerViewTargetPicker::hasActiveRoute const):
*
Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:
(WebCore::AVStreamDataParserMIMETypeCache::initializeCache):
*
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
*
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
*
Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.mm:
(WebCore::InbandChapterTrackPrivateAVFObjC::processChapters):
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::originsInMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::allTracksArePlayable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::containsDisabledTracks const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processChapterTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::firstEnabledTrack const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataGroupDidArrive):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver
metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::offsetTimestampsBy):
(WebCore::MediaSampleAVFObjC::setTimestamps):
*
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::didParseStreamDataAsAsset):
*
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::newDataStoredInSharedBuffer):
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(-[WebAnimationDelegate animationDidStart:]):
(-[WebAnimationDelegate animationDidStop:finished:]):
* Source/WebCore/platform/graphics/ca/cocoa/WebVideoContainerLayer.mm:
(-[WebVideoContainerLayer setBounds:]):
* Source/WebCore/platform/graphics/cg/ColorCG.cpp:
(WebCore::convertToCGCompatibleComponents):
(WebCore::createCGColor):
(WebCore::platformConvertColorComponents):
* Source/WebCore/platform/graphics/cocoa/CMUtilities.mm:
(WebCore::ensureContiguousBlockBuffer):
(WebCore::channelLayoutDescription):
(WebCore::sampleBufferFromVideoData):
* Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:
(WebCore::collectDescendantLayersAtPoint):
* Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::handleDecompressionOutput):
* Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp:
(WebCore::FontPlatformSerializedAttributes::fromCF):
* Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:
(WebCore::ImageRotationSessionVT::applyRotation):
* Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::convertCMSampleBuffer):
(WebCore::ImageTransferSessionVT::createPixelBuffer):
(WebCore::ImageTransferSessionVT::createCMSampleBuffer):
* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::ControlMac::drawListButton):
* Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm:
(WebCore::InnerSpinButtonMac::draw):
* Source/WebCore/platform/ios/WebAVPlayerController.mm:
(WebCore::webAVPlayerControllerClassSingleton):
(-[WebAVPlayerController skipBackwardThirtySeconds:]):
(-[WebAVPlayerController gotoEndOfSeekableRanges:]):
(-[WebAVPlayerController canSeekToBeginning]):
(-[WebAVPlayerController canSeekToEnd]):
* Source/WebCore/platform/mac/PasteboardMac.mm:
(WebCore::setDragImageImpl):
* Source/WebCore/platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::bufferForType const):
(WebCore::pasteboardMayContainFilePaths):
(WebCore::urlStringsFromPasteboard):
(WebCore::PlatformPasteboard::allStringsForType const):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::informationForItemAtIndex):
* Source/WebCore/platform/mac/PlatformScreenMac.mm:
(WebCore::collectScreenPropertiesExceptForHDRState):
(WebCore::screen):
* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::paintScrollbarUsingLayersForSnapshot):
* Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm:
(WebCore::jsValueWithDictionaryInContext):
* Source/WebCore/platform/mediastream/cocoa/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::updateCachedAVCaptureDevices):
(WebCore::AVCaptureDeviceManager::retrieveCaptureDevices):
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager):
* Source/WebCore/platform/mediastream/cocoa/AVVideoCaptureSource.mm:
(WebCore::maxPhotoSizeForFormat):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::generatePresets):
* Source/WebCore/platform/mediastream/cocoa/CoreAudioCaptureDevice.cpp:
(WebCore::getDeviceInfo):
* Source/WebCore/platform/mediastream/cocoa/MockAudioCaptureUnit.mm:
(WebCore::MockAudioCaptureInternalUnit::reconfigure):
* Source/WebCore/platform/mediastream/cocoa/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::startContentStream):
* Source/WebCore/platform/network/cocoa/CookieStorageSessionCocoa.mm:
(WebCore::cookiesForURLFromStorage):
(WebCore::CookieStorageSession::nsCookiesToCookieVector):
(WebCore::CookieStorageSession::cookiesForSession const):
(WebCore::CookieStorageSession::cookiesForSessionAsVector const):
(WebCore::CookieStorageSession::deleteAllCookies):
* Source/WebCore/platform/network/cocoa/ResourceErrorCocoa.mm:
(WebCore::ResourceError::blockedKnownTracker const):
(WebCore::ResourceError::blockedTrackerHostName const):
* Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
* Source/WebCore/platform/network/cocoa/UTIUtilities.mm:
(WebCore::mimeTypeFromUTITree):
* Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm:
(WebCoreTestSupport::createCFURLResponseFromResponseData):
Canonical link: https://commits.webkit.org/323536@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
