Title: [116073] trunk
Revision
116073
Author
[email protected]
Date
2012-05-03 23:59:45 -0700 (Thu, 03 May 2012)

Log Message

[EFL] DRT should obey layoutTestController's addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=82722

Patch by Christophe Dumez <[email protected]> on 2012-05-03
Reviewed by Maciej Stachowiak.

Tools:

Implement support for layoutTestController's addURLToRedirect()
in EFL's DRT so that it redirects properly when indicated.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now
that EFL's DRT obeys layoutTestController's addURLToRedirect().

* platform/efl/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (116072 => 116073)


--- trunk/LayoutTests/ChangeLog	2012-05-04 06:47:30 UTC (rev 116072)
+++ trunk/LayoutTests/ChangeLog	2012-05-04 06:59:45 UTC (rev 116073)
@@ -1,3 +1,15 @@
+2012-05-03  Christophe Dumez  <[email protected]>
+
+        [EFL] DRT should obey layoutTestController's addURLToRedirect()
+        https://bugs.webkit.org/show_bug.cgi?id=82722
+
+        Reviewed by Maciej Stachowiak.
+
+        Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now
+        that EFL's DRT obeys layoutTestController's addURLToRedirect().
+
+        * platform/efl/Skipped:
+
 2012-05-03  Ilya Sherman  <[email protected]>
 
         [Qt] REGRESSION(r113511): fast/forms/input-autofilled.html fails

Modified: trunk/LayoutTests/platform/efl/Skipped (116072 => 116073)


--- trunk/LayoutTests/platform/efl/Skipped	2012-05-04 06:47:30 UTC (rev 116072)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-04 06:59:45 UTC (rev 116073)
@@ -575,9 +575,6 @@
 # BUG: Captions support needed in the media engine (via GTK+)
 media/media-captions.html
 
-# BUG: DRT does not obey layoutTestController.addURLToRedirect()
-http/tests/loading/cross-origin-XHR-willLoadRequest.html
-
 # BUG: Requires willPerformClientRedirectToURL
 http/tests/loading/onload-vs-immediate-refresh.pl
 

Modified: trunk/Tools/ChangeLog (116072 => 116073)


--- trunk/Tools/ChangeLog	2012-05-04 06:47:30 UTC (rev 116072)
+++ trunk/Tools/ChangeLog	2012-05-04 06:59:45 UTC (rev 116073)
@@ -1,5 +1,18 @@
 2012-05-03  Christophe Dumez  <[email protected]>
 
+        [EFL] DRT should obey layoutTestController's addURLToRedirect()
+        https://bugs.webkit.org/show_bug.cgi?id=82722
+
+        Reviewed by Maciej Stachowiak.
+
+        Implement support for layoutTestController's addURLToRedirect()
+        in EFL's DRT so that it redirects properly when indicated.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::onWillSendRequest):
+
+2012-05-03  Christophe Dumez  <[email protected]>
+
         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
         https://bugs.webkit.org/show_bug.cgi?id=82704
 

Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (116072 => 116073)


--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-05-04 06:47:30 UTC (rev 116072)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-05-04 06:59:45 UTC (rev 116073)
@@ -457,7 +457,12 @@
         && url.host().lower() != "localhost") {
         printf("Blocked access to external URL %s\n", messages->request->url);
         messages->request->url = ""
+        return;
     }
+
+    const std::string& destination = gLayoutTestController->redirectionDestinationForURL(url.string().utf8().data());
+    if (destination.length())
+        messages->request->url = ""
 }
 
 void DumpRenderTreeChrome::onWebViewOnloadEvent(void*, Evas_Object*, void* eventInfo)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to