Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 16838cede316c2647f48fdc48de304400223159d
https://github.com/WebKit/WebKit/commit/16838cede316c2647f48fdc48de304400223159d
Author: Lily Spiniolas <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebKit/Platform/spi/mac/AppKitSPI.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
Log Message:
-----------
[macOS] Scroll pocket separator should be hidden when scrolled to top of page
or when top color extension active
https://bugs.webkit.org/show_bug.cgi?id=327075
rdar://189682190
Reviewed by Wenson Hsieh.
When the web view is scrolled to the top of the page, or if there's a visible
top color extension view, we now hide the separator of the view's
`NSScrollPocket`
by setting its property `allowsSeparator` to `NO`. Otherwise, set it to `YES`.
We update the value accordingly when a top color extension view is hidden or
fades out, and also whenever the user scrolls.
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/Platform/spi/mac/AppKitSPI.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateAllowsSeparatorForScrollPocket]):
(-[WKWebView colorExtensionViewWillDisappear:]):
(-[WKWebView colorExtensionViewDidAppear:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::pageDidScroll):
(WebKit::WebViewImpl::updateAllowsSeparatorForScrollPocket):
(WebKit::WebViewImpl::updateScrollPocket):
Canonical link: https://commits.webkit.org/323520@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
