Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 41cca0f00ddf3ceb3912c42afef5e0d3cf760168
https://github.com/WebKit/WebKit/commit/41cca0f00ddf3ceb3912c42afef5e0d3cf760168
Author: Chris Dumez <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/dom/Attr.cpp
M Source/WebCore/dom/BroadcastChannel.h
M Source/WebCore/dom/CollectionIndexCacheInlines.h
M Source/WebCore/dom/ComposedTreeIterator.h
M Source/WebCore/dom/ContainerNode.cpp
M Source/WebCore/dom/ContentVisibilityDocumentState.cpp
M Source/WebCore/dom/CurrentScriptIncrementer.h
M Source/WebCore/dom/CustomElementReactionQueue.h
M Source/WebCore/dom/DeviceMotionController.cpp
M Source/WebCore/dom/DeviceOrientationController.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/DocumentFullscreen.cpp
M Source/WebCore/dom/DocumentParser.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/ElementInternals.cpp
M Source/WebCore/dom/ElementIteratorInlines.h
M Source/WebCore/dom/EventLoop.cpp
M Source/WebCore/dom/EventPath.cpp
M Source/WebCore/dom/GCReachableRef.h
M Source/WebCore/dom/IdTargetObserver.cpp
M Source/WebCore/dom/IdTargetObserver.h
M Source/WebCore/dom/ImageOverlay.cpp
M Source/WebCore/dom/InlineStyleSheetOwner.cpp
M Source/WebCore/dom/LiveNodeListInlines.h
M Source/WebCore/dom/MessagePort.cpp
M Source/WebCore/dom/MouseRelatedEvent.cpp
M Source/WebCore/dom/MutationObserver.cpp
M Source/WebCore/dom/MutationObserverRegistration.cpp
M Source/WebCore/dom/NamedNodeMap.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
M Source/WebCore/dom/NodeInlines.h
M Source/WebCore/dom/NodeRareData.h
M Source/WebCore/dom/PendingScript.cpp
M Source/WebCore/dom/Position.cpp
M Source/WebCore/dom/ProcessingInstruction.cpp
M Source/WebCore/dom/Range.cpp
M Source/WebCore/dom/ScriptElement.cpp
M Source/WebCore/dom/SecurityContext.cpp
M Source/WebCore/dom/SecurityContext.h
M Source/WebCore/dom/TreeScopeOrderedMap.cpp
M Source/WebCore/dom/TypedElementDescendantIteratorInlines.h
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/html/parser/HTMLDocumentParser.h
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/PageGroup.cpp
M Source/WebCore/page/PageGroup.h
Log Message:
-----------
Address Safer C++ warnings in WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=326893
Reviewed by Ryosuke Niwa.
Fix the Safer C++ static analyzer warnings reported by the bots in WebCore/dom,
using zero-cost
fixes where possible (trusted parameters, explicit casts, NODELETE, ownership
transfer) and
protect() / smart pointer locals otherwise. GC-thread code, which cannot ref,
gets commented
suppressions.
Warnings in destructors that run while the document may be in destruction, the
forward
declaration in ElementInlinesLight.h, and the raw pointer members of Node,
ShadowRoot, TreeScope
and CollectionIndexCache are left for follow-up patches.
This tested as performance neutral on Speedometer on both iOS and macOS,
though only after regenerating PGO profiles.
* Source/WebCore/dom/Attr.cpp:
* Source/WebCore/dom/BroadcastChannel.h:
* Source/WebCore/dom/CollectionIndexCacheInlines.h:
* Source/WebCore/dom/ComposedTreeIterator.h:
* Source/WebCore/dom/ContainerNode.cpp:
* Source/WebCore/dom/ContentVisibilityDocumentState.cpp:
* Source/WebCore/dom/CurrentScriptIncrementer.h:
* Source/WebCore/dom/CustomElementReactionQueue.h:
* Source/WebCore/dom/DeviceMotionController.cpp:
* Source/WebCore/dom/DeviceOrientationController.cpp:
* Source/WebCore/dom/Document.cpp:
* Source/WebCore/dom/DocumentFullscreen.cpp:
* Source/WebCore/dom/Element.cpp:
* Source/WebCore/dom/ElementInternals.cpp:
* Source/WebCore/dom/ElementIteratorInlines.h:
* Source/WebCore/dom/EventLoop.cpp:
* Source/WebCore/dom/EventPath.cpp:
* Source/WebCore/dom/GCReachableRef.h:
* Source/WebCore/dom/IdTargetObserver.cpp:
* Source/WebCore/dom/ImageOverlay.cpp:
* Source/WebCore/dom/InlineStyleSheetOwner.cpp:
* Source/WebCore/dom/LiveNodeListInlines.h:
* Source/WebCore/dom/MouseRelatedEvent.cpp:
* Source/WebCore/dom/MutationObserver.cpp:
* Source/WebCore/dom/MutationObserverRegistration.cpp:
* Source/WebCore/dom/NamedNodeMap.cpp:
* Source/WebCore/dom/Node.cpp:
* Source/WebCore/dom/NodeRareData.h:
* Source/WebCore/dom/PendingScript.cpp:
* Source/WebCore/dom/Position.cpp:
* Source/WebCore/dom/ProcessingInstruction.cpp:
* Source/WebCore/dom/Range.cpp:
* Source/WebCore/dom/ScriptElement.cpp:
* Source/WebCore/dom/TreeScopeOrderedMap.cpp:
* Source/WebCore/dom/TypedElementDescendantIteratorInlines.h:
* Source/WebCore/dom/ViewTransition.cpp:
Canonical link: https://commits.webkit.org/323512@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
