Title: [115946] trunk
Revision
115946
Author
commit-qu...@webkit.org
Date
2012-05-03 01:22:58 -0700 (Thu, 03 May 2012)

Log Message

[EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=85347

Patch by Dongwoo Im <dw...@samsung.com> on 2012-05-03
Reviewed by Nikolas Zimmermann.

Tools:

* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::resetPageVisibility): Reset the page visibility.
(LayoutTestController::setPageVisibility): Set the page visibility.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.

LayoutTests:

* platformrm/efl/Skipped: Remove one test case of the Page Visibility API.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (115945 => 115946)


--- trunk/LayoutTests/ChangeLog	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/LayoutTests/ChangeLog	2012-05-03 08:22:58 UTC (rev 115946)
@@ -1,3 +1,12 @@
+2012-05-03  Dongwoo Im  <dw...@samsung.com>
+
+        [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
+        https://bugs.webkit.org/show_bug.cgi?id=85347
+
+        Reviewed by Nikolas Zimmermann.
+
+        * platformrm/efl/Skipped: Remove one test case of the Page Visibility API.
+
 2012-05-02  Tom Zakrajsek  <t...@codeaurora.org>
 
         Need tests for PerfTestRunner.computeStatistics

Modified: trunk/LayoutTests/platform/efl/Skipped (115945 => 115946)


--- trunk/LayoutTests/platform/efl/Skipped	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-03 08:22:58 UTC (rev 115946)
@@ -2026,7 +2026,6 @@
 fast/events/page-visibility-iframe-move-test.html
 fast/events/page-visibility-iframe-delete-test.html
 fast/events/page-visibility-iframe-propagation-test.html
-fast/events/page-visibility-transition-test.html
 
 # These test -apple- and -khtml- prefixed CSS properties, which we don't support.
 inspector/styles/vendor-prefixes.html

Modified: trunk/Tools/ChangeLog (115945 => 115946)


--- trunk/Tools/ChangeLog	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/ChangeLog	2012-05-03 08:22:58 UTC (rev 115946)
@@ -1,3 +1,31 @@
+2012-05-03  Dongwoo Im  <dw...@samsung.com>
+
+        [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
+        https://bugs.webkit.org/show_bug.cgi?id=85347
+
+        Reviewed by Nikolas Zimmermann.
+
+        * DumpRenderTree/LayoutTestController.h:
+        (LayoutTestController):
+        * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
+        (LayoutTestController::resetPageVisibility): Not implemented.
+        (LayoutTestController::setPageVisibility): Not implemented.
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::resetPageVisibility): Reset the page visibility.
+        (LayoutTestController::setPageVisibility): Set the page visibility.
+        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+        (LayoutTestController::resetPageVisibility): Not implemented.
+        (LayoutTestController::setPageVisibility): Not implemented.
+        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
+        (LayoutTestController::resetPageVisibility): Not implemented.
+        (LayoutTestController::setPageVisibility): Not implemented.
+        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
+        (LayoutTestController::resetPageVisibility): Not implemented.
+        (LayoutTestController::setPageVisibility): Not implemented.
+        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
+        (LayoutTestController::resetPageVisibility): Not implemented.
+        (LayoutTestController::setPageVisibility): Not implemented.
+
 2012-05-02  Sheriff Bot  <webkit.review....@gmail.com>
 
         Unreviewed, rolling out r115918.

Modified: trunk/Tools/DumpRenderTree/LayoutTestController.h (115945 => 115946)


--- trunk/Tools/DumpRenderTree/LayoutTestController.h	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/LayoutTestController.h	2012-05-03 08:22:58 UTC (rev 115946)
@@ -126,10 +126,9 @@
     void setScrollbarPolicy(JSStringRef orientation, JSStringRef policy);
     void setEditingBehavior(const char* editingBehavior);
     void startSpeechInput(JSContextRef inputElement);
+    void setPageVisibility(const char*);
+    void resetPageVisibility();
 
-    void setPageVisibility(const char* visibility) { }
-    void resetPageVisibility() { }
-
     void waitForPolicyDelegate();
     size_t webHistoryItemCount();
     unsigned workerThreadCount() const;

Modified: trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp (115945 => 115946)


--- trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp	2012-05-03 08:22:58 UTC (rev 115946)
@@ -897,3 +897,12 @@
 {
 }
 
+void LayoutTestController::resetPageVisibility()
+{
+    notImplemented();
+}
+
+void LayoutTestController::setPageVisibility(const char* visibility)
+{
+    notImplemented();
+}

Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (115945 => 115946)


--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-05-03 08:22:58 UTC (rev 115946)
@@ -844,3 +844,19 @@
 void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
 {
 }
+
+void LayoutTestController::resetPageVisibility()
+{
+    ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_VISIBLE, true);
+}
+
+void LayoutTestController::setPageVisibility(const char* visibility)
+{
+    String newVisibility(visibility);
+    if (newVisibility == "visible")
+        ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_VISIBLE, false);
+    else if (newVisibility == "hidden")
+        ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_HIDDEN, false);
+    else if (newVisibility == "prerender")
+        ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_PRERENDER, false);
+}

Modified: trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp (115945 => 115946)


--- trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp	2012-05-03 08:22:58 UTC (rev 115946)
@@ -1031,3 +1031,13 @@
 void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
 {
 }
+
+void LayoutTestController::resetPageVisibility()
+{
+    // FIXME: Implement this.
+}
+
+void LayoutTestController::setPageVisibility(const char* visibility)
+{
+    // FIXME: Implement this.
+}

Modified: trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp (115945 => 115946)


--- trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp	2012-05-03 08:22:58 UTC (rev 115946)
@@ -983,6 +983,16 @@
     // FIXME: Implement.
 }
 
+void LayoutTestController::resetPageVisibility()
+{
+    // FIXME: Implement this.
+}
+
+void LayoutTestController::setPageVisibility(const char* visibility)
+{
+    // FIXME: Implement this.
+}
+
 QString LayoutTestController::layerTreeAsText()
 {
     return DumpRenderTreeSupportQt::layerTreeAsText(m_drt->webPage()->mainFrame());

Modified: trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h (115945 => 115946)


--- trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h	2012-05-03 08:22:58 UTC (rev 115946)
@@ -239,6 +239,9 @@
     void setMockSpeechInputDumpRect(bool flag);
     void startSpeechInput(const QString& inputElement);
 
+    void setPageVisibility(const char*);
+    void resetPageVisibility();
+
     // Empty stub method to keep parity with object model exposed by global LayoutTestController.
     void abortModal() {}
 

Modified: trunk/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp (115945 => 115946)


--- trunk/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp	2012-05-03 08:22:58 UTC (rev 115946)
@@ -1542,3 +1542,13 @@
 {
     // FIXME: Implement.
 }
+
+void LayoutTestController::resetPageVisibility()
+{
+    // FIXME: Implement this.
+}
+
+void LayoutTestController::setPageVisibility(const char* visibility)
+{
+    // FIXME: Implement this.
+}

Modified: trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp (115945 => 115946)


--- trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp	2012-05-03 08:03:24 UTC (rev 115945)
+++ trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp	2012-05-03 08:22:58 UTC (rev 115946)
@@ -653,3 +653,13 @@
 {
     // FIXME: Implement.
 }
+
+void LayoutTestController::resetPageVisibility()
+{
+    // FIXME: Implement this.
+}
+
+void LayoutTestController::setPageVisibility(const char* visibility)
+{
+    // FIXME: Implement this.
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to