Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1b33e623264de635b23633eeeb97417595ed7d8f
https://github.com/WebKit/WebKit/commit/1b33e623264de635b23633eeeb97417595ed7d8f
Author: Sammy Gill <[email protected]>
Date: 2026-09-23 (Wed, 23 Sep 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/GridAreaLines.h
M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.cpp
M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.h
M Source/WebCore/layout/formattingContexts/grid/UnplacedGridItem.cpp
M Source/WebCore/layout/formattingContexts/grid/UnplacedGridItem.h
Log Message:
-----------
[GFC] Adopt WTF::Range to represent the lines an item spans in a dimension.
https://bugs.webkit.org/show_bug.cgi?id=325006
rdar://problem/188212275
Reviewed by Cole Carley.
ImplicitGrid's helpers took start and end lines as separate size_t parameters.
This
is fine for the most part and does not really have any issues, but we can better
represent this idea as two sets of WTF::Ranges. As of now this is just a minor
refactoring/cleanup but it will be a bit more useful as we begin to implement
column based grid-auto-flow.
Throughout this patch we just go through and replace the instances where we have
a start index and end index for an item's position and just replace it with a
WTF::Range.
No change in behavior.
* Source/WebCore/layout/formattingContexts/grid/GridAreaLines.h:
Make sure to default initialize the lines here. Currently this is
not an issue due to how this structure is created and used but this
could be very easily turn into a deal bug.
We can also potentially change this struct to be two WTF::Ranges but I
leave this to be done in a separate commit since it will require a bit
more work.
Canonical link: https://commits.webkit.org/321752@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
