Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6294e73a9e73aa9488c2d09685a4d7cb0499feea
      
https://github.com/WebKit/WebKit/commit/6294e73a9e73aa9488c2d09685a4d7cb0499feea
  Author: Wenson Hsieh <[email protected]>
  Date:   2026-09-23 (Wed, 23 Sep 2026)

  Changed paths:
    M 
LayoutTests/fast/text-extraction/debug-text-extraction-interactions-expected.txt
    M LayoutTests/fast/text-extraction/debug-text-extraction-interactions.html
    M Source/WebCore/page/text-extraction/TextExtraction.cpp

  Log Message:
  -----------
  [Text Extraction] hm.com: clicking on SETTINGS link sometimes fails with 
'search text missing' failure
https://bugs.webkit.org/show_bug.cgi?id=324924
rdar://188104073

Reviewed by Abrar Rahman Protyasha.

After the changes in 321531@main, getting interaction descriptions for an 
interaction with both
search text and a `uid` succeeds as long as the `uid` maps directly to a link 
or text form control
element. However, the actual interaction handling is currently inconsistent, 
and ends up failing
with `'…' not found inside the target node`.

Align these two behaviors more closely, by applying the same exception when 
clicking links as well.

* 
LayoutTests/fast/text-extraction/debug-text-extraction-interactions-expected.txt:
* LayoutTests/fast/text-extraction/debug-text-extraction-interactions.html:
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::canRelaxTextSearchWhenTargeting):
(WebCore::TextExtraction::searchForInteractionTargetText):
(WebCore::TextExtraction::textDescription):

Canonical link: https://commits.webkit.org/321692@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to