Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 36a3ac72aacb351605c6e60a0d7596ee2763b197
https://github.com/WebKit/WebKit/commit/36a3ac72aacb351605c6e60a0d7596ee2763b197
Author: Chris Dumez <[email protected]>
Date: 2026-09-23 (Wed, 23 Sep 2026)
Changed paths:
M Source/WTF/wtf/cf/CFTypeTraits.h
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/DeleteSelectionCommand.cpp
M Source/WebCore/editing/Editing.cpp
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/EditorCommand.cpp
A Source/WebCore/editing/EditorInternalCommand.h
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/editing/InsertIntoTextNodeCommand.cpp
M Source/WebCore/editing/MarkupAccumulator.cpp
M Source/WebCore/editing/RenderedPosition.cpp
M Source/WebCore/editing/ReplaceSelectionCommand.cpp
M Source/WebCore/editing/SimplifyMarkupCommand.cpp
M Source/WebCore/editing/SmartReplaceCF.cpp
M Source/WebCore/editing/TextInsertionBaseCommand.cpp
M Source/WebCore/editing/TextManipulationController.cpp
M Source/WebCore/editing/TypingCommand.cpp
M Source/WebCore/editing/VisiblePosition.cpp
M Source/WebCore/editing/VisibleUnits.cpp
M Source/WebCore/editing/cocoa/EditingHTMLConverter.mm
M Source/WebCore/editing/cocoa/EditorCocoa.mm
M Source/WebCore/editing/cocoa/NodeHTMLConverter.mm
M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
M Source/WebCore/editing/mac/EditorMac.mm
M Source/WebCore/editing/markup.cpp
Log Message:
-----------
[Safer CPP] Address warnings in WebCore/editing
https://bugs.webkit.org/show_bug.cgi?id=324805
Reviewed by Ryosuke Niwa.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
* Source/WebCore/editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs):
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
* Source/WebCore/editing/Editing.cpp:
(WebCore::localCaretRectInRendererForRect):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::smartInsertDeleteEnabled):
(WebCore::Editor::canSmartCopyOrDelete):
(WebCore::Editor::isSelectTrailingWhitespaceEnabled const):
(WebCore::Editor::pasteAsPlainTextWithPasteboard):
(WebCore::Editor::canSmartReplaceWithPasteboard):
(WebCore::Editor::shouldInsertFragment):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::shouldDeleteRange const):
(WebCore::Editor::shouldInsertText const):
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::isContinuousSpellCheckingEnabled const):
(WebCore::Editor::toggleContinuousSpellChecking):
(WebCore::Editor::isGrammarCheckingEnabled):
(WebCore::Editor::toggleGrammarChecking):
(WebCore::Editor::spellCheckerDocumentTag):
(WebCore::Editor::uppercaseWord):
(WebCore::Editor::lowercaseWord):
(WebCore::Editor::capitalizeWord):
(WebCore::Editor::canApplyCaseTransformations):
(WebCore::Editor::canConvertToSimplifiedChinese):
(WebCore::Editor::canConvertToTraditionalChinese):
(WebCore::Editor::convertToTraditionalChinese):
(WebCore::Editor::convertToSimplifiedChinese):
(WebCore::Editor::showSubstitutionsPanel):
(WebCore::Editor::substitutionsPanelIsShowing):
(WebCore::Editor::toggleSmartInsertDelete):
(WebCore::Editor::isAutomaticQuoteSubstitutionEnabled):
(WebCore::Editor::toggleAutomaticQuoteSubstitution):
(WebCore::Editor::isAutomaticLinkDetectionEnabled):
(WebCore::Editor::toggleAutomaticLinkDetection):
(WebCore::Editor::isAutomaticDashSubstitutionEnabled):
(WebCore::Editor::toggleAutomaticDashSubstitution):
(WebCore::Editor::isAutomaticTextReplacementEnabled):
(WebCore::Editor::toggleAutomaticTextReplacement):
(WebCore::Editor::toggleAutomaticSpellingCorrection):
(WebCore::Editor::toggleSmartLists):
(WebCore::Editor::isSmartListsEnabled):
(WebCore::Editor::shouldEndEditing):
(WebCore::Editor::shouldBeginEditing):
(WebCore::Editor::clearUndoRedoOperations):
(WebCore::Editor::canUndo const):
(WebCore::Editor::undo):
(WebCore::Editor::canRedo const):
(WebCore::Editor::redo):
(WebCore::Editor::didBeginEditing):
(WebCore::Editor::didEndEditing):
(WebCore::Editor::willWriteSelectionToPasteboard):
(WebCore::Editor::didWriteSelectionToPasteboard):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::misspelledSelectionString const):
(WebCore::Editor::showSpellingGuessPanel):
(WebCore::Editor::spellingPanelIsShowing):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::shouldChangeSelection const):
(WebCore::Editor::textFieldDidBeginEditing):
(WebCore::Editor::textFieldDidEndEditing):
(WebCore::Editor::textDidChangeInTextField):
(WebCore::Editor::doTextFieldCommandFromEvent):
(WebCore::Editor::textWillBeDeletedInTextField):
(WebCore::Editor::textDidChangeInTextArea):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::notifyClientOfAttachmentUpdates):
(WebCore::Editor::fontForSelection):
* Source/WebCore/editing/Editor.h:
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::expandSelectionToGranularity):
(WebCore::stateTextWritingDirection):
(WebCore::verticalScrollDistance):
(WebCore::executeMoveBackward):
(WebCore::executeMoveBackwardAndModifySelection):
(WebCore::executeMoveDown):
(WebCore::executeMoveDownAndModifySelection):
(WebCore::executeMoveForward):
(WebCore::executeMoveForwardAndModifySelection):
(WebCore::executeMoveLeft):
(WebCore::executeMoveLeftAndModifySelection):
(WebCore::executeMovePageDown):
(WebCore::executeMovePageDownAndModifySelection):
(WebCore::executeMovePageUp):
(WebCore::executeMovePageUpAndModifySelection):
(WebCore::executeMoveRight):
(WebCore::executeMoveRightAndModifySelection):
(WebCore::executeMoveToBeginningOfDocument):
(WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
(WebCore::executeMoveToBeginningOfLine):
(WebCore::executeMoveToBeginningOfLineAndModifySelection):
(WebCore::executeMoveToBeginningOfParagraph):
(WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
(WebCore::executeMoveToBeginningOfSentence):
(WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
(WebCore::executeMoveToEndOfDocument):
(WebCore::executeMoveToEndOfDocumentAndModifySelection):
(WebCore::executeMoveToEndOfSentence):
(WebCore::executeMoveToEndOfSentenceAndModifySelection):
(WebCore::executeMoveToEndOfLine):
(WebCore::executeMoveToEndOfLineAndModifySelection):
(WebCore::executeMoveToEndOfParagraph):
(WebCore::executeMoveToEndOfParagraphAndModifySelection):
(WebCore::executeMoveParagraphBackwardAndModifySelection):
(WebCore::executeMoveParagraphForwardAndModifySelection):
(WebCore::executeMoveUp):
(WebCore::executeMoveUpAndModifySelection):
(WebCore::executeMoveWordBackward):
(WebCore::executeMoveWordBackwardAndModifySelection):
(WebCore::executeMoveWordForward):
(WebCore::executeMoveWordForwardAndModifySelection):
(WebCore::executeMoveWordLeft):
(WebCore::executeMoveWordLeftAndModifySelection):
(WebCore::executeMoveWordRight):
(WebCore::executeMoveWordRightAndModifySelection):
(WebCore::executeMoveToLeftEndOfLine):
(WebCore::executeMoveToLeftEndOfLineAndModifySelection):
(WebCore::executeMoveToRightEndOfLine):
(WebCore::executeMoveToRightEndOfLineAndModifySelection):
(WebCore::executeSelectAll):
(WebCore::executeSetMark):
(WebCore::executeSwapWithMark):
(WebCore::executeUnselect):
(WebCore::enabledInRichlyEditableText):
(WebCore::enabledRangeInEditableText):
(WebCore::enabledRangeInRichlyEditableText):
(WebCore::valueFormatBlock):
* Source/WebCore/editing/EditorInternalCommand.h: Added.
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::createCaretAnimator):
(WebCore::FrameSelection::willBeRemovedFromFrame):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::FrameSelection::invalidateCaretRect):
(WebCore::FrameSelection::paintCaret):
(WebCore::rendererSkippingInlinesNotPaintingUnderCaret):
(WebCore::CaretBase::computeCaretColor):
(WebCore::caretColorForNode):
(WebCore::FrameSelection::setCaretBlinkingSuspended):
(WebCore::FrameSelection::caretAnimatorInvalidated):
(WebCore::FrameSelection::contains const):
(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::updateCaretVisibility):
(WebCore::FrameSelection::getClippedVisibleTextRectangles const):
(WebCore::FrameSelection::revealSelection):
* Source/WebCore/editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::shouldEnablePasswordEcho const):
* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::isScriptEnabled):
* Source/WebCore/editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun const):
(WebCore::RenderedPosition::absoluteRect const):
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::hasRenderedText):
(WebCore::collectStylesToRemove):
* Source/WebCore/editing/SimplifyMarkupCommand.cpp:
(WebCore::mayAffectLayout):
(WebCore::SimplifyMarkupCommand::doApply):
* Source/WebCore/editing/SmartReplaceCF.cpp:
(WebCore::getSmartSet):
(WebCore::isCharacterSmartReplaceExempt):
* Source/WebCore/editing/TextInsertionBaseCommand.cpp:
(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::tokenInfo):
(WebCore::TextManipulationController::shouldExcludeNodeBasedOnStyle):
(WebCore::TextManipulationController::scheduleObservationUpdate):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):
(WebCore::TypingCommand::insertLineBreakAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContentAndNotifyAccessibility):
* Source/WebCore/editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):
* Source/WebCore/editing/VisibleUnits.cpp:
(WebCore::endPositionForLine):
* Source/WebCore/editing/cocoa/EditingHTMLConverter.mm:
(WebCore::fileWrapperForElement):
(WebCore::updateAttributes):
* Source/WebCore/editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::getPasteboardTypesAndDataForAttachment):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeSelection):
(WebCore::Editor::replaceNodeFromPasteboard):
* Source/WebCore/editing/cocoa/NodeHTMLConverter.mm:
(_fontForNameAndSize):
(normalizedColor):
(_font):
(HTMLConverter::computedAttributesForElement):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors):
(HTMLConverter::_newParagraphForElement):
(HTMLConverter::_newLineForElement):
(HTMLConverter::_newTabForElement):
(HTMLConverter::_addRemoteFrameMarker):
(HTMLConverter::_addAttachmentForElement):
(HTMLConverter::_addQuoteForElement):
(HTMLConverter::_addValue):
(HTMLConverter::_processMetaElementWithName):
(HTMLConverter::_addMarkersToList):
(HTMLConverter::_exitElement):
* Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::createFragmentInternal):
* Source/WebCore/editing/mac/EditorMac.mm:
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::platformPasteFont):
(WebCore::Editor::selectionWillChange):
* Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):
(WebCore::highestAncestorToWrapMarkup):
Canonical link: https://commits.webkit.org/321672@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
