Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a0b295a2b4d04474dcd3edf1efb7625b11292a52
https://github.com/WebKit/WebKit/commit/a0b295a2b4d04474dcd3edf1efb7625b11292a52
Author: Anne van Kesteren <[email protected]>
Date: 2026-09-22 (Tue, 22 Sep 2026)
Changed paths:
A
LayoutTests/fast/forms/select/base/select-pick-in-disabled-select-expected.txt
A LayoutTests/fast/forms/select/base/select-pick-in-disabled-select.html
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-pick-option-dirtiness-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-pick-option-dirtiness.html
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/w3c-import.log
M Source/WebCore/html/HTMLOptionElement.cpp
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/html/HTMLSelectElement.h
Log Message:
-----------
Picking an option in a base-select picker should set its dirtiness
https://bugs.webkit.org/show_bug.cgi?id=324813
Reviewed by Tim Nguyen.
Add an implementation of the pick algorithm covering the aspects we were not
already handling today:
- dirtiness; and
- not allowing picking in a disabled select.
The two remaining steps are already covered by the callers. An event whose
canceled
flag is set never reaches a default event handler, and the button attribute is
checked at the mousedown call site, the only one that passes a MouseEvent.
Tests: fast/forms/select/base/select-pick-in-disabled-select.html
imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-pick-option-dirtiness.html
Canonical link: https://commits.webkit.org/321665@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
