[webkit-changes] [115762] branches/chromium/1084

Tue, 01 May 2012 16:45:00 -0700

Title: [115762] branches/chromium/1084
Revision
115762
Author
[email protected]
Date
2012-05-01 16:45:55 -0700 (Tue, 01 May 2012)

Log Message

Partial revert of r110072: Lazily allocate overflow: hidden layers if we have overflowing content

This chage forces us to allocate RenderLayers for overflow: hidden as it has been causing several
regressions. It leaves all of the scaffolding around to keep the change small. See bug 83954 for
the proper revert for trunk.

Modified Paths

Diff

Modified: branches/chromium/1084/LayoutTests/platform/chromium/test_expectations.txt (115761 => 115762)


--- branches/chromium/1084/LayoutTests/platform/chromium/test_expectations.txt	2012-05-01 23:39:21 UTC (rev 115761)
+++ branches/chromium/1084/LayoutTests/platform/chromium/test_expectations.txt	2012-05-01 23:45:55 UTC (rev 115762)
@@ -2661,8 +2661,7 @@
 BUG_DRT : fast/dynamic/window-resize-scrollbars-test.html = IMAGE+TEXT
 BUG_DRT DEBUG : fast/frames/calculate-round.html = PASS TIMEOUT
 BUGCR43890 SLOW DEBUG : fast/forms/implicit-submission.html = PASS TEXT
-// Rebaseline needed after BUGWK75568
-BUG_DRT : fast/repaint/iframe-scroll-repaint.html = IMAGE+TEXT
+BUG_DRT : fast/repaint/iframe-scroll-repaint.html = IMAGE
 BUG_DRT LINUX : fast/repaint/repaint-across-writing-mode-boundary.html = IMAGE
 BUG_DRT LINUX : fast/text/justification-padding-mid-word.html = PASS TEXT
 BUG_DRT LINUX MAC : http/tests/plugins/post-url-file.html = TIMEOUT
@@ -4336,3 +4335,192 @@
 BUGWK82129 MAC : fast/block/lineboxcontain/block-font.html = TEXT
 BUGWK82129 MAC : fast/block/lineboxcontain/block-glyphs.html = TEXT
 BUGWK82129 MAC : fast/block/lineboxcontain/font.html = TEXT
+
+// Disabled after reverting lazily layer allocation.
+// The difference should be only layer addition, no size or position should change.
+
+// Those tests have other entries in our expectations filed and may not totally covers
+BUGWK83954 RELEASE : animations/combo-transform-translate+scale.html = TEXT
+BUGWK83954 LINUX DEBUG : animations/combo-transform-translate+scale.html = TEXT
+BUGWK83954 WIN LINUX : editing/spelling/inline_spelling_markers.html = TEXT
+BUGWK83954 WIN LINUX : fast/forms/form-element-geometry.html = TEXT
+BUGWK83954 WIN LINUX : fast/forms/input-value.html = TEXT
+BUGWK83954 WIN LINUX : fast/layers/add-layer-with-nested-stacking.html = TEXT
+BUGWK83954 WIN LINUX : fast/layers/remove-layer-with-nested-stacking.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/inline-relative-positioned.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/lines-with-layout-delta.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/overflow-clip-subtree-layout.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/repaint-resized-overflow.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/subtree-layoutstate-transform.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/subtree-root-clip-2.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/subtree-root-clip.html = TEXT
+BUGWK83954 WIN LINUX : fast/repaint/subtree-root-skipped.html = TEXT
+BUGWK83954 WIN LINUX : fast/replaced/replaced-breaking.html = TEXT
+BUGWK83954 WIN LINUX : fast/replaced/width100percent-searchfield.html = TEXT
+BUGWK83954 WIN LINUX : fast/text/textIteratorNilRenderer.html = TEXT
+
+// Those tests need a text baseline after lazily allocating layers.
+// The change should only be layer removal.
+BUGWK83954 : compositing/geometry/object-clip-rects-assertion.html = TEXT
+BUGWK83954 : compositing/overflow/ancestor-overflow.html = TEXT
+BUGWK83954 : editing/inserting/before-after-input-element.html = TEXT
+BUGWK83954 : editing/pasteboard/4806874.html = TEXT
+BUGWK83954 : editing/pasteboard/drop-text-without-selection.html = TEXT
+BUGWK83954 : editing/pasteboard/input-field-1.html = TEXT
+BUGWK83954 : editing/selection/3690703-2.html = TEXT
+BUGWK83954 : editing/selection/3690703.html = TEXT
+BUGWK83954 : editing/selection/3690719.html = TEXT
+BUGWK83954 : editing/selection/4895428-3.html = TEXT
+BUGWK83954 : editing/selection/4975120.html = TEXT
+BUGWK83954 : editing/selection/drag-select-1.html = TEXT
+BUGWK83954 : editing/selection/expanding-selections.html = TEXT
+BUGWK83954 : editing/selection/leave-requested-block.html = TEXT
+BUGWK83954 : editing/selection/select-across-readonly-input-1.html = TEXT
+BUGWK83954 : editing/selection/select-across-readonly-input-2.html = TEXT
+BUGWK83954 : editing/selection/select-across-readonly-input-3.html = TEXT
+BUGWK83954 : editing/selection/select-across-readonly-input-4.html = TEXT
+BUGWK83954 : editing/selection/select-across-readonly-input-5.html = TEXT
+BUGWK83954 : fast/block/float/032.html = TEXT
+BUGWK83954 : fast/block/float/033.html = TEXT
+BUGWK83954 : fast/block/float/avoidance-rtl.html = TEXT
+BUGWK83954 : fast/block/float/float-not-removed-from-next-sibling3.html = TEXT
+BUGWK83954 : fast/block/float/float-overflow-hidden-containing-block-width.html = TEXT
+BUGWK83954 : fast/block/float/in-margin.html = TEXT
+BUGWK83954 : fast/block/float/overlapping-floats-with-overflow-hidden.html = TEXT
+BUGWK83954 : fast/block/float/shrink-to-avoid-float-complexity.html = TEXT
+BUGWK83954 : fast/block/lineboxcontain/block-font.html = TEXT
+BUGWK83954 : fast/block/lineboxcontain/block-glyphs.html = TEXT
+BUGWK83954 : fast/block/lineboxcontain/font.html = TEXT
+BUGWK83954 : fast/block/lineboxcontain/parsing-invalid.html = TEXT
+BUGWK83954 : fast/block/margin-collapse/103.html = TEXT
+BUGWK83954 : fast/clip/017.html = TEXT
+BUGWK83954 : fast/css/input-search-padding.html = TEXT
+BUGWK83954 : fast/css/invalidation-errors-2.html = TEXT
+BUGWK83954 : fast/css/invalidation-errors.html = TEXT
+BUGWK83954 : fast/css/line-height.html = TEXT
+BUGWK83954 : fast/css/nested-layers-with-hover.html = TEXT
+BUGWK83954 : fast/css/resize-single-axis.html = TEXT
+BUGWK83954 : fast/css/text-input-with-webkit-border-radius.html = TEXT
+BUGWK83954 : fast/css/text-overflow-input.html = TEXT
+BUGWK83954 : fast/dom/isindex-001.html = TEXT
+BUGWK83954 : fast/dom/isindex-002.html = TEXT
+BUGWK83954 : fast/dynamic/subtree-boundary-percent-height.html = TEXT
+BUGWK83954 : fast/dynamic/subtree-no-common-root-static-y.html = TEXT
+BUGWK83954 : fast/dynamic/subtree-table-cell-height.html = TEXT
+BUGWK83954 : fast/events/autoscroll.html = TEXT
+BUGWK83954 : fast/events/context-no-deselect.html = TEXT
+BUGWK83954 : fast/events/mouse-relative-position.html = TEXT
+BUGWK83954 : fast/forms/basic-inputs.html = TEXT
+BUGWK83954 : fast/forms/box-shadow-override.html = TEXT
+BUGWK83954 : fast/forms/encoding-test.html = TEXT
+BUGWK83954 : fast/forms/fieldset-align.html = TEXT
+BUGWK83954 : fast/forms/floating-textfield-relayout.html = TEXT
+BUGWK83954 : fast/forms/input-align.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-bkcolor.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-default-bkcolor.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-disabled.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-focus.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-height.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-preventDefault.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-readonly.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-selection.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-visibility.html = TEXT
+BUGWK83954 : fast/forms/input-appearance-width.html = TEXT
+BUGWK83954 : fast/forms/input-baseline.html = TEXT
+BUGWK83954 : fast/forms/input-double-click-selection-gap-bug.html = TEXT
+BUGWK83954 : fast/forms/input-field-text-truncated.html = TEXT
+BUGWK83954 : fast/forms/input-placeholder-visibility-1.html = TEXT
+BUGWK83954 : fast/forms/input-placeholder-visibility-3.html = TEXT
+BUGWK83954 : fast/forms/input-readonly-empty.html = TEXT
+BUGWK83954 : fast/forms/input-spaces.html = TEXT
+BUGWK83954 : fast/forms/input-table.html = TEXT
+BUGWK83954 : fast/forms/input-text-click-inside.html = TEXT
+BUGWK83954 : fast/forms/input-text-click-outside.html = TEXT
+BUGWK83954 : fast/forms/input-text-option-delete.html = TEXT
+BUGWK83954 : fast/forms/input-text-self-emptying-click.html = TEXT
+BUGWK83954 : fast/forms/input-width.html = TEXT
+BUGWK83954 : fast/forms/number/input-appearance-number-rtl.html = TEXT
+BUGWK83954 : fast/forms/number/input-appearance-spinbutton-disabled-readonly.html = TEXT
+BUGWK83954 : fast/forms/number/input-appearance-spinbutton-layer.html = TEXT
+BUGWK83954 : fast/forms/placeholder-position.html = TEXT
+BUGWK83954 : fast/forms/placeholder-pseudo-style.html = TEXT
+BUGWK83954 : fast/forms/plaintext-mode-2.html = TEXT
+BUGWK83954 : fast/forms/search-cancel-button-style-sharing.html = TEXT
+BUGWK83954 : fast/forms/search-display-none-cancel-button.html = TEXT
+BUGWK83954 : fast/forms/search-rtl.html = TEXT
+BUGWK83954 : fast/forms/search-styled.html = TEXT
+BUGWK83954 : fast/forms/search-vertical-alignment.html = TEXT
+BUGWK83954 : fast/forms/searchfield-heights.html = TEXT
+BUGWK83954 : fast/forms/tabbing-input-iframe.html = TEXT
+BUGWK83954 : fast/forms/text-style-color.html = TEXT
+BUGWK83954 : fast/forms/textfield-focus-ring.html = TEXT
+BUGWK83954 : fast/forms/validation-message-appearance.html = TEXT
+BUGWK83954 : fast/forms/visual-hebrew-text-field.html = TEXT
+BUGWK83954 : fast/frames/take-focus-from-iframe.html = TEXT
+BUGWK83954 : fast/html/details-no-summary4.html = TEXT
+BUGWK83954 : fast/html/details-open-_javascript_.html = TEXT
+BUGWK83954 : fast/html/details-open2.html = TEXT
+BUGWK83954 : fast/html/details-open4.html = TEXT
+BUGWK83954 : fast/invalid/residual-style.html = TEXT
+BUGWK83954 : fast/layers/self-painting-outline.html = TEXT
+BUGWK83954 : fast/lists/dynamic-marker-crash.html = TEXT
+BUGWK83954 : fast/multicol/layers-split-across-columns.html = TEXT
+BUGWK83954 : fast/overflow/004.html = TEXT
+BUGWK83954 : fast/overflow/clip-rects-fixed-ancestor.html = TEXT
+BUGWK83954 : fast/overflow/line-clamp.html = TEXT
+BUGWK83954 : fast/overflow/overflow-focus-ring.html = TEXT
+BUGWK83954 : fast/repaint/layer-outline-horizontal.html = TEXT
+BUGWK83954 : fast/repaint/layer-outline.html = TEXT
+BUGWK83954 : fast/repaint/opacity-change-on-overflow-float.html = TEXT
+BUGWK83954 : fast/repaint/renderer-destruction-by-invalidateSelection-crash.html = TEXT
+BUGWK83954 : fast/repaint/subtree-root-clip-3.html = TEXT
+BUGWK83954 : fast/replaced/replaced-breaking-mixture.html = TEXT
+BUGWK83954 : fast/text/selection-painted-separately.html = TEXT
+BUGWK83954 : fast/text/selection-rect-rounding.html = TEXT
+BUGWK83954 : fast/transforms/transformed-focused-text-input.html = TEXT
+BUGWK83954 : plugins/mouse-click-plugin-clears-selection.html = TEXT
+BUGWK83954 : svg/custom/inline-svg-in-xhtml.xml = TEXT
+BUGWK83954 : svg/hixie/mixed/003.xml = TEXT
+BUGWK83954 : tables/mozilla/bugs/45621.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug12384.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug154780.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug18359.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug24200.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug2479-2.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug2479-3.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug2479-4.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug28928.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug4382.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug44505.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug4527.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug46368-1.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug46368-2.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug51037.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug55545.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug7342.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug99948.html = TEXT
+BUGWK83954 : tables/mozilla/dom/tableDom.html = TEXT
+BUGWK83954 : tables/mozilla/other/move_row.html = TEXT
+BUGWK83954 : tables/mozilla_expected_failures/bugs/bug106966.html = TEXT
+BUGWK83954 : tables/mozilla_expected_failures/bugs/bug45621.html = TEXT
+BUGWK83954 : tables/mozilla_expected_failures/bugs/bug92647-1.html = TEXT
+BUGWK83954 : fast/replaced/width100percent-textfield.html = TEXT
+BUGWK83954 : fast/speech/input-appearance-searchandspeech.html = TEXT
+BUGWK83954 : fast/speech/input-appearance-speechbutton.html = TEXT
+BUGWK83954 : fast/speech/speech-bidi-rendering.html = TEXT
+BUGWK83954 : fast/table/003.html = TEXT
+BUGWK83954 : fast/table/029.html = TEXT
+BUGWK83954 : fast/table/colspanMinWidth-vertical.html = TEXT
+BUGWK83954 : fast/table/colspanMinWidth.html = TEXT
+BUGWK83954 : fast/table/overflowHidden.html = TEXT
+BUGWK83954 : fast/table/spanOverlapRepaint.html = TEXT
+BUGWK83954 : fast/table/text-field-baseline.html = TEXT
+BUGWK83954 : tables/mozilla/bugs/bug1188.html = TEXT
+BUGWK83954 : fast/repaint/search-field-cancel.html = TEXT
+BUGWK83954 : fast/clip/008.html = TEXT
+BUGWK83954 : fast/clip/011.html = TEXT
+BUGWK83954 : fast/clip/012.html = TEXT
+BUGWK83954 : fast/box-shadow/shadow-buffer-partial.html = TEXT
+BUGWK83954 : fast/forms/input-text-double-click.html = TEXT
+BUGWK83954 : fast/repaint/table-hover-on-link.html = TEXT
+BUGWK83954 : http/tests/navigation/_javascript_link-frames.html = TEXT

Modified: branches/chromium/1084/Source/WebCore/rendering/RenderBox.h (115761 => 115762)


--- branches/chromium/1084/Source/WebCore/rendering/RenderBox.h	2012-05-01 23:39:21 UTC (rev 115761)
+++ branches/chromium/1084/Source/WebCore/rendering/RenderBox.h	2012-05-01 23:45:55 UTC (rev 115762)
@@ -42,7 +42,7 @@
     RenderBox(Node*);
     virtual ~RenderBox();
 
-    virtual bool requiresLayer() const OVERRIDE { return isRoot() || isPositioned() || isRelPositioned() || isTransparent() || requiresLayerForOverflowClip() || hasTransform() || hasHiddenBackface() || hasMask() || hasReflection() || hasFilter() || style()->specifiesColumns(); }
+    virtual bool requiresLayer() const OVERRIDE { return isRoot() || isPositioned() || isRelPositioned() || isTransparent() || hasOverflowClip() || hasTransform() || hasHiddenBackface() || hasMask() || hasReflection() || hasFilter() || style()->specifiesColumns(); }
     bool requiresLayerForOverflowClip() const;
 
     bool hasOverflowClipWithLayer() const { return hasOverflowClip() && hasLayer(); }

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to