Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4588e2f827d5f26549d89869f9865030fc3f660f
https://github.com/WebKit/WebKit/commit/4588e2f827d5f26549d89869f9865030fc3f660f
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
A
LayoutTests/accessibility/aria-keyshortcuts-platform-modifier-names-expected.txt
A LayoutTests/accessibility/aria-keyshortcuts-platform-modifier-names.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
VoiceOver announces aria-keyshortcuts Meta/Alt literally instead of
Command/Option on macOS
https://bugs.webkit.org/show_bug.cgi?id=323089
rdar://186342070
Reviewed by Dominic Mazzoni.
aria-keyshortcuts values name keys using the platform-neutral UI Events
KeyboardEvent key values, so a correctly-authored shortcut is written
"Meta+Shift+M" or "Alt+Shift+M". We exposed those strings through
AXKeyShortcutsValue untouched, and VoiceOver speaks the attribute verbatim,
so it announced "Meta Shift M" for keys that Apple keyboards label Command
and Option. No Mac keyboard has a key named Meta, so the announcement named
a key the user could not find.
Add AXCoreObject::keyShortcutsPlatformString(), which rewrites Meta to
Command and Alt to Option, and use it from the Mac and iOS wrappers.
*
LayoutTests/accessibility/aria-keyshortcuts-platform-modifier-names-expected.txt:
Added.
* LayoutTests/accessibility/aria-keyshortcuts-platform-modifier-names.html:
Added.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::platformNameForShortcutKey):
(WebCore::AXCoreObject::keyShortcutsPlatformString const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityKeyboardShortcuts]):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(handleKeyShortcutsAttribute):
Canonical link: https://commits.webkit.org/320424@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
