Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ffffaa2b2c717ed716eb66afe6b596ace506bfb8
https://github.com/WebKit/WebKit/commit/ffffaa2b2c717ed716eb66afe6b596ace506bfb8
Author: Alan Baradlay <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
M LayoutTests/fast/html/details-add-child-1-expected.txt
M LayoutTests/fast/html/details-add-child-2-expected.txt
M LayoutTests/fast/html/details-add-details-child-1-expected.txt
M LayoutTests/fast/html/details-add-details-child-2-expected.txt
M LayoutTests/fast/html/details-add-summary-10-expected.txt
M LayoutTests/fast/html/details-add-summary-6-expected.txt
M LayoutTests/fast/html/details-add-summary-7-expected.txt
M LayoutTests/fast/html/details-add-summary-8-expected.txt
M LayoutTests/fast/html/details-add-summary-9-expected.txt
M LayoutTests/fast/html/details-add-summary-child-1-expected.txt
M LayoutTests/fast/html/details-add-summary-child-2-expected.txt
M LayoutTests/fast/html/details-nested-1-expected.txt
M LayoutTests/fast/html/details-nested-2-expected.txt
M LayoutTests/fast/html/details-no-summary2-expected.txt
M LayoutTests/fast/html/details-open6-expected.txt
M LayoutTests/fast/html/details-remove-child-1-expected.txt
M LayoutTests/fast/html/details-remove-child-2-expected.txt
M LayoutTests/fast/html/details-remove-summary-4-expected.txt
M LayoutTests/fast/html/details-remove-summary-5-expected.txt
M LayoutTests/fast/html/details-remove-summary-6-expected.txt
M LayoutTests/fast/html/details-remove-summary-child-1-expected.txt
M LayoutTests/fast/html/details-remove-summary-child-2-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height.html
A LayoutTests/platform/ios/fast/html/details-add-child-1-expected.txt
A LayoutTests/platform/ios/fast/html/details-add-child-2-expected.txt
A
LayoutTests/platform/ios/fast/html/details-add-details-child-1-expected.txt
A
LayoutTests/platform/ios/fast/html/details-add-details-child-2-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-1-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-add-summary-1-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-10-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-add-summary-10-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-2-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-add-summary-2-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-3-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-add-summary-3-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-4-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-add-summary-4-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-5-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-add-summary-5-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-6-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-add-summary-6-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-7-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-add-summary-7-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-8-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-add-summary-8-expected.txt
M
LayoutTests/platform/ios/fast/html/details-add-summary-9-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-add-summary-9-expected.txt
A
LayoutTests/platform/ios/fast/html/details-add-summary-child-1-expected.txt
A
LayoutTests/platform/ios/fast/html/details-add-summary-child-2-expected.txt
M LayoutTests/platform/ios/fast/html/details-marker-style-expected.txt
M LayoutTests/platform/ios/fast/html/details-marker-style-mixed-expected.txt
A LayoutTests/platform/ios/fast/html/details-nested-1-expected.txt
A LayoutTests/platform/ios/fast/html/details-nested-2-expected.txt
M LayoutTests/platform/ios/fast/html/details-no-summary1-expected.txt
A LayoutTests/platform/ios/fast/html/details-no-summary2-expected.txt
M LayoutTests/platform/ios/fast/html/details-no-summary3-expected.txt
M LayoutTests/platform/ios/fast/html/details-open1-expected.txt
M LayoutTests/platform/ios/fast/html/details-open3-expected.txt
M LayoutTests/platform/ios/fast/html/details-open5-expected.txt
A LayoutTests/platform/ios/fast/html/details-open6-expected.txt
M LayoutTests/platform/ios/fast/html/details-position-expected.txt
A LayoutTests/platform/ios/fast/html/details-remove-child-1-expected.txt
A LayoutTests/platform/ios/fast/html/details-remove-child-2-expected.txt
M
LayoutTests/platform/ios/fast/html/details-remove-summary-1-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-remove-summary-1-expected.txt
M
LayoutTests/platform/ios/fast/html/details-remove-summary-2-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-remove-summary-2-expected.txt
M
LayoutTests/platform/ios/fast/html/details-remove-summary-3-and-click-expected.txt
M LayoutTests/platform/ios/fast/html/details-remove-summary-3-expected.txt
M
LayoutTests/platform/ios/fast/html/details-remove-summary-4-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-remove-summary-4-expected.txt
M
LayoutTests/platform/ios/fast/html/details-remove-summary-5-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-remove-summary-5-expected.txt
M
LayoutTests/platform/ios/fast/html/details-remove-summary-6-and-click-expected.txt
A LayoutTests/platform/ios/fast/html/details-remove-summary-6-expected.txt
A
LayoutTests/platform/ios/fast/html/details-remove-summary-child-1-expected.txt
A
LayoutTests/platform/ios/fast/html/details-remove-summary-child-2-expected.txt
M LayoutTests/platform/ios/fast/html/details-writing-mode-expected.txt
M LayoutTests/platform/ios/fast/html/details-writing-mode-mixed-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/html/details-no-summary4-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/html/details-open-javascript-expected.txt
M LayoutTests/platform/mac-sequoia-wk2/fast/html/details-open2-expected.txt
M LayoutTests/platform/mac-sequoia-wk2/fast/html/details-open4-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/html/details-replace-summary-child-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/html/details-replace-text-expected.txt
M LayoutTests/platform/mac-wk2/fast/html/details-no-summary4-expected.txt
M
LayoutTests/platform/mac-wk2/fast/html/details-open-javascript-expected.txt
M LayoutTests/platform/mac-wk2/fast/html/details-open2-expected.txt
M LayoutTests/platform/mac-wk2/fast/html/details-open4-expected.txt
M
LayoutTests/platform/mac-wk2/fast/html/details-replace-summary-child-expected.txt
M LayoutTests/platform/mac-wk2/fast/html/details-replace-text-expected.txt
M
LayoutTests/platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-1-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-add-summary-1-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-10-and-click-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-2-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-add-summary-2-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-3-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-add-summary-3-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-4-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-add-summary-4-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-5-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-add-summary-5-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-6-and-click-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-7-and-click-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-8-and-click-expected.txt
M
LayoutTests/platform/mac/fast/html/details-add-summary-9-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-marker-style-expected.txt
M LayoutTests/platform/mac/fast/html/details-marker-style-mixed-expected.txt
M LayoutTests/platform/mac/fast/html/details-no-summary1-expected.txt
M LayoutTests/platform/mac/fast/html/details-no-summary3-expected.txt
M LayoutTests/platform/mac/fast/html/details-open1-expected.txt
M LayoutTests/platform/mac/fast/html/details-open3-expected.txt
M LayoutTests/platform/mac/fast/html/details-open5-expected.txt
M LayoutTests/platform/mac/fast/html/details-position-expected.txt
M
LayoutTests/platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-remove-summary-1-expected.txt
M
LayoutTests/platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-remove-summary-2-expected.txt
M
LayoutTests/platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-remove-summary-3-expected.txt
M
LayoutTests/platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt
M
LayoutTests/platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt
M
LayoutTests/platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt
M LayoutTests/platform/mac/fast/html/details-writing-mode-expected.txt
M LayoutTests/platform/mac/fast/html/details-writing-mode-mixed-expected.txt
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderListMarker.h
Log Message:
-----------
[list-marker] Opening a <details> makes its summary one pixel shorter
https://bugs.webkit.org/show_bug.cgi?id=323168
rdar://problem/186413478
Reviewed by Antti Koivisto.
280433@main renders disclosure triangles with system-ui rather than with the
font the marker inherited.
It gave RenderListMarker a font cascade of its own, built at paint time, and
used it for painting,
but not for the marker box's height or its layout bounds, which stayed with the
inherited font.
Make the font part of the ::marker style instead, so that the glyph is measured
with the font it is drawn with.
Tests:
imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height-ref.html
imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/disclosure-line-height.html:
Added.
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::computeMarkerStyle const):
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderListMarker::relativeMarkerRect):
(WebCore::disclosureMarkerFontCascade): Deleted.
(WebCore::RenderListMarker::paintDisclosureMarker): Deleted.
* Source/WebCore/rendering/RenderListMarker.h:
* LayoutTests/fast/html/details-add-child-1-expected.txt:
* LayoutTests/fast/html/details-add-child-2-expected.txt:
* LayoutTests/fast/html/details-add-details-child-1-expected.txt:
* LayoutTests/fast/html/details-add-details-child-2-expected.txt:
* LayoutTests/fast/html/details-add-summary-10-expected.txt:
* LayoutTests/fast/html/details-add-summary-6-expected.txt:
* LayoutTests/fast/html/details-add-summary-7-expected.txt:
* LayoutTests/fast/html/details-add-summary-8-expected.txt:
* LayoutTests/fast/html/details-add-summary-9-expected.txt:
* LayoutTests/fast/html/details-add-summary-child-1-expected.txt:
* LayoutTests/fast/html/details-add-summary-child-2-expected.txt:
* LayoutTests/fast/html/details-nested-1-expected.txt:
* LayoutTests/fast/html/details-nested-2-expected.txt:
* LayoutTests/fast/html/details-no-summary2-expected.txt:
* LayoutTests/fast/html/details-open6-expected.txt:
* LayoutTests/fast/html/details-remove-child-1-expected.txt:
* LayoutTests/fast/html/details-remove-child-2-expected.txt:
* LayoutTests/fast/html/details-remove-summary-4-expected.txt:
* LayoutTests/fast/html/details-remove-summary-5-expected.txt:
* LayoutTests/fast/html/details-remove-summary-6-expected.txt:
* LayoutTests/fast/html/details-remove-summary-child-1-expected.txt:
* LayoutTests/fast/html/details-remove-summary-child-2-expected.txt:
* LayoutTests/platform/mac-wk2/fast/html/details-no-summary4-expected.txt:
* LayoutTests/platform/mac-wk2/fast/html/details-open-javascript-expected.txt:
* LayoutTests/platform/mac-wk2/fast/html/details-open2-expected.txt:
* LayoutTests/platform/mac-wk2/fast/html/details-open4-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/html/details-replace-summary-child-expected.txt:
* LayoutTests/platform/mac-wk2/fast/html/details-replace-text-expected.txt:
*
LayoutTests/platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-add-summary-1-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-add-summary-2-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-add-summary-3-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-add-summary-4-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-add-summary-5-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-marker-style-expected.txt:
* LayoutTests/platform/mac/fast/html/details-marker-style-mixed-expected.txt:
* LayoutTests/platform/mac/fast/html/details-no-summary1-expected.txt:
* LayoutTests/platform/mac/fast/html/details-no-summary3-expected.txt:
* LayoutTests/platform/mac/fast/html/details-open1-expected.txt:
* LayoutTests/platform/mac/fast/html/details-open3-expected.txt:
* LayoutTests/platform/mac/fast/html/details-open5-expected.txt:
* LayoutTests/platform/mac/fast/html/details-position-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-remove-summary-1-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-remove-summary-2-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-remove-summary-3-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
*
LayoutTests/platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
* LayoutTests/platform/mac/fast/html/details-writing-mode-expected.txt:
* LayoutTests/platform/mac/fast/html/details-writing-mode-mixed-expected.txt:
Canonical link: https://commits.webkit.org/320461@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
