Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d77fbd56c1428ed2f1919b400ea9aa0486a1d812
https://github.com/WebKit/WebKit/commit/d77fbd56c1428ed2f1919b400ea9aa0486a1d812
Author: Aakash Jain <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
M Tools/CISupport/Shared/generate_s3_url.py
M Tools/CISupport/Shared/steps_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[ews] Fail the build early when change_id is missing
https://bugs.webkit.org/show_bug.cgi?id=322031
rdar://185225128
Reviewed by Sam Sneddon.
Built product archives, results directories and status reporting are all keyed
on the change_id
build property. When it was unset, GenerateS3URL passed None straight through
to generateS3URL,
which interpolated it into the object key, so a build uploaded its archive to
'None.zip' and
reported success. Nothing in the producing build compares the key it wrote
against the change it
built, so the only thing which noticed was a later build downloading a key it
computed
independently, and it failed with a 404 that named no cause.
ConfigureBuild now fails when a pull request build has no change_id, stopping
the build before it
publishes an archive that no other queue can identify. generateS3URL refuses a
missing revision too.
ConfigureBuild had no unit test coverage, so tests for it are added here.
* Tools/CISupport/Shared/generate_s3_url.py:
* Tools/CISupport/Shared/steps_unittest.py:
* Tools/CISupport/ews-build/steps.py:
* Tools/CISupport/ews-build/steps_unittest.py: Added unit-tests.
Canonical link: https://commits.webkit.org/320455@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
