Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a427de213e37450d207aa032ab7968adcc59c58
https://github.com/WebKit/WebKit/commit/5a427de213e37450d207aa032ab7968adcc59c58
Author: Issac Roy <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] JSC EWS can excuse a test failure on flakiness recorded by the pull
request under test
https://bugs.webkit.org/show_bug.cgi?id=323312
<rdar://problem/186558747>
Reviewed by Aakash Jain.
`RunJavaScriptCoreTests.filter_failures_using_results_db` asks
`ResultsDatabase.flaky_verdicts_for` for a verdict without passing `authors` or
`pr_number`, so the JSC queues never drop evidence recorded by the change under
judgement. A conviction there can rest entirely on rows an earlier build of the
same pull request wrote, which waves through a change that flakes only because
of itself. The layout-test and API call sites already pass both arguments; JSC
was the only one that did not.
Forward the change's identity from the same two properties the other two read,
so `_rows_by_type` drops a row whose `pr_number` is the pull request under test
or whose every recorded author is one of the change's own.
* Tools/CISupport/ews-build/steps.py:
(RunJavaScriptCoreTests.filter_failures_using_results_db):
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/320450@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
