Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5155ec6d4d6e051767caa709a4b806227758b24b
https://github.com/WebKit/WebKit/commit/5155ec6d4d6e051767caa709a4b806227758b24b
Author: Sammy Gill <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-lanes/animation/fit-tolerance-interpolation-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/style/values/grid/StyleFitTolerance.cpp
M Source/WebCore/style/values/grid/StyleFitTolerance.h
Log Message:
-----------
[Grid Lanes] fit-tolerance does not interpolate between <length-percentage>
values
https://bugs.webkit.org/show_bug.cgi?id=323263
rdar://problem/186509338
Reviewed by Tim Nguyen.
Style::FitTolerance derives from PrimitiveNumericOrKeyword and had a
switchOn in its blending function with two handlers: one taking a
LengthPercentage, and a catch-all taking auto that hit
ASSERT_NOT_REACHED().
switchOn hands over the specific type, a Length or a Percentage or a
Calc, and never the combined LengthPercentage wrapper that holds one of
those three. The catch-all takes those as-is, while the LengthPercentage
handler can only take them after a conversion, and C++ prefers the
handler that needs no conversion. So the catch-all won every time and
the blending branch was dead code.
PrimitiveNumericOrKeyword already provides a correct generic blending
implementation for any LengthPercentageOrKeywordDerived type.
GridTrackBreadthLength is a similar type that already uses this so we
basically just utilize it here as well.
Canonical link: https://commits.webkit.org/320383@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
