Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 33f7944ccaed19ca603e650b1aa639f5206e9277
https://github.com/WebKit/WebKit/commit/33f7944ccaed19ca603e650b1aa639f5206e9277
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-09-01 (Tue, 01 Sep 2026)
Changed paths:
M Source/WebKit/Shared/mac/WebEventFactory.mm
M Tools/TestWebKitAPI/Resources/cocoa/custom-slider.html
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] wikimedia.org: Cannot press-and-drag over media player
controls
https://bugs.webkit.org/show_bug.cgi?id=323157
rdar://186303933
Reviewed by Richard Robinson, Aditya Keerthi, and Wenson Hsieh.
createWebMouseEvent read +[NSEvent pressedMouseButtons] to get the
`buttons` field, but this method may not report the right state during
gesture recognizer-driven event synthesis/handling, which produces
pointermoves with .buttons == 0, breaking media controls seeking in
wikimedia.org (which uses Video.js's components).
To fix this, we stop reading pressedMouseButtons and instead derive
buttons from the recognized event type.
Test: AppKitGesturesTests.Basic.pressDragOverRangeInputReportsHeldButton
* Source/WebKit/Shared/mac/WebEventFactory.mm:
(WebKit::buttonsMaskForMouseButton):
(WebKit::buttonsForAutomationEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
* Tools/TestWebKitAPI/Resources/cocoa/custom-slider.html:
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
Canonical link: https://commits.webkit.org/320319@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
