Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0aa45699cc77928adace2bfa1e5c8ea4f46a520f
https://github.com/WebKit/WebKit/commit/0aa45699cc77928adace2bfa1e5c8ea4f46a520f
Author: Qianlang Chen <[email protected]>
Date: 2026-08-27 (Thu, 27 Aug 2026)
Changed paths:
M LayoutTests/inspector/animation/tracking-expected.txt
M LayoutTests/inspector/animation/tracking.html
Log Message:
-----------
[Site Isolation] Web Inspector: Rework protocol test
inspector/animation/tracking.html to prep for frame target enablement
https://bugs.webkit.org/show_bug.cgi?id=322229
rdar://185461510
Reviewed by BJ Burg.
This is a step toward enabling frame target, vending them and using them
in the frontend, by preemptively reworking layout tests that fail when
frame targets are enabled by a fix to webkit.org/b/321734.
A protocol test cannot pick which target a command goes to, so its
DOM.getDocument is answered by the main frame's DOM agent. The node id
in Animation.trackingUpdate comes from the page's DOM agent instead,
which will not push a node before its own document has been requested,
so the event omits nodeId and the "Event should have a node ID"
assertion fails. Every other assertion in the test passes, which is why
this failure reads as unrelated to node ids at first.
Rewrite the test as a frontend inspector test instead, where
WI.domManager requests the document from the page target, which is the
agent the ids in the event come from.
- That dependency is temporary. Once Animation is served per frame, its
node ids will be minted by the frame's DOM agent instead, and the
WI.domManager call here is the line that will have to follow them.
Resolving them that way today would compare ids from two different
spaces, which is the failure this patch removes.
These tracking events have no frontend model of their own:
AnimationObserver forwards them to WI.timelineManager, which drops them
unless a timeline recording is active. The test stubs those three
methods instead of starting a recording, so it keeps testing the
Animation domain rather than acquiring a dependency on the Timeline
domain, which is still page-level and has frame-target problems of its
own.
While here, check what the node id resolves to. Asserting only that
nodeId is a number would also have passed on an id from the wrong
agent's space, which is the bug this test now covers, so the node is
looked up through WI.domManager and matched against the animating
element. The baseline also loses a doubled word in one assertion
message.
No behavior change. inspector/animation/tracking.html now also passes
with frame targets enabled.
* LayoutTests/inspector/animation/tracking-expected.txt:
* LayoutTests/inspector/animation/tracking.html:
Canonical link: https://commits.webkit.org/319971@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
