Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1e5a1c661013133f6437484b79384b9ede46b1e0
https://github.com/WebKit/WebKit/commit/1e5a1c661013133f6437484b79384b9ede46b1e0
Author: Zak Ridouh <[email protected]>
Date: 2026-08-13 (Thu, 13 Aug 2026)
Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/PlatformCocoa.cmake
M Source/cmake/WebKitXcodeSDK.cmake
Log Message:
-----------
[CMake] Fix build after 319115@main
https://bugs.webkit.org/show_bug.cgi?id=321732
rdar://184862545
Reviewed by Kiet Ho.
319115@main moved the AppKit gesture files into UIProcess/mac/AppKitGestures
and added WKDOMDoubleClickGestureRecognizer.swift. It updated SourcesCocoa.txt
and the Xcode project, but CMake lists the Swift sources and the Swift interop
subtarget members by hand, so configuring failed with "Cannot find source
file". Repoint those paths and add the new Swift file. Also add the new
directory to WebKit_PRIVATE_INCLUDE_DIRECTORIES, so that PageClientImplMac.mm
and WebViewImpl.mm can find WKAppKitGestureController.h.
Separately, WEBKIT_RESOLVE_TOOL returned early whenever the variable was
already set, so a cached path outlived the toolchain it pointed at. After an
Xcode update replaced the toolchain directory, configuring an existing build
directory failed in project() with "CMAKE_C_COMPILER ... is not a full path to
an existing compiler tool". CMAKE_OSX_SYSROOT did not have this problem because
WEBKIT_RESOLVE_SDK sets it with FORCE. Check that a cached path still exists
before keeping it.
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/PlatformCocoa.cmake:
* Source/cmake/WebKitXcodeSDK.cmake:
Canonical link: https://commits.webkit.org/319152@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
