Variant finalize predicates to...

Dan Hecht Thu, 13 Aug 2026 15:24:37 -0700

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d37c6da40ba652c58d5a6336ba61cc86ada9ba8
      
https://github.com/WebKit/WebKit/commit/3d37c6da40ba652c58d5a6336ba61cc86ada9ba8
  Author: Dan Hecht <[email protected]>
  Date:   2026-08-13 (Thu, 13 Aug 2026)


  Changed paths:
    M Source/JavaScriptCore/bytecode/CallLinkStatus.cpp
    M Source/JavaScriptCore/bytecode/CallLinkStatus.h
    M Source/JavaScriptCore/bytecode/CallVariant.cpp
    M Source/JavaScriptCore/bytecode/CallVariant.h
    M Source/JavaScriptCore/bytecode/CheckPrivateBrandStatus.cpp
    M Source/JavaScriptCore/bytecode/CheckPrivateBrandStatus.h
    M Source/JavaScriptCore/bytecode/CheckPrivateBrandVariant.cpp
    M Source/JavaScriptCore/bytecode/CheckPrivateBrandVariant.h
    M Source/JavaScriptCore/bytecode/DeleteByStatus.cpp
    M Source/JavaScriptCore/bytecode/DeleteByStatus.h
    M Source/JavaScriptCore/bytecode/DeleteByVariant.cpp
    M Source/JavaScriptCore/bytecode/DeleteByVariant.h
    M Source/JavaScriptCore/bytecode/GetByStatus.cpp
    M Source/JavaScriptCore/bytecode/GetByStatus.h
    M Source/JavaScriptCore/bytecode/GetByVariant.cpp
    M Source/JavaScriptCore/bytecode/GetByVariant.h
    M Source/JavaScriptCore/bytecode/InByStatus.cpp
    M Source/JavaScriptCore/bytecode/InByStatus.h
    M Source/JavaScriptCore/bytecode/InByVariant.cpp
    M Source/JavaScriptCore/bytecode/InByVariant.h
    M Source/JavaScriptCore/bytecode/PutByStatus.cpp
    M Source/JavaScriptCore/bytecode/PutByStatus.h
    M Source/JavaScriptCore/bytecode/PutByVariant.cpp
    M Source/JavaScriptCore/bytecode/PutByVariant.h
    M Source/JavaScriptCore/bytecode/RecordedStatuses.cpp
    M Source/JavaScriptCore/bytecode/SetPrivateBrandStatus.cpp
    M Source/JavaScriptCore/bytecode/SetPrivateBrandStatus.h
    M Source/JavaScriptCore/bytecode/SetPrivateBrandVariant.cpp
    M Source/JavaScriptCore/bytecode/SetPrivateBrandVariant.h

  Log Message:
  -----------
  [JSC] Rename Status/Variant finalize predicates to isStillLive
https://bugs.webkit.org/show_bug.cgi?id=321710
rdar://184852271

Reviewed by Yijia Huang.

These don't finalize anything. They check whether the cells a status or variant 
refers
to are still marked and return a bool; the caller does the clearing.
RecordedStatuses::reconcileWeakReferencesWithoutDeleting zeroes the status in 
place,
reconcileWeakReferences drops it from the vector.

isStillLive is what they call into: StructureSet::isStillAlive,
ObjectPropertyConditionSet::areStillLive, ObjectPropertyCondition::isStillLive.
Adopt that name.

Renamed on CallLinkStatus, CheckPrivateBrandStatus, DeleteByStatus, GetByStatus,
InByStatus, PutByStatus, SetPrivateBrandStatus and each of their variants.

No behavior change.

* Source/JavaScriptCore/bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::isStillLive):
(JSC::CallLinkStatus::finalize): Deleted.
* Source/JavaScriptCore/bytecode/CallLinkStatus.h:
* Source/JavaScriptCore/bytecode/CallVariant.cpp:
(JSC::CallVariant::isStillLive):
(JSC::CallVariant::finalize): Deleted.
* Source/JavaScriptCore/bytecode/CallVariant.h:
* Source/JavaScriptCore/bytecode/CheckPrivateBrandStatus.cpp:
(JSC::CheckPrivateBrandStatus::isStillLive):
(JSC::CheckPrivateBrandStatus::finalize): Deleted.
* Source/JavaScriptCore/bytecode/CheckPrivateBrandStatus.h:
* Source/JavaScriptCore/bytecode/CheckPrivateBrandVariant.cpp:
(JSC::CheckPrivateBrandVariant::isStillLive):
(JSC::CheckPrivateBrandVariant::finalize): Deleted.
* Source/JavaScriptCore/bytecode/CheckPrivateBrandVariant.h:
* Source/JavaScriptCore/bytecode/DeleteByStatus.cpp:
(JSC::DeleteByStatus::isStillLive):
(JSC::DeleteByStatus::finalize): Deleted.
* Source/JavaScriptCore/bytecode/DeleteByStatus.h:
* Source/JavaScriptCore/bytecode/DeleteByVariant.cpp:
(JSC::DeleteByVariant::isStillLive):
(JSC::DeleteByVariant::finalize): Deleted.
* Source/JavaScriptCore/bytecode/DeleteByVariant.h:
* Source/JavaScriptCore/bytecode/GetByStatus.cpp:
(JSC::GetByStatus::isStillLive):
(JSC::GetByStatus::finalize): Deleted.
* Source/JavaScriptCore/bytecode/GetByStatus.h:
* Source/JavaScriptCore/bytecode/GetByVariant.cpp:
(JSC::GetByVariant::isStillLive):
(JSC::GetByVariant::finalize): Deleted.
* Source/JavaScriptCore/bytecode/GetByVariant.h:
* Source/JavaScriptCore/bytecode/InByStatus.cpp:
(JSC::InByStatus::isStillLive):
(JSC::InByStatus::finalize): Deleted.
* Source/JavaScriptCore/bytecode/InByStatus.h:
* Source/JavaScriptCore/bytecode/InByVariant.cpp:
(JSC::InByVariant::isStillLive):
(JSC::InByVariant::finalize): Deleted.
* Source/JavaScriptCore/bytecode/InByVariant.h:
* Source/JavaScriptCore/bytecode/PutByStatus.cpp:
(JSC::PutByStatus::isStillLive):
(JSC::PutByStatus::finalize): Deleted.
* Source/JavaScriptCore/bytecode/PutByStatus.h:
* Source/JavaScriptCore/bytecode/PutByVariant.cpp:
(JSC::PutByVariant::isStillLive):
(JSC::PutByVariant::finalize): Deleted.
* Source/JavaScriptCore/bytecode/PutByVariant.h:
* Source/JavaScriptCore/bytecode/RecordedStatuses.cpp:
(JSC::RecordedStatuses::reconcileWeakReferencesWithoutDeleting):
(JSC::RecordedStatuses::reconcileWeakReferences):
* Source/JavaScriptCore/bytecode/SetPrivateBrandStatus.cpp:
(JSC::SetPrivateBrandStatus::isStillLive):
(JSC::SetPrivateBrandStatus::finalize): Deleted.
* Source/JavaScriptCore/bytecode/SetPrivateBrandStatus.h:
* Source/JavaScriptCore/bytecode/SetPrivateBrandVariant.cpp:
(JSC::SetPrivateBrandVariant::isStillLive):
(JSC::SetPrivateBrandVariant::finalize): Deleted.
* Source/JavaScriptCore/bytecode/SetPrivateBrandVariant.h:

Canonical link: https://commits.webkit.org/319146@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

[webkit-changes] [WebKit/WebKit] 3d37c6: [JSC] Rename Status/Variant finalize predicates to...

Reply via email to