Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e29b63174052d82929fcc8e1081f06573ffb9583
https://github.com/WebKit/WebKit/commit/e29b63174052d82929fcc8e1081f06573ffb9583
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-08-13 (Thu, 13 Aug 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm
M
Source/WebKit/UIProcess/mac/AppKitGestures/WKDirectionalScrollLockTracker.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Certain diagonal scrolls should be able to bypass
directional locking
https://bugs.webkit.org/show_bug.cgi?id=321650
rdar://184776089
Reviewed by Tim Horton.
318029@main introduced support for directional scroll locking for
diagonal scrolls. This is generally the mode in which we want to
propagate gesture-driven scroll deltas. However, certain flows
necessitate that we opt out of locking. WKDirectionalScrollTracker does
not offer any API escape hatch for these cases, though, so that is what
we teach it in this patch.
Test: AppKitGesturesTests/Basic/diagonallySwipingBetweenSpacesScrollsBothAxes()
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController sendWheelEventForGesture:]):
(-[WKAppKitGestureController startMomentumIfNeededForGesture:]):
* Source/WebKit/UIProcess/mac/WKDirectionalScrollLockTracker.swift:
(WKDirectionalScrollLockTracker.update(_:canScrollHorizontally:canScrollVertically:prefersUnlocked:time:)):
(WKDirectionalScrollLockTracker.filterVelocity(_:prefersUnlocked:)):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
Canonical link: https://commits.webkit.org/319143@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
