Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 458076ee25d84e0dfac40742b70c9e32eebf0c5b
https://github.com/WebKit/WebKit/commit/458076ee25d84e0dfac40742b70c9e32eebf0c5b
Author: Pascoe <[email protected]>
Date: 2026-08-12 (Wed, 12 Aug 2026)
Changed paths:
A
LayoutTests/http/wpt/identity/formats/openid4vp/openid4vp-roundtrip.https-expected.txt
A
LayoutTests/http/wpt/identity/formats/openid4vp/openid4vp-roundtrip.https.html
M Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp
M Source/WebCore/Modules/identity/DigitalCredential.cpp
M Source/WebCore/Modules/identity/DigitalCredentialPresentationProtocol.h
M Source/WebKit/UIProcess/Automation/BidiDigitalCredentialsAgent.cpp
M Source/WebKit/UIProcess/Automation/protocol/BidiDigitalCredentials.json
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Wire up the virtual wallet mock for OpenID4VP signed and multisigned protocols
https://bugs.webkit.org/show_bug.cgi?id=320919
rdar://problem/183950595
Reviewed by Marcos Caceres and Abrar Rahman Protyasha.
setVirtualWalletBehaviorForTesting ignored the protocol parameter
(hardcoded to org-iso-mdoc), making it impossible to test OpenID4VP
through the virtual wallet. Parse the protocol string into the correct
enum value, extend the BiDi schema with the three OpenID4VP identifiers,
and fix the coordinator empty-check that rejected OpenID4VP-only request
sets (the validator only handles mdoc, so the validated set was always
empty for OpenID4VP).
Extract digitalCredentialPresentationProtocolFromString() so the
string-to-enum mapping lives in one place. Refactor convertProtocolString
to use it, with an explicit skip for openid4vp-v1-unsigned until DCQL
parsing lands (webkit.org/b/320207).
* Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp:
(WebCore::CredentialRequestCoordinator::prepareCredentialRequests):
* Source/WebCore/Modules/identity/DigitalCredential.cpp:
(WebCore::convertProtocolString):
* Source/WebCore/Modules/identity/DigitalCredentialPresentationProtocol.h:
(WebCore::digitalCredentialPresentationProtocolFromString):
* Source/WebKit/UIProcess/Automation/BidiDigitalCredentialsAgent.cpp:
(WebKit::toPresentationProtocol):
* Source/WebKit/UIProcess/Automation/protocol/BidiDigitalCredentials.json:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setVirtualWalletBehaviorForTesting):
*
LayoutTests/http/wpt/identity/formats/openid4vp/openid4vp-roundtrip.https.html:
Added.
*
LayoutTests/http/wpt/identity/formats/openid4vp/openid4vp-roundtrip.https-expected.txt:
Added.
Canonical link: https://commits.webkit.org/319055@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
